Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global ranking: wrong rank for first row #1927

Open
Mindhral opened this issue Oct 25, 2023 · 0 comments
Open

Global ranking: wrong rank for first row #1927

Mindhral opened this issue Oct 25, 2023 · 0 comments
Labels

Comments

@Mindhral
Copy link

Description
On Global Ranking page, when using pagination, the first row shows the rank of the player on hardcore points ranking instead of the selected ranking.

To Reproduce

  1. Go to 'Global Ranking' page
  2. Stay on 'All Time' type
  3. Select any ranking (sort) other than 'Hardcore Points' and 'Softcore Points'
  4. From the code, I believe the option 'All Users' must be selected, but I don't have enough followed users to check
  5. Go to next page(s), the first row shows the rank by points

Expected behavior
All rows ranked according to the same logic.

Screenshots
image

Additional context
Seems to be a consequence of #1328 which handles tied ranks.
The function getUserRank, used to retrieve the rank for the first row, only handles Points (hardcore, softcore or "retro"), and the call in globalRanking.php (l.238 on current master) only use the first two anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants