Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't calculate rank for highest followed user #1366

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Feb 14, 2023

https://discord.com/channels/310192285306454017/1048299730670735421/1075113426105409646

Introduced by #1328. The rank of the first user on a page is looked up to ensure the shared rank is carried over between pages.

There's no easy way to do that for the following list, but there's less chance of users sharing ranks there, so I've removed the lookup. The 26th user on the following list will have rank 26, even if they should share a rank with whoever's at 25.

@luchaos luchaos merged commit 61c0a09 into RetroAchievements:master Feb 25, 2023
@Jamiras Jamiras deleted the fix_following_rank branch February 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants