moved import out of type check #8739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into change-validate-data-type
Refactoring variables
Merge 2.6.x to main
Co-authored-by: Joe Juzl <[email protected]>
Fix for missing intent warnings when running rasa test
Merge 2.6.x into main after 2.6.2 release
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 1.34.0 to 2.2.1. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v1.34.0...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]>
…ed-nlu-regression-tests
…s-on-scheduled-nlu-regression-tests Various improvements for the notification of scheduled model regression tests
Add verify stories and rules actions in domain to rasa data validate
…cy. (#8716) * Changed the default config to train the RulePolicy before the TEDPolicy. * fix test files
Bump pytest-xdist from 1.34.0 to 2.2.1
|
How about targeting 2.6.x for this? |
wochinge
reviewed
May 25, 2021
| @@ -5,10 +5,11 @@ | |||
| from rasa.core.interpreter import RasaNLUInterpreter | |||
| from rasa.shared.nlu.interpreter import NaturalLanguageInterpreter | |||
| from rasa.shared.utils.cli import print_error, print_success | |||
| from rasa.core.agent import create_agent | |||
There was a problem hiding this comment.
can you please reference the function by module instead of importing it directly? See here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)