Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements for the notification of scheduled model regression tests #8510

Conversation

HotThoughts
Copy link
Contributor

@HotThoughts HotThoughts commented Apr 20, 2021

Proposed changes:

Definition of Done:

The cases that tested:

TODOs before merge

  • remove fake data
  • uncomment config
  • update slack webhook

@virtualroot virtualroot force-pushed the add-tolerance-to-automatic-alerts-on-scheduled-nlu-regression-tests branch from d447edb to a2785e6 Compare April 28, 2021 15:35
@tczekajlo tczekajlo force-pushed the add-tolerance-to-automatic-alerts-on-scheduled-nlu-regression-tests branch from 450c0ea to 2fc00d9 Compare May 3, 2021 08:37
@HotThoughts HotThoughts changed the title Add tolerance to automatic alerts on scheduled nlu regression tests Various improvements for the notification of scheduled model regression tests May 3, 2021
@HotThoughts
Copy link
Contributor Author

@tczekajlo this one is almost done. The performance analyses and issue creation steps are tested and ready to review. 🤘🏻

One last step is to test the slack notification. We were using the webhook SLACK_TEST_WEBHOOK. Do we still have it in our secret?

@tczekajlo
Copy link
Contributor

@tczekajlo this one is almost done. The performance analyses and issue creation steps are tested and ready to review. 🤘🏻

One last step is to test the slack notification. We were using the webhook SLACK_TEST_WEBHOOK. Do we still have it in our secret?

Coool, yes, you can use the secret.

@HotThoughts HotThoughts marked this pull request as ready for review May 4, 2021 11:52
@HotThoughts HotThoughts requested a review from a team as a code owner May 4, 2021 11:52
@HotThoughts HotThoughts requested review from tczekajlo and kedz and removed request for a team May 4, 2021 11:52
Copy link
Contributor

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left small suggestions 😄

.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
.github/workflows/ci-model-regression-on-schedule.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

@tczekajlo tczekajlo merged commit 110916c into main May 18, 2021
@tczekajlo tczekajlo deleted the add-tolerance-to-automatic-alerts-on-scheduled-nlu-regression-tests branch May 18, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants