Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the default config to train the RulePolicy before the TEDPolicy. #8716

Merged
merged 3 commits into from
May 19, 2021
Merged

Changed the default config to train the RulePolicy before the TEDPolicy. #8716

merged 3 commits into from
May 19, 2021

Conversation

joejuzl
Copy link
Contributor

@joejuzl joejuzl commented May 18, 2021

Proposed changes:
Changed the default config to train the RulePolicy before the TEDPolicy.
Fixes: #7691

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)

@joejuzl joejuzl requested a review from ancalita May 18, 2021 15:29
ancalita
ancalita reviewed May 18, 2021
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and happy to approve as soon as the 2 tests in tests.shared.importers.test_autoconfig are tweaked, I think they fail because they expect the old default config format 🤔

@joejuzl joejuzl requested a review from ancalita May 19, 2021 11:40
@joejuzl joejuzl merged commit ae9989c into main May 19, 2021
@joejuzl joejuzl deleted the feature-7691-by_default_train_rule_policy_before_TED branch May 19, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise "conflicting rules/stories" error message before training the TEDPolicy model
2 participants
@joejuzl @ancalita