Skip to content

Conversation

@Steven-LiuSF
Copy link

Signed-off-by: Steven Liu [email protected]

拉取/合并请求描述:(PR description)

[Add rk2108 bsp base support]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

感谢提交PR。
有几个问题,

  1. 需要有一个readme来向使用者简单介绍一下这个BSP
  2. 这几个bin文件是干什么的,可否以链接形式在readme中提供?
    image

修改不需要关闭此pr,只需要接着提交commit就可以了。

@Steven-LiuSF
Copy link
Author

感谢提交PR。 有几个问题,

  1. 需要有一个readme来向使用者简单介绍一下这个BSP
  2. 这几个bin文件是干什么的,可否以链接形式在readme中提供?
    image

修改不需要关闭此pr,只需要接着提交commit就可以了。

这个BSP是个基础版本,之后适配Studio时会增加介绍说明。这几个bin文件是打包和下载工具,可以在mkimage.sh中看到有使用。

@mysterywolf
Copy link
Member

OK 请提供一份readme,介绍一下mcu的概况以及维护人的联系方式 参考:
https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/stm32f103-blue-pill/README_zh.md
如果该bsp没有海外使用人数较少的话仅提供中文readme即可。
可以直接push 新的commit,不需要关闭pr重新创建新的pr

@mysterywolf mysterywolf added the +2 Agree +2 label Jun 9, 2022
@Steven-LiuSF
Copy link
Author

发现RT_UNUSED的实现变了,会影响到bsp/rockchip/rk2108/board/common/iomux_base.c,出现类似以下报错:

board/common/iomux_base.c:18:18: error: expected ';' before 'void'
18 | RT_WEAK RT_UNUSED void m4_jtag_iomux_config(void)

请问下对于函数的UNUSED应该怎么修改?

@mysterywolf
Copy link
Member

不用加RT_UNUSED 就好

@Steven-LiuSF
Copy link
Author

不用加RT_UNUSED 就好

Done

@Guozhanxin Guozhanxin merged commit 8b60b58 into RT-Thread:master Jun 9, 2022
@Steven-LiuSF Steven-LiuSF deleted the bsp-rockchip branch June 9, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+2 Agree +2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants