Repository navigation
Conversation
Signed-off-by: Adam360x <Adam.pryor@amd.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changelog omits user-visible behavior changes: unavailable metrics remain N/A, and GPUs without a PLX sensor now report N/A instead of a placeholder reading.
1 open issue
What changed in this PR
This draft tooling experiment edits an existing amd-smi release note without changing runtime behavior.
Changes:
- Adds
ROCM-29548to the integrated-GPU metrics fix heading. - Replaces user-visible output details with an explanation of internal APU metrics-reader dispatch.
| File | Description |
|---|---|
projects/amdsmi/CHANGELOG.md |
Updates the ticket reference and wording of the GPU metrics release note. |
Review effort: Balanced
| - **Fixed GPU metrics returning no data on integrated GPUs**. | ||
| - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading. | ||
| - **Fixed GPU metrics returning no data on integrated GPUs (ROCM-29548)**. | ||
| - `lookup_header_flag_version()` in `rocm_smi_gpu_metrics.cc` now routes APU gpu_metrics tables to the `kApuMetricV24` reader, so `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` no longer fail on APUs such as gfx1103. |
1 task done
adam360x
added a commit
that referenced
this pull request
Nov 3, 2026
…14718) ## Motivation Copilot code review runs on every `develop` PR but never sees the amd-smi review agents (maintainer, skeptic, security, tests and the rest): it reads instruction files only from the repository root and cannot run custom agents, so `projects/amdsmi/.github/agents/` is ignored. ## Technical Details **Copilot instructions** (`.github/instructions/amdsmi-review*.instructions.md`): - One symlink per review agent (the orchestrator and all 10 lenses) to its file in `projects/amdsmi/.github/agents/`, so Copilot code review always reads the current agents. Nothing is copied. **Review agents** (`projects/amdsmi/.github/agents/amdsmi-review*.agent.md`): - Add `applyTo: "projects/amdsmi/**"`, so only PRs that change amd-smi files get the agents, and `excludeAgent: "cloud-agent"`, which keeps them out of the Copilot cloud agent. Copilot reads both through the symlinks; VS Code doesn't use them for agent files. **Code owners** (`.github/CODEOWNERS`): - Give the symlinks to @ROCm/smi-reviewers, like `/.github/workflows/amdsmi-*.yml`. **Side effect**: VS Code also reads root `.github/instructions/`. With the whole repository open, it attaches the agents to agent-mode edits of files under `projects/amdsmi/`. ## Issue Tracking JIRA ID: TBD ## Test Plan - Opened draft PRs into throwaway branches, each with the same CHANGELOG-only diff and the review agents in a different place, and requested a Copilot review on each. - Load test: appended a test-only "flag the word X" rule to the end of each of the 11 agents (a different word per agent) and changed one CHANGELOG line that contains all 11 words. - Ran this branch against a true CHANGELOG entry rewritten with internal names, and an entry claiming a fix that `develop` doesn't have. - Root pre-commit hooks; GitHub CODEOWNERS errors API. ## Test Result - Copilot applied the agents from root `.github/instructions/` files, copied (#14719) or symlinked (#14750, #14798): all 11 test words each time, so it reads every agent to the end. It ignored them in `projects/amdsmi/REVIEW.md` (#14703, #14708), behind a root file pointing into `projects/amdsmi/` (#14702, #14707), and behind a root review skill pointing there (#14751, #14752). - This branch: Copilot flagged a CHANGELOG entry that swapped the user-visible result for internal details (#14799) and an entry claiming a fix that `develop` doesn't have (#14800). - Pre-commit: pass. CODEOWNERS: no new errors (the only error, an unknown owner on the `rocm-core/rdhc` line, is on `develop` too). ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Signed-off-by: Adam360x <Adam.pryor@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft experiment for review tooling. Please do not review or merge.
Targets a throwaway branch and will be closed within a day.