[DO NOT MERGE] docs(amdsmi): update the changelog (check L) by adam360x · Pull Request #14798 · ROCm/rocm-systems

adam360x · 2026-11-02T14:31:59Z

Draft experiment for review tooling. Please do not review or merge.

Targets a throwaway branch and will be closed within a day.

Signed-off-by: Adam360x <Adam.pryor@amd.com>

Copilot

🟡 Changes recommended

Unresolved wording and terminology nits remain in the changelog entry at projects/amdsmi/CHANGELOG.md:175.

11 open issues

Use “APUs” instead of “devices” · New
Use “without data” instead of “empty” · New
Use “did not succeed” instead of “failed” · New
Use “rather than” instead of “instead of” · New
Describe the resulting output explicitly · New
Use “shown as” instead of “marked” · New
Use “substitute” instead of “placeholder” · New
Use “expose” instead of “provide” · New
Use “measurement” instead of “reading” · New
Use “remaining values” instead of “rest” · New
Use “temperature probe” instead of “sensor” · New

What changed in this PR

This draft tooling experiment makes a wording-only change to the amd-smi changelog. It does not change library or CLI behavior and is marked not for merging.

Changes:

Replaces “Those devices” with “These devices” in the existing integrated-GPU metrics entry.

File	Description
`projects/amdsmi/CHANGELOG.md`	Adjusts one demonstrative in a resolved-issue description.

_{Review effort: Balanced}


 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.



 - **Fixed GPU metrics returning no data on integrated GPUs**.  
-  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. Those devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.
+  - `amdsmi_get_gpu_metrics_info()` and `amdsmi_get_gpu_activity()` failed on APUs such as gfx1103, leaving PLX temperature, GPU utilization and `amd-smi metric` empty. These devices now report the values they provide with the rest marked N/A, and any GPU without a PLX sensor now reports N/A there instead of a placeholder reading.


…14718) ## Motivation Copilot code review runs on every `develop` PR but never sees the amd-smi review agents (maintainer, skeptic, security, tests and the rest): it reads instruction files only from the repository root and cannot run custom agents, so `projects/amdsmi/.github/agents/` is ignored. ## Technical Details **Copilot instructions** (`.github/instructions/amdsmi-review*.instructions.md`): - One symlink per review agent (the orchestrator and all 10 lenses) to its file in `projects/amdsmi/.github/agents/`, so Copilot code review always reads the current agents. Nothing is copied. **Review agents** (`projects/amdsmi/.github/agents/amdsmi-review*.agent.md`): - Add `applyTo: "projects/amdsmi/**"`, so only PRs that change amd-smi files get the agents, and `excludeAgent: "cloud-agent"`, which keeps them out of the Copilot cloud agent. Copilot reads both through the symlinks; VS Code doesn't use them for agent files. **Code owners** (`.github/CODEOWNERS`): - Give the symlinks to @ROCm/smi-reviewers, like `/.github/workflows/amdsmi-*.yml`. **Side effect**: VS Code also reads root `.github/instructions/`. With the whole repository open, it attaches the agents to agent-mode edits of files under `projects/amdsmi/`. ## Issue Tracking JIRA ID: TBD ## Test Plan - Opened draft PRs into throwaway branches, each with the same CHANGELOG-only diff and the review agents in a different place, and requested a Copilot review on each. - Load test: appended a test-only "flag the word X" rule to the end of each of the 11 agents (a different word per agent) and changed one CHANGELOG line that contains all 11 words. - Ran this branch against a true CHANGELOG entry rewritten with internal names, and an entry claiming a fix that `develop` doesn't have. - Root pre-commit hooks; GitHub CODEOWNERS errors API. ## Test Result - Copilot applied the agents from root `.github/instructions/` files, copied (#14719) or symlinked (#14750, #14798): all 11 test words each time, so it reads every agent to the end. It ignored them in `projects/amdsmi/REVIEW.md` (#14703, #14708), behind a root file pointing into `projects/amdsmi/` (#14702, #14707), and behind a root review skill pointing there (#14751, #14752). - This branch: Copilot flagged a CHANGELOG entry that swapped the user-visible result for internal details (#14799) and an entry claiming a fix that `develop` doesn't have (#14800). - Pre-commit: pass. CODEOWNERS: no new errors (the only error, an unknown owner on the `rocm-core/rdhc` line, is on `develop` too). ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Signed-off-by: Adam360x <Adam.pryor@amd.com>

docs(amdsmi): update the changelog

f89e5c3

Signed-off-by: Adam360x <Adam.pryor@amd.com>

adam360x requested a balanced review from Copilot November 2, 2026 14:32

github-actions Bot added the project: amdsmi label Nov 2, 2026

Copilot started reviewing on behalf of adam360x November 2, 2026 14:32

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

systems-assistant Bot added the organization: ROCm label Nov 2, 2026

adam360x closed this Nov 2, 2026

adam360x deleted the users/adam360x/ccr-v4-L-head branch November 2, 2026 14:37

adam360x mentioned this pull request Nov 2, 2026

chore(amdsmi): use the amd-smi review agents in Copilot code review #14718

Merged

1 task done

Navigation Menu

Repository navigation

[DO NOT MERGE] docs(amdsmi): update the changelog (check L) - #14798

[DO NOT MERGE] docs(amdsmi): update the changelog (check L)#14798
adam360x wants to merge 1 commit into
users/adam360x/ccr-v4-L-basefrom
users/adam360x/ccr-v4-L-head

adam360x commented Nov 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adam360x commented Nov 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants