chore(amdsmi): use the amd-smi review agents in Copilot code review by adam360x · Pull Request #14718 · ROCm/rocm-systems

adam360x · 2026-10-30T19:52:26Z

Motivation

Copilot code review runs on every develop PR but never sees the amd-smi review agents (maintainer, skeptic, security, tests and the rest): it reads instruction files only from the repository root and cannot run custom agents, so projects/amdsmi/.github/agents/ is ignored.

Technical Details

Copilot instructions (.github/instructions/amdsmi-review*.instructions.md):

One symlink per review agent (the orchestrator and all 10 lenses) to its file in projects/amdsmi/.github/agents/, so Copilot code review always reads the current agents. Nothing is copied.

Review agents (projects/amdsmi/.github/agents/amdsmi-review*.agent.md):

Add applyTo: "projects/amdsmi/**", so only PRs that change amd-smi files get the agents, and excludeAgent: "cloud-agent", which keeps them out of the Copilot cloud agent. Copilot reads both through the symlinks; VS Code doesn't use them for agent files.

Code owners (.github/CODEOWNERS):

Give the symlinks to @ROCm/smi-reviewers, like /.github/workflows/amdsmi-*.yml.

Side effect: VS Code also reads root .github/instructions/. With the whole repository open, it attaches the agents to agent-mode edits of files under projects/amdsmi/.

Issue Tracking

JIRA ID: TBD

Test Plan

Opened draft PRs into throwaway branches, each with the same CHANGELOG-only diff and the review agents in a different place, and requested a Copilot review on each.
Load test: appended a test-only "flag the word X" rule to the end of each of the 11 agents (a different word per agent) and changed one CHANGELOG line that contains all 11 words.
Ran this branch against a true CHANGELOG entry rewritten with internal names, and an entry claiming a fix that develop doesn't have.
Root pre-commit hooks; GitHub CODEOWNERS errors API.

Test Result

Copilot applied the agents from root .github/instructions/ files, copied ([DO NOT MERGE] docs(amdsmi): update the changelog (check L) #14719) or symlinked ([DO NOT MERGE] docs(amdsmi): update the changelog (check S1) #14750, [DO NOT MERGE] docs(amdsmi): update the changelog (check L) #14798): all 11 test words each time, so it reads every agent to the end. It ignored them in projects/amdsmi/REVIEW.md ([DO NOT MERGE] docs(amdsmi): changelog entry for the process list fix (exp D) #14703, [DO NOT MERGE] docs(amdsmi): changelog entry for the process list fix (exp D2) #14708), behind a root file pointing into projects/amdsmi/ ([DO NOT MERGE] docs(amdsmi): changelog entry for the process list fix (exp C) #14702, [DO NOT MERGE] docs(amdsmi): changelog entry for the process list fix (exp C2) #14707), and behind a root review skill pointing there ([DO NOT MERGE] docs(amdsmi): update the changelog (check S2) #14751, [DO NOT MERGE] docs(amdsmi): update the changelog (check S3) #14752).
This branch: Copilot flagged a CHANGELOG entry that swapped the user-visible result for internal details ([DO NOT MERGE] docs(amdsmi): update the changelog (check M) #14799) and an entry claiming a fix that develop doesn't have ([DO NOT MERGE] docs(amdsmi): update the changelog (check F) #14800).
Pre-commit: pass. CODEOWNERS: no new errors (the only error, an unknown owner on the rocm-core/rdhc line, is on develop too).

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

- Add .github/instructions/amdsmi.instructions.md, scoped to projects/amdsmi/**, so Copilot code review applies the amd-smi maintainers' review rules to amd-smi changes. Copilot code review only reads instruction files at the repository root. - Give the file to @ROCm/smi-reviewers in CODEOWNERS, like the amdsmi workflows. Signed-off-by: Adam360x <Adam.pryor@amd.com>

therock-pr-bot · 2026-10-30T19:53:05Z

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

Copilot

🟡 Changes recommended

The review instructions would cause false positives by mischaracterizing ASSERT_* behavior in void lambdas and prohibiting documented partial metrics results containing N/A values.

2 open issues

What changed in this PR

This PR makes amd-smi’s review guidance available to Copilot through a repository-root instruction file, scoped to projects/amdsmi/**.

Changes:

Adds review checks for correctness, API compatibility, concurrency, tests, and documentation, placing code checks before wording rules.
Excludes the instructions from the Copilot cloud agent.
Assigns ownership of the instruction file to @ROCm/smi-reviewers.

File	Description
`.github/instructions/amdsmi.instructions.md`	Adds scoped amd-smi guidance for Copilot code review.
`.github/CODEOWNERS`	Assigns the new instruction file to the amd-smi reviewers.

_{Review effort: Balanced}

- Replace the hand-written summary with the review agents themselves: tools/update_copilot_review_instructions.py copies the body of each .github/agents/amdsmi-review*.agent.md, unchanged, into .github/instructions/<agent>.instructions.md at the repository root, scoped to projects/amdsmi/** - Add the AMDSMI Copilot Review Instructions workflow, which fails when a copy no longer matches its agent - Give the generated files to @ROCm/smi-reviewers in CODEOWNERS Signed-off-by: Adam360x <Adam.pryor@amd.com>

- Replace the generated copies in .github/instructions/ with symlinks to the review agents, so Copilot code review always reads the current agents - Add applyTo and excludeAgent to each review agent's frontmatter, which Copilot code review reads through the symlinks - Remove the generator script and its CI check, which the symlinks make unnecessary Signed-off-by: Adam360x <Adam.pryor@amd.com>

geomin12

lgtm, but i would like to see amdsmi team folks review as well

adam360x · 2026-11-02T23:16:46Z

@copilot resolve the merge conflicts in this pull request

…smi-copilot-review-instructions # Conflicts: # .github/CODEOWNERS # projects/amdsmi/.github/agents/amdsmi-review-maintainer.agent.md Co-authored-by: adam360x <61172547+adam360x@users.noreply.github.com>

Copilot · 2026-11-02T23:21:53Z

@copilot resolve the merge conflicts in this pull request

Merged develop and resolved both conflicts in merge commit d30999804.

systems-assistant · 2026-11-05T15:44:57Z

TheRock Submodule Bump Activity

Newest first

2026-11-05 — Included in TheRock via ROCm/TheRock#9739.

Copilot AI balanced review requested due to automatic review settings October 30, 2026 19:52

adam360x requested a review from a team as a code owner October 30, 2026 19:52

Copilot started reviewing on behalf of adam360x October 30, 2026 19:53

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread .github/instructions/amdsmi.instructions.md Resolved

Comment thread .github/instructions/amdsmi.instructions.md Resolved

systems-assistant Bot added the organization: ROCm label Oct 30, 2026

adam360x changed the title ~~chore(amdsmi): add Copilot code review instructions~~ chore(amdsmi): use the amd-smi review agents in Copilot code review Oct 30, 2026

adam360x requested a review from a team as a code owner October 30, 2026 20:12

github-actions Bot added project: amdsmi github actions Pull requests that update GitHub Actions code labels Oct 30, 2026

adam360x requested a review from geomin12 November 2, 2026 14:39

geomin12 approved these changes Nov 2, 2026

View reviewed changes

Copilot started work on behalf of adam360x November 2, 2026 23:17

View session

Copilot finished work on behalf of adam360x November 2, 2026 23:22

marifamd approved these changes Nov 3, 2026

View reviewed changes

gabrpham approved these changes Nov 3, 2026

View reviewed changes

adam360x merged commit 2be94ee into develop Nov 3, 2026
33 of 34 checks passed

adam360x deleted the users/adam360x/amdsmi-copilot-review-instructions branch November 3, 2026 21:11

Navigation Menu

Repository navigation

chore(amdsmi): use the amd-smi review agents in Copilot code review - #14718

chore(amdsmi): use the amd-smi review agents in Copilot code review#14718
adam360x merged 4 commits into
developfrom
users/adam360x/amdsmi-copilot-review-instructions

adam360x commented Oct 30, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

geomin12 left a comment

Uh oh!

adam360x commented Nov 2, 2026

Uh oh!

Copilot AI commented Nov 2, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Nov 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

adam360x commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

Uh oh!

therock-pr-bot Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Policy Checks Passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

adam360x commented Nov 2, 2026

Uh oh!

Copilot AI commented Nov 2, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Nov 5, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adam360x commented Oct 30, 2026 •

edited

Loading

therock-pr-bot Bot commented Oct 30, 2026 •

edited

Loading