Skip to content

Revert "[rocjitsu] Clear the reserved wave32 descriptor bit on gfx125x" - #13366

Merged
kuhar merged 1 commit into
developfrom
revert-13141-users/kuhar/gfx125x-wavefront-size-bit
Oct 13, 2026
Merged

kuhar merged 1 commit into
developfrom
revert-13141-users/kuhar/gfx125x-wavefront-size-bit

Conversation

@kuhar

@kuhar kuhar commented Oct 13, 2026

Copy link
Copy Markdown
Member

Reverts #13141. This broke A0 environments.

@kuhar
kuhar requested review from a team and atgutier as code owners October 13, 2026 16:06
Copilot AI balanced review requested due to automatic review settings October 13, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@therock-pr-bot

therock-pr-bot Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@github-actions

Copy link
Copy Markdown
Contributor

gfx1250 B0-to-A0 translation baseline

Warning

This PR changes 20128 translated output SHA-256 value(s).

Compared 74bebdd22abdafb521f4246bdeb64f14b9f6d55c against develop baseline 021334819094edecbbc606a59749aa29e2f2db27.

Input SHA-256 Input bytes develop output develop bytes PR output PR bytes
00023c9f3fc277f35d928cca3a2e5614bba26b581e71abd3bbcff3fe3a417405 30,016 79551671a7f63428bd4bba2e4c86eb472e17ee243743fd68b77e996c043181c8 30,016 40d1aaebac2c8db6317e35c91aae8a31de797d931e6d2482f626fd37c095caed 30,016
0003ca30717a5b9f4a6a7becffbec48d92bde2519801991100b19bbfa192e7fc 33,712 457912f9c6ee4f84a2c75fc57ca516a1cda9b2fa16ac6ee49b5f26b4f065e972 37,808 c28b4a28819e3ce257ba5d07c2a49a85a783cab9d4118c030773451387578933 37,808
00051de4267e657611ddb6f40ee32d2fd20d6d55c2ecabb8cc3d0fdc63f64dc4 25,912 91c28247b7a420143cf326f9599cf0402af30aa99e4122f83e996b45d3c2690e 25,912 97a8dbad5c9e24142ca19e7a636378f877a69e90ffa65211b80ea8a3eabd78cd 25,912
001174c693f68c89f2b40821aa92f4f1fbdfce4a6c99d499ac71cd07e5660ec3 107,392 2ed8608be437d62b6b045e381011e38a903db9fb4f8525f6b9a95815edf4d5b3 111,488 6db8f5182640c903614d38b41dac8bf191c067a4727f167575676888c2307e65 111,488
0011b3e9c6cb04a4a7ffacb58a22089c8f8010df50153d12ee679a9a6bdda999 33,584 b813f56618ed8dd66e67045205dd8af46c11b963c5ceaedb9f75ae257a9a9da2 33,584 659600570029fdd31cefbbaaf9b591ea47b344e7a0eaeebb851822f147239774 33,584
0011f15708b0977fa2ad09b399fe9013f69bfaab8142bda7080dd36b2096f86f 47,032 820a0df48d7c9323135255ba26ee0c346878994f02760816410b2e01f015f16b 51,128 bf0958013fe11b996bc7b00715366933bc242d6d42bd53ef45734614ede4766a 51,128
001315b0c75b0cd15c73c7c799cf2189cc81157485b35cafec7e2d45f0128e7b 131,104 0456b3f2ccdc606be1c6d6f9d5d54a3293f01607f634fb7723b53dd072ea2803 131,104 80081ac5936450bf82993aa77c443876999af5ddbd6fc233ee588f3c797ebd46 131,104
001396922af6f539c3633ab5031cb13267600f559b33dea5fe4738b45c17812a 20,216 a1e0db9a88e978d8000fbcbbefcd375fb58b28fdda5dc729410966eacd744507 20,216 296decedcde7fc7fdee534440bf8839c5388f3e2b128a66f0a4502786d812f1f 20,216
0014bf0db147eca60bc664498f01a3aceaa44fe139e2eb0660cef3b03d1ef562 25,760 c424428a45054df6731863c4ccdb9e6b077d311c9de63aa25ba85a8e1df2aaa5 25,760 50b6bb941473b8ae390b3cf50fd0323e1c479d1be0895aa6df09f08afe74c627 25,760
0020483e284809af4f239393b72a457e351b1837f8c79ea961e622134d819b02 21,112 91fdee70b5fe0074b6fbd2ad59531f46b88a266e31ef0e3ab82eafeda19f94d4 21,112 b097c408b40c5aa241db2fe7d0db715161200abb2094960202d29e6c9bdc0212 21,112
002d4e14dbe4d50e64c7e3bcc06781da6605e3e1d6c39279dc3eb4e29d109e1f 80,864 95d991ba4850eb9ffda52e8fd36d3bc52f3ad30f9c069a63e1b9c0d582a561bd 80,864 ecb39a7ff9fdf39a3aa8afe93b85e8a6ec468ad01b2f918044bc155bfb0ad1ec 80,864
00334c9ad167f0d88b4c0ab0b2a0993dcf32d8155e727d762e95feea344348f3 52,248 00d52bfe3aca7f92117bc63beb4acd6dc67259ec4d3b750b0a608f01e52b5f92 56,344 5ec23745f8074d5bf439e263b90346cac2da72fe9085d9a5cfa770d7643667ec 56,344
0037eb8dbc2346d440d3965ca08407138c6fb1ff3847bd2d7f2075bb9c270200 33,120 d5b984adb14a6f932b9830ada5cd1bd31f2cc4017c2a51c782d041dfa5136082 33,120 318ccccb8ec82d7a37f4dbe4a35714c925aa96b713de731e3212c5d64c94c605 33,120
003af4a826f5dd058a36a526360ac5951bbaf1f3ff6f22fa7b667ae1a7075fdd 32,272 93ca67c0b512bae59ad24f9742979f5712a282d1def900c19b8f01073efb2beb 32,272 e1fd0b29856632f7fe6976dceeac2719aecb3e0dfaa67a68c47c9a067ae04f8b 32,272
003eb158515446fb22a124c736316f4f393546a5bd3fe1ac36ef9bc15fd436e2 50,448 8c3261fe4f17ac2b60adf710038b15bcc5443652774e663858baa7c48fae356f 50,448 9800a0156543fad130fe41e4ab976e78b915a954ad8d4f3ef559b90e278b58a5 50,448
0049cb4cc271e2bb27d3274774e93fdac5d099bdd85a6b7cd238b7229bf464ce 87,648 0b99049f64a6b8e203ffce0b1045a6f2ef31f5667ead4f293e7d0a0dd1750ab9 87,648 4ab03cf44c0683e3a7e45ca4d23001d7ffa892f64a9dd73f50ec2ae330e21e88 87,648
004c9a53591cd9e64cf92cdd3ee4dd935d0f49b0861408db676e3b80177313db 78,568 421c33a85f90eb1ae286b87c8adff8d7c8e887aafb4804d27ed580b4977695ff 78,568 ae661507465ac5df09ec52efaf316d9cc135301fadd3db0c3000ff6beef72647 78,568
004d7d552c661e4b39002430ee142708661c6fff127d07c5aebd5fafa939bf2f 31,496 835feb6a1cb9672e2d52c7102bf66ca2e9c9930cb4bb657a9a2a0baac303fd8f 31,496 11f9f702c296922037eab70a012ccdac741055145d9e1336149fc94882b4ed29 31,496
004d99197b38400898289e8d7aa82b2ceaa13a585fbaeb3a83acd4c702f12e56 53,400 f9144f7c6dd1234dc7201e05076320808482b8ea77d0af91dcb58f68bcff0e7c 57,496 4f197e468a6176e8bcfd76360ca3910d913acb0d01ae419cc4c453efe0290dc7 57,496
00519cb539725b4fcf648310ac42300b89d3669391db5f82444ae19f567512ba 34,960 e87518438feda05db399792d9e48e6bfe44a9e86310237069e1ba17aa7b584d5 34,960 f41d0513dee26bba787f5617a88a2b659d9d932b218c32f151608240e91b944c 34,960
00528233c1551bc654f85f286cc05c73423237acf6f17043c64e80cf48e9985d 47,840 f6d1a9f0fc51714480588198f81c9725d154b59c1d8226a16c22fa6e05c2b848 47,840 3d3af879d923fe9562df89e9277f66b810c757c2f64fd1f8504fa025055bdb50 47,840
00528ca6319ea61c20f59a22ff54830594b582e357bb2f625736b9c8cd445afb 24,416 b5ce47ee365eabc7dcb89809f26da1fee85ed063ad93319c008344004374a9f3 24,416 4b5ab6012e0bb01af293fce8f6b13bc200ab8e71be4f7f5fd4f3f33eef105d08 24,416
00549b3cea19c2b6f30f5bfe3d68941225628a0edb8120ae3204779245114f61 43,088 3444d6344dd1a9ee36eec217c8dc2e3f1a585f3f969356778f274feef24574fc 43,088 70f10dff9bdd389f191340818815a09d7fd0d304f2eb60da6fc4735c7fa02962 43,088
0058430091419e6e8fcc9f2c4411e28f1d41ac807aceb7d9c7afb2688f5c02f8 46,520 64862292b8009d62d26e3722cf2a92e300bc16141e6e7057da6874df5624059a 46,520 bd1a0fcc5eed0b0ec1e5743cb62a2f0aeb992bb87cabfdbf2c69c0fc3c88faaa 46,520
005b357a2861e74c3cd15e399391ee018356c68528ca38689f5ab33c52479cc7 57,232 5d824eccb437c9d2cd83ac3364386cfdd1edfcea6e3e6239cb0d64ec0c6737d3 57,232 821f891824080394be2509c52afb1025c20baba8aa906521d662aa9919c72ed7 57,232
005e8061aff7b41b4bfcbb4e68713de3696587621f11b595975c0996966772a2 38,672 d0eff69499ac6235c4df06471adad7e3e83df2e8549df454fcd2127918bc805c 38,672 1c406ff237c58e39584e4bb4b19f4ee5312df4c158eba1af38e7f1f3e5cb2383 38,672
006366562912ccfb7158205952dc05fd92a3754313d8fc39f617481472b7db8b 21,256 0f2eec78fe10341dcd11d585ba5373e51fa6fc3afd161ab9adc13849824e6a50 21,256 dd645a13bd4567d301ec9dee1f1c39ffa8f2fa198061aaf7c094c8c65c1a54c2 21,256
0066135a317e3a50ec2dae2fd84b7750039db8de9d48cb9a4b1b0f934763343d 23,592 7317a7a171dc8dc88181feec1d6b475ec1b548a74425de9a3176d07cce55901d 23,592 2b849385f5ea564056f3a7c2657ae4d808846b33b42fad7108db97a0f9ea64a6 23,592
006c330d51f2de44c9899f3586934349fc9ed3d0786b065d9f1b0a2c8d9f61c5 39,104 a4a54b2115e6d02c64d293a0ac88df91c5485feacbc1d36f38f6848910eac987 39,104 8374619efe557eaa072911b21c9d43a1f74f9df4e98ada20a358a9482ab2c512 39,104
006e86e9f8037cbff5cbdc35f17a4b1fa747e582d5cc0096e2ce8d754b2438f1 81,008 8d990cf6093677bc779f4d54d4e4143092bd4c8c9fe391b24563525c49c0dbf5 81,008 1d08da94c19e3e1280e6ab3b043d89e3dc4c5a6f21d7520d18d043e68be45a93 81,008
0073eabbd583468bc0d6aa956726e3ceceb832e308f8929b3fd15845e70376aa 20,392 f31804c899c41d19e92ad82f6bf832e9ea13c3be729e9db5a0a3d7024ed6f5f5 20,392 ae05def447bc28d9303a770e96df5f2c325b11ddd47fa9082ef536d6e4491fe5 20,392
007bfa91e21a656ec1baf6729285314a7fbbb821c6f2e40dee68563fbc9156df 26,424 d3b6342e7cc1bb1b8c1fc616d97d079c999263d755b5285c020669387f8fa9a7 26,424 b36514427b78e4f29f2705299a83aaa03e00dd4ab9ffe7f268dda9153cde31fb 26,424
007c57c82ebe75d091756452aeca15149fb39d62783ec811fb99d69abd1f52a5 109,208 4cc8d3b6e3940877a200649f9a4b7ef0a477493e9728800f9e9bcc36327c77dd 109,208 7bc315fa0ec1fe789e01ab9da8f9db88292c8c507b7a21c6d6a879cf11a02593 109,208
0081ba983071eec61da01f54b9d3080374a96eea2f133be209a15e800fd69854 24,800 d9e148d04c50a91c6fd517eb0ae6714e0f20e9ced22dad100ef205b011cdb1f9 24,800 0292f0d6577662a1389c52e804aee44aeaf9c0140bc1da617a7bd38c74e78e5e 24,800
008290dea3b13f49d47daa0313c8a37d5d7cfa8c6962732a59d79f3888e7798c 66,592 7c47322e335d96beb54ab97f9185f843cfa5988c109f03bc1fb05e4706feb761 70,688 ab9399a1eeed0aaec63626c6c5d82e52176b4302a934810a4c928f4266539a10 70,688
008697cca846de12da8c4114eb40895c8e96a9afa353169af888fd1798df8f35 48,456 a77759f4b7d8e024802cd461faee39a742c783423621e9e59fa04dcf5cf500dd 52,552 cd9bbbbfd62608d81296db9bc6c768082e07b07e0f8804fec576c6c10752a17b 52,552
008ea36ec9864509e2bd5693398697c0cac9e15021445cbd886c4b4acc6da845 37,056 44b76dd685d71181c928f07988dca2f4667d757d46f5577b89cc6dbedf45980e 37,056 87df9dc5842978f76c99e1bf1cca7f3d5415390d64958638b89c2b094cb57fcb 37,056
00919f4fc65b8b8f9a6375e5027bd082634af1f60984d3480c9247db7ceab481 51,064 da6180ff9971c945565e89495fe4b4dd7993a76895e318eba513f1af96d05909 51,064 5792aa53fe36735efe442f9c237279cd7f3c98a8995611a350d20b54ff8113d1 51,064
0092c24a6bea98f19072e409ee16a3be52629b73d68ef9a94ee3c9349f524fae 60,104 52d277bc67b4f9add622ba0ab9540295c83497f255031d59be1a929774f2681f 60,104 956812ad6102e9fd0529581b4ebbb301eb33233fb01a7cd2ce858298d74bbbff 60,104
00981952e29f462357043e00c41949772850898a2cab306f8aabf8eef0c80bc6 62,096 8c2d13d0fff71789c552bab60bfaf444742ecfff0d82215959df11a7a36323ef 62,096 ff4a383813a2539d260ef61d966923a53aca74f502e72ebd1b45dae8908e16ac 62,096
009e16e420fdef61e933770321e6c7027fbe8b96f408556abd4b3927f278dd51 24,360 e7c742a9f7e37458744cd7c2f8b981af2f1f3f1b4e171959b5a9c7168f68313b 24,360 3e51449b21a35c05660e09bc4755af79840ca6c0cdb65ea15d0d485a1b61a13a 24,360
00a3efd897dd2a729df28125937ced9807f23586473bac3cff074906f11922ff 175,768 b45d2acfdabe023346461445e15953233c57383b32499973c001a0cc245a5d5e 179,864 abb6b81f862d84c20f966d7605609efa9350ad719e6247ad082978f17d2ac05f 179,864
00a7177b088710633d96d6f2f0f49bd3036fa5fad23225c16336ca5f1250e667 1,547,672 7df27f1f62d96ee446f2c604781ec84050e0a11059e598bbd5b1ce0f3ae67d03 1,605,016 0724fc7d7b5f41352b084131c8ddc1298660d8d0af153b5c0db97d6b5beb20e5 1,605,016
00aa981a798b50a30dceff887ea76febc00d209bce0700150e311150c4d5fb06 52,960 58f0f81aa7b7a9f0c1bfc7beb6b3c3d618981e01d5d2b63cc87dfed267ffeadb 52,960 c43a5531fbf9acd09b614d005f23c18fcd452d798983eb9447730ae5f0f7068a 52,960
00b4dcffd3d30773c2c726604496e3a889e623ce440e754f42f65046fc5626d7 154,016 e7c342841400917eff1f123a3b328f65560b794fcd81005c2718c51f42450c60 162,208 450e6ed114942bc0ebfadb46342211fb9d8373edfe7c4fa2ef88a5526a4f3c83 162,208
00b85452412e4c447549eab52ee2778829fef62ef6ed473de99fe52ec65b73e6 25,520 cfbd304243d4d393920dc10573b9d4fd19d562df740b1c859354308b26fd0eed 25,520 090fffc0ba3cb745c698fc4d175580f09d7176d07a9f6190541ca34d179121dc 25,520
00c0fd53943cf4502b5cfdc7034ba9c7e16557e85d492b18b58d01263780d478 59,296 d9b8ea147083039fe4efde2ba94b95d9008850e702c5b4642ac9a5b9034e3aa5 59,296 c99740486698af1f6695847f3f86d92955d006959dd33ba13901a84ab8e41a4b 59,296
00c84bb1359bb7c0d8ab25f853593e5fab878b845aa720054106a3769f909f88 24,936 cc6c6b142a8e12e9c0061519958cd36f8ab0ba4f58b246c949c05ae6257d2821 24,936 3baa70cdc78442c52436296d5fe4ad52a8feb2b1551117cbd07a33b779a5800c 24,936
00cae77e6ece1bb2c7f27fc249359c5e7ddda08ba436aacb22d9cb1de7f5833b 58,376 6510cdf340f854c94f836d6bcaee0a4774109ca3e4875f8e06babe59385a3735 58,376 0b8c1fd3944a1f5928902e2a71acb8dab21761a8e572da32510f6c4f01751ec7 58,376
00cc3205c52fa0070c35972cbc609a90e4a3de269b9ae29b09b6807ec9851ca9 84,352 cdeeb7db6ea2bb96e7d58dc83e73f44672b76e6c9559ee99199df81b3fc06e5d 84,352 c7c106a591df822b66ad0f9ab0da168a1a1fc877013e511ddacbe8c69ddf1c8d 84,352

Showing the first 50 of 20128 changes.

Compared PR head 625f1a2c9278818e37c61c1ba254cac004b69df5 using rocjitsu-test-corpus run 38427759616.

@kuhar
kuhar merged commit 73d0efc into develop Oct 13, 2026
122 of 131 checks passed
@kuhar
kuhar deleted the revert-13141-users/kuhar/gfx125x-wavefront-size-bit branch October 13, 2026 16:57
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

ScottTodd pushed a commit that referenced this pull request Oct 14, 2026
…x" [bkc 20261013] (#13481)

Cherry-picks:

  - #13366

Cherry-pick of the revert of #13141 (merged to `develop` as
73d0efc) into
`release/bkc/therock-10.2-20261013` for BKC MI455 26.13.

#13141 broke gfx1250 A0 environments (B0→A0 translation clears
`ENABLE_WAVEFRONT_SIZE32` in the kernel descriptor). This blocks BKC
MI455 26.13. Snap build #301 does not include the fix.

Jira: [ROCM-32640](https://amd-hub.atlassian.net/browse/ROCM-32640)

The cherry-pick applies cleanly. Both affected files on the release
branch are identical to the revert's parent commit, so the diff is the
same as #13366.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

[ROCM-32640]:
https://amd-hub.atlassian.net/browse/ROCM-32640?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: Jakub Kuderski <jakub@nod-labs.com>
@chinmaydd

Copy link
Copy Markdown
Contributor

@kuhar do we know why it broke things for 1250-strict environments ? Thanks.

@kuhar

kuhar commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

strict shouldn't use hotswap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants