Repository navigation
feat(rocr,clr): Add gfx1170, gfx1171 target support - #11977
Merged
Merged
Conversation
agunashe
requested review from
a team,
atgutier,
cfreeamd,
dayatsin-amd,
kentrussell,
shwetagkhatri and
xiaogang-chen-amd
as code owners
September 21, 2026 20:56
github-actions
Bot
added
documentation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
4 tasks
agunashe
changed the title
agunashe
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new PAL references use undeclared AsicRevision values, and the exported HSA ELF header is not synchronized with the new IDs.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Adds gfx1170/gfx1171 ISA 11.7 support across ROCr, CLR, HSAIL, HIP, PAL, blit kernels, and generic-target fallback handling.
Changes:
- Adds ELF/ISA identifiers and generic mappings.
- Adds gfx117x blit, addrlib, test, and KFD filter support.
- Adds CLR PAL device registration and OCP FP8 support.
| File | Description |
|---|---|
shared/kpack/docs/multi_arch_packaging_with_kpack.md |
Documents gfx117 generic fallback. |
shared/amdgpu-windows-interop/sc/HSAIL/include/amd_hsa_elf.h |
Adds Windows ELF IDs. |
shared/amdgpu-windows-interop/sc/HSAIL/ext/loader/loaders.hpp |
Declares new ISA handles. |
shared/amdgpu-windows-interop/sc/HSAIL/ext/loader/loaders.cpp |
Initializes and maps handles. |
shared/amdgpu-windows-interop/sc/HSAIL/ext/libamdhsacode/amd_hsa_code.cpp |
Decodes new machine types. |
shared/amdgpu-windows-interop/pal/inc/core/palPipelineAbi.h |
Adds machine-type enums. |
projects/rocr-runtime/runtime/hsa-runtime/libamdhsacode/amd_hsa_code.cpp |
Adds ROCr machine decoding. |
projects/rocr-runtime/runtime/hsa-runtime/inc/amd_hsa_elf.h |
Adds ROCr ELF IDs. |
projects/rocr-runtime/runtime/hsa-runtime/image/blit_src/CMakeLists.txt |
Builds gfx117 blit kernels. |
projects/rocr-runtime/runtime/hsa-runtime/image/blit_kernel.cpp |
Selects gfx117 blit objects. |
projects/rocr-runtime/runtime/hsa-runtime/image/addrlib/src/gfx11/gfx11addrlib.cpp |
Handles gfx117 tiling. |
projects/rocr-runtime/runtime/hsa-runtime/image/addrlib/src/core/addrlib.cpp |
Routes gfx117 to gfx11 addrlib. |
projects/rocr-runtime/runtime/hsa-runtime/image/addrlib/src/amdgpu_asic_addr.h |
Defines gfx117 family ID. |
projects/rocr-runtime/runtime/hsa-runtime/core/runtime/isa.cpp |
Registers gfx117 ISAs. |
projects/rocr-runtime/rocrtst/suites/test_common/CMakeLists.txt |
Adds gfx117 test targets. |
projects/rocr-runtime/libhsakmt/tests/kfdtest/scripts/kfdtest.exclude |
Adds gfx117 filters. |
projects/hip-tests/samples/0_Intro/generic_target/saxpy.cpp |
Documents the new generic target. |
projects/hip-tests/catch/unit/module/CMakeLists.txt |
Tests gfx117 generic compilation. |
projects/hip-tests/catch/unit/compiler/CMakeLists.txt |
Tests gfx117 generic compilation. |
projects/hip-tests/catch/hipTestMain/hip_test_features.cc |
Maps gfx117 to its generic target. |
projects/clr/rocclr/device/pal/palsettings.cpp |
Applies gfx117 PAL settings. |
projects/clr/rocclr/device/pal/paldevice.cpp |
Registers gfx117 PAL devices. |
projects/clr/rocclr/device/device.cpp |
Registers gfx117 ISA metadata. |
projects/clr/hipamd/src/hip_fatbin.cpp |
Adds fatbin generic fallback. |
projects/clr/hipamd/src/hip_comgr_helper.cpp |
Adds Comgr generic mapping. |
projects/clr/hipamd/include/hip/amd_detail/amd_hip_fp8.h |
Enables OCP FP8 for gfx117. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mangupta
reviewed
Sep 24, 2026
dayatsin-amd
approved these changes
Sep 24, 2026
agunashe
force-pushed
the
users/agunashe/gfx117X
branch
from
September 28, 2026 22:38
6c10deb to
1621456
Compare
agunashe
force-pushed
the
users/agunashe/gfx117X
branch
from
October 1, 2026 15:41
1621456 to
c952146
Compare
TomSang
self-requested a review
October 1, 2026 16:25
TomSang
approved these changes
Oct 1, 2026
litvaOo
force-pushed
the
users/agunashe/gfx117X
branch
from
October 5, 2026 08:49
a6fe0a2 to
3c189f0
Compare
Contributor
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
Contributor
Author
|
@kentrussell , @xiaogang-chen-amd - can you please review and approve this PR please. |
kentrussell
reviewed
Oct 5, 2026
Recognize FAMILY_MDS (gfx1170, gfx1171) and initialize it with the gfx11 address library. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Josic, Slobodan <Slobodan.Josic@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Add the gfx11-7-generic ISA/ELF target and retarget fatbin and comgr fallbacks for gfx1170/gfx1171. Co-authored-by: Cursor <cursoragent@cursor.com>
Rename FAMILY_MDS to FAMILY_GFX1170 (0x9A) to match open-source Mesa addrlib, and enable gfx1170/gfx1171. Co-authored-by: Cursor <cursoragent@cursor.com>
This PR updates the amdgpu-windows-interop directory with the latest changes from the static-libs branch. **PAL Commit:** `1251ecbd` **PAL Static Commit:** `81576c1` Original change was pushed at 2026-10-01 15:25:31 UTC. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR updates the amdgpu-windows-interop directory with the latest changes from the static-libs branch. **PAL Commit:** `b8129e83` **PAL Static Commit:** `b02731c` Original change was pushed at 2026-10-05 08:59:23 UTC. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Danylo Lytovchenko <danylo.lytovchenko@amd.com>
dayatsin-amd
force-pushed
the
users/agunashe/gfx117X
branch
from
October 6, 2026 15:05
e33d28a to
a7292ca
Compare
Contributor
|
Dropped |
Contributor
Author
|
@kentrussell - kfd test is moved to #12795. Can you help review and approve this please |
Contributor
|
🤖 AI-assisted pre-review (for @mangupta) Re-reviewed the updated head ( |
1 task done
Contributor
|
The test failures are unrelated to the contents of the PR, overriding. |
Contributor
TheRock Submodule Bump ActivityNewest first
|
1 task done
anujshuk-amd
pushed a commit
that referenced
this pull request
Oct 12, 2026
Port gfx1170/gfx1171 (ISA 11.7.x) enablement onto develop for ROCr and CLR: ISA/ELF IDs, blit objects, addrlib gfx117x family, OCP FP8, gfx11-7-generic fatbin/comgr mapping, and PAL AsicRevision::Gfx1170/Gfx1171 device tables. kfdtest exclude filters for gfx1170/gfx1171/gfx1172 are in #12795. Co-authored-by: Sang, Tao [Tao.Sang@amd.com](mailto:Tao.Sang@amd.com) Co-authored-by: McRae, Geoffrey [Geoffrey.McRae@amd.com](mailto:Geoffrey.McRae@amd.com) Co-authored-by: Li, Todd tiantuo [Toddtiantuo.Li@amd.com](mailto:Toddtiantuo.Li@amd.com) Co-authored-by: Sokolovic, Stefan [Stefan.Sokolovic2@amd.com](mailto:Stefan.Sokolovic2@amd.com) Co-authored-by: Josic, Slobodan [Slobodan.Josic@amd.com](mailto:Slobodan.Josic@amd.com) Co-authored-by: jungx098 [jungx098@gmail.com](mailto:jungx098@gmail.com) ## Technical Details Enables gfx1170/gfx1171 support on rocm-systems/Rock ## Issue Tracking JIRA ID : AIRUNTIME-2024 JIRA ID : ROCM-29293 ## Test Plan - [x] Confirm rocminfo reports gfx1170/gfx1171 when present - [x] Build blit kernels for gfx1170/gfx1171 - [x] HIP fatbin fallback to gfx11-7-generic - [ ] kfdtest exclude filters: covered by #12795 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Co-authored-by: Sang, Tao <Tao.Sang@amd.com> Co-authored-by: jungx098 <jungx098@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Li, Todd tiantuo <Toddtiantuo.Li@amd.com> Co-authored-by: Sokolovic, Stefan <Stefan.Sokolovic2@amd.com> Co-authored-by: Josic, Slobodan <Slobodan.Josic@amd.com> Co-authored-by: David Yat Sin <David.YatSin@amd.com> Co-authored-by: systems-assistant[bot] <221163467+systems-assistant[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Danylo Lytovchenko <danylo.lytovchenko@amd.com>
1 task done
arvindcheru
pushed a commit
that referenced
this pull request
Oct 15, 2026
## Motivation `run_kfdtest.sh` fails on Medusa (gfx117x) systems with "Unsupported platform gfx1170. Exiting". The script looks up the detected ASIC in `kfdtest.exclude`, which has no `FILTER[gfx1170]` or `FILTER[gfx1171]` entry. As a result, kfdtest cannot be run through the script on these ASICs, which blocks automated KFD testing. ## Technical Details Adds `FILTER[gfx1170]` and `FILTER[gfx1171]` to `projects/rocr-runtime/libhsakmt/tests/kfdtest/scripts/kfdtest.exclude`, placed after the gfx1153 entry. Each entry uses the same blacklist as the other gfx11 entries (`$BLACKLIST_ALL_ASICS` and `$BLACKLIST_GFX11`). This matches the entries already present in the internal `amd-npi` branch. The target registration for gfx1170/gfx1171 is in #11977. gfx1172 will be handled separately. ## Issue Tracking JIRA ID: ROCM-31373 ## Test Plan On a Medusa gfx1170 system (ROCm 10.2.0, Ubuntu 26.04), run `run_kfdtest.sh` from `/opt/rocm-10.2.0/bin` with this `kfdtest.exclude` supplied through `KFDTEST_SHARE_DIR`. Nothing under `/opt/rocm-10.2.0` was modified. Before the change, the same command exits with "Unsupported platform gfx1170. Exiting". ## Test Result `run_kfdtest.sh` detects node 1 (gfx1170) and runs the full suite: - 180 tests from 19 test cases ran, 180 passed, 4 disabled - `kfdtest` return code 0 Only gfx1170 was run, since that is the available hardware. The gfx1171 entry uses the same filter as gfx1170 but was not run on hardware. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port gfx1170/gfx1171 (ISA 11.7.x) enablement onto develop for ROCr and CLR: ISA/ELF IDs, blit objects, addrlib gfx117x family, OCP FP8, gfx11-7-generic fatbin/comgr mapping, and PAL AsicRevision::Gfx1170/Gfx1171 device tables.
kfdtest exclude filters for gfx1170/gfx1171/gfx1172 are in #12795.
Co-authored-by: Sang, Tao Tao.Sang@amd.com
Co-authored-by: McRae, Geoffrey Geoffrey.McRae@amd.com
Co-authored-by: Li, Todd tiantuo Toddtiantuo.Li@amd.com
Co-authored-by: Sokolovic, Stefan Stefan.Sokolovic2@amd.com
Co-authored-by: Josic, Slobodan Slobodan.Josic@amd.com
Co-authored-by: jungx098 jungx098@gmail.com
Technical Details
Enables gfx1170/gfx1171 support on rocm-systems/Rock
Issue Tracking
JIRA ID : AIRUNTIME-2024
JIRA ID : ROCM-29293
Test Plan
Submission Checklist