Skip to content

fix(kfdtest): add gfx1170 and gfx1171 platform filters - #13541

Closed
dayatsin-amd wants to merge 1 commit into
developfrom
users/dayatsin/gfx1170-kfdtest-filter
Closed

dayatsin-amd wants to merge 1 commit into
developfrom
users/dayatsin/gfx1170-kfdtest-filter

Conversation

@dayatsin-amd

Copy link
Copy Markdown
Contributor

Repost of #12795 from an origin branch. CI on that pull request failed because the head is on a fork.

Motivation

run_kfdtest.sh fails on Medusa (gfx117x) systems with "Unsupported platform gfx1170. Exiting". The script looks up the detected ASIC in kfdtest.exclude, which has no FILTER[gfx1170] or FILTER[gfx1171] entry. As a result, kfdtest cannot be run through the script on these ASICs, which blocks automated KFD testing.

Technical Details

Adds FILTER[gfx1170] and FILTER[gfx1171] to projects/rocr-runtime/libhsakmt/tests/kfdtest/scripts/kfdtest.exclude, placed after the gfx1153 entry.

Each entry uses the same blacklist as the other gfx11 entries ($BLACKLIST_ALL_ASICS and $BLACKLIST_GFX11). This matches the entries already present in the internal amd-npi branch.

The target registration for gfx1170/gfx1171 is in #11977. gfx1172 will be handled separately.

Issue Tracking

JIRA ID : ROCM-31373

Test Plan

On a Medusa gfx1170 system (ROCm 10.2.0, Ubuntu 26.04), run run_kfdtest.sh from /opt/rocm-10.2.0/bin with this kfdtest.exclude supplied through KFDTEST_SHARE_DIR. Nothing under /opt/rocm-10.2.0 was modified.

Before the change, the same command exits with "Unsupported platform gfx1170. Exiting".

Test Result

run_kfdtest.sh detects node 1 (gfx1170) and runs the full suite:

  • 180 tests from 19 test cases ran, 180 passed, 4 disabled
  • kfdtest return code 0

Only gfx1170 was run, since that is the available hardware. The gfx1171 entry uses the same filter as gfx1170 but was not run on hardware.

Submission Checklist

Made with Cursor

@therock-pr-bot

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@dayatsin-amd

Copy link
Copy Markdown
Contributor Author

This is a duplicate of #12795. Some CI's on 12795 are failing because it is based on a forked repo.

@cfreeamd cfreeamd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI-assisted pre-review (for @cfreeamd)

kfdtest.exclude looks correct — FILTER[gfx1170] and FILTER[gfx1171] follow the same $BLACKLIST_ALL_ASICS:$BLACKLIST_GFX11 pattern as gfx1153 and other GFX11 entries.

@dayatsin-amd
dayatsin-amd deleted the users/dayatsin/gfx1170-kfdtest-filter branch October 15, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants