Repository navigation
Conversation
lookup_bundle('gfx1170') raised ValueError because the target table had
no GFX11.7 entries, breaking rocm-kpack fat-wheel splitting for any
build that includes gfx117X.
Declares the two targets and a gfx117x sub-family; target-level bundle
keys are then generated by _build_target_bundle_map. The sub-family
carries llvm_generic="gfx11-7-generic", which LLVM exposes separately
from gfx11-generic.
AIPYTORCH-1538
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the gfx1170/gfx1171 target-registry additions.
No open issues 🎉
What changed in this PR
Adds gfx1170/gfx1171 support to rocm-bootstrap’s target registry, resolving missing bundle lookups that block Windows fat-wheel splitting in rocm-kpack.
Changes:
- Registers both targets, the
gfx117xsub-family, and thegfx11_7alias. - Assigns
gfx11-7-genericto the new sub-family while retaining the existing family generic and clarifying its coverage comment. - Extends tests for target counts, architecture fields, XNACK support, aliases, packaging hierarchy, and generic mapping.
| File | Description |
|---|---|
python/rocm-bootstrap/python/rocm_bootstrap/tests/test_targets.py |
Extends registry and lookup tests for GFX11.7 targets. |
python/rocm-bootstrap/python/rocm_bootstrap/targets.py |
Adds GFX11.7 targets, bundles, family membership, and alias registration. |
Review effort: Balanced
PR Pundit review(Testing PR Pundit Code Review agent. Not all comments may be relevant. This is a one-time automated pass: please address what is useful, no need to request a re-review. Please reply to each point, whether it applies or not: we harvest these replies, and both kinds are enormously helpful for tuning the agent. Reach out to @peymanr for suggestions.)
1. 🟠 Should fix: Verbose detect on gfx1170/1171 reports family generic
|
Motivation
Problem
rocm-bootstrapdoes not recognize gfx1170/gfx1171, sorocm-kpackfailswhile splitting otherwise valid PyTorch wheels with
Unknown bundle key.ROCm/rockrel run 39549503111
reproduced this after all 16 Windows PyTorch wheels compiled successfully.
Technical Details
Changes
gfx117xsub-family.gfx11_7alias and GFX11 family membership.gfx11-7-genericto gfx117x.gfx11-genericfrom the GFX11 family to gfx110x/gfx115x.Scope excludes gfx1172 because TheRock currently defines gfx1170/gfx1171.
Issue Tracking
Linux has a separate Composable Kernel build dependency handled by the linked
PyTorch release backports. This PR fixes the common bundle registry and splitter.
Test Plan
Validation
rocm-bootstrapsuite: 734 passed.black,mdformat, whitespace, merge-conflict, and line-ending checks passed.Test Result
The original unknown-bundle failure is fixed. GFX11.7 uses
gfx11-7-generic; gfx110x/gfx115x retaingfx11-genericsafely.Submission Checklist