Skip to content

feat(ci): bump TheRock ref to d528760 (2026-08-18) - #10349

Merged
geomin12 merged 1 commit into
developfrom
users/geomin12/bump-hash-d528760
Aug 19, 2026
Merged

geomin12 merged 1 commit into
developfrom
users/geomin12/bump-hash-d528760

Conversation

@geomin12

Copy link
Copy Markdown
Contributor

bump TheRock ref to d528760 (2026-08-18)

Update TheRock checkout ref from 2026-08-17 to 2026-08-18.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12
geomin12 requested a review from a team as a code owner August 18, 2026 20:26
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 18, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@JeniferC99 JeniferC99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but looks like it's superseded by #10317.

I feel like there's a reason why, but is there a reason why not use @main instead?

@geomin12

Copy link
Copy Markdown
Contributor Author

lgtm, but looks like it's superseded by #10317.

I feel like there's a reason why, but is there a reason why not use @main instead?

i'm going to land this as this includes those commits! we don't use main, because if a break was introduced, it would impact ALL of ROCm development. it's safer to pin to a hash

@geomin12
geomin12 merged commit f8f125e into develop Aug 19, 2026
80 of 96 checks passed
@geomin12
geomin12 deleted the users/geomin12/bump-hash-d528760 branch August 19, 2026 03:07
cmcknigh pushed a commit that referenced this pull request Aug 25, 2026
bump TheRock ref to `d528760` (2026-08-18)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants