Skip to content

Fix typos in VirtualWaveSize warning #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanleytsang-amd merged 1 commit into from
Aug 11, 2025
Merged

Fix typos in VirtualWaveSize warning #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/rocprim/rocprim/include/rocprim/block/block_exchange.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ class block_exchange
{
static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down
8 changes: 4 additions & 4 deletions projects/rocprim/rocprim/include/rocprim/block/block_load_func.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ void block_load_direct_warp_striped(unsigned int flat_id,
{
static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down Expand Up @@ -469,7 +469,7 @@ void block_load_direct_warp_striped(unsigned int flat_id,
{
static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down Expand Up @@ -582,7 +582,7 @@ void block_load_direct_warp_striped(unsigned int flat_id,
{
static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down Expand Up @@ -695,7 +695,7 @@ auto block_load_direct_blocked_cast(unsigned int flat_id,
{
static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down
4 changes: 2 additions & 2 deletions projects/rocprim/rocprim/include/rocprim/block/block_store_func.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ void block_store_direct_warp_striped(unsigned int flat_id,

static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
unsigned int thread_id = detail::logical_lane_id<VirtualWaveSize>();
unsigned int warp_id = flat_id / VirtualWaveSize;
Expand Down Expand Up @@ -402,7 +402,7 @@ void block_store_direct_warp_striped(unsigned int flat_id,

static_assert(detail::is_power_of_two(VirtualWaveSize)
&& VirtualWaveSize <= arch::wavefront::max_size(),
"VirtualWaveSize must be a power of two and equal or less"
"VirtualWaveSize must be a power of two and equal or less "
"than the size of hardware warp.");
assert(VirtualWaveSize <= arch::wavefront::size());

Expand Down
Loading