Repository navigation
feat(rocthrust): CCCL 3.0.x changes - #3773
Conversation
5133c96 to
44d7902
Compare
|
Can confirm that the We'll need to file a big with the compiler team about this, but for now we can waive this failure for approval purposes. |
I built everything with However we were able to reproduce the error with rocm 7.2-rel. Probably an compiler regression? What compiler version are you using? |
This sounds very familiar. We have ticket for this. |
44d7902 to
998118a
Compare
|
@yungshengtu The latest commits have resulted in a build failure: [ 95%] Building HIP object test/public_headers_host_only/CMakeFiles/headertest_std_cuda_bit.dir/headers/cuda_bit.cpp.o |
|
@stanleytsang-amd This error might be related to ROCm/rocm-systems#2240. Does the image that Jenkins CI is building on also include this change to CLR? |
Sorry for the delay - it does not seem to be part of the ROCm build used in math-ci (7.2 RC2). I will try RC3 or 7.2.1 |
11629e4 to
c1d1094
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3773 +/- ##
============================================
+ Coverage 69.59% 91.60% +22.01%
============================================
Files 2771 469 -2302
Lines 452699 40018 -412681
Branches 66658 5085 -61573
============================================
- Hits 315022 36655 -278367
+ Misses 117337 3034 -114303
+ Partials 20340 329 -20011
🚀 New features to boost your workflow:
|
63afda6 to
2f148ff
Compare
|
@yungshengtu When installing this rocThrust either via make install or via package, the __cccl_config file appears to be omitted from the install. |
2f148ff to
e26f228
Compare
@stanleytsang-amd Sorry about that. I missed it. |
e26f228 to
b9de8c7
Compare
0b7d7a2 to
d95e575
Compare
8429739 to
b5e0a8c
Compare
Temporarily skip these tests, which are running out of memory. We can re-enable them once we have a robust solution.
05926d1 to
2eb1f88
Compare
feat(rocthrust): CCCL 3.0.x changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Most of the changes here are pulling in the commits from [CCCL 3.0.3](https://github.com/NVIDIA/cccl/tree/v3.0.3). With the fixes and workarounds attached to these commits. In addition, this PR also includes: - upgrading the versions of dependencies - moving all libcxx wrapper codes into thrust/detail/libcxx_wrapper - C++20 onwards support - fixing the errors from thrust/unique_ptr.h - fixing the errors from test/generate_resource_spec.cpp JIRA ID : EXSWSTRHPC-300
(cherry picked from commit 607b365a6a408a6a72fd1a0753f33796e475a50e)
Most of the changes here are pulling in the commits from [CCCL 3.0.3](https://github.com/NVIDIA/cccl/tree/v3.0.3). With the fixes and workarounds attached to these commits. In addition, this PR also includes: - upgrading the versions of dependencies - moving all libcxx wrapper codes into thrust/detail/libcxx_wrapper - C++20 onwards support - fixing the errors from thrust/unique_ptr.h - fixing the errors from test/generate_resource_spec.cpp JIRA ID : EXSWSTRHPC-300 --------- Co-authored-by: Nara Prasetya <nara@streamhpc.com> Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
Most of the changes here are pulling in the commits from [CCCL 3.0.3](https://github.com/NVIDIA/cccl/tree/v3.0.3). With the fixes and workarounds attached to these commits. In addition, this PR also includes: - upgrading the versions of dependencies - moving all libcxx wrapper codes into thrust/detail/libcxx_wrapper - C++20 onwards support - fixing the errors from thrust/unique_ptr.h - fixing the errors from test/generate_resource_spec.cpp JIRA ID : EXSWSTRHPC-300 --------- Co-authored-by: Nara Prasetya <nara@streamhpc.com> Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: Wayne Franz <wayfranz@amd.com>
Most of the changes here are pulling in the commits from CCCL 3.0.3.
With the fixes and workarounds attached to these commits.
In addition, this PR also includes:
JIRA ID : EXSWSTRHPC-300