Skip to content

Revert "feat(rocthrust): CCCL 3.0.x changes" - #10001

Closed
TriveniTadapaneni wants to merge 1 commit into
developfrom
revert-3773-users/yungshengtu/rocthrust-cccl-3-0-x-changes
Closed

TriveniTadapaneni wants to merge 1 commit into
developfrom
revert-3773-users/yungshengtu/rocthrust-cccl-3-0-x-changes

Conversation

@TriveniTadapaneni

Copy link
Copy Markdown
Contributor

Reverts #3773

@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass —
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov

codecov Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.19899% with 135 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocthrust/test/test_async_scan.cpp 0.00% 105 Missing ⚠️
projects/rocthrust/test/test_scan.cpp 0.00% 13 Missing ⚠️
projects/rocthrust/test/test_async_reduce.cpp 99.11% 3 Missing and 1 partial ⚠️
projects/rocthrust/test/test_future.cpp 96.30% 0 Missing and 4 partials ⚠️
projects/rocthrust/test/test_event.cpp 97.78% 0 Missing and 2 partials ⚠️
projects/rocthrust/test/test_remove.cpp 91.30% 0 Missing and 2 partials ⚠️
projects/rocthrust/test/test_async_reduce_into.cpp 99.35% 0 Missing and 1 partial ⚠️
projects/rocthrust/test/test_async_transform.cpp 99.57% 0 Missing and 1 partial ⚠️
projects/rocthrust/test/test_device_delete.cpp 0.00% 1 Missing ⚠️
projects/rocthrust/test/test_memory.cpp 97.83% 0 Missing and 1 partial ⚠️
... and 1 more

❌ Your project check has failed because the head coverage (76.92%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10001      +/-   ##
===========================================
+ Coverage    69.55%   69.63%   +0.07%     
===========================================
  Files         2739     2770      +31     
  Lines       450640   452635    +1995     
  Branches     66350    66671     +321     
===========================================
+ Hits        313430   315149    +1719     
- Misses      117008   117247     +239     
- Partials     20202    20239      +37     
Flag Coverage Δ *Carryforward flag
TensileLite 34.33% <ø> (ø) Carriedforward from b41371a
TensileLite-CPP 38.06% <ø> (ø) Carriedforward from b41371a
TensileLite-Unit 64.65% <ø> (ø) Carriedforward from b41371a
hipBLAS 90.62% <ø> (ø) Carriedforward from b41371a
hipBLASLt 34.63% <ø> (ø) Carriedforward from b41371a
hipCUB 83.47% <ø> (ø) Carriedforward from b41371a
hipDNN 86.35% <ø> (ø) Carriedforward from b41371a
hipFFT 47.34% <ø> (ø) Carriedforward from b41371a
hipRAND 76.12% <ø> (ø) Carriedforward from b41371a
hipSOLVER 69.18% <ø> (ø) Carriedforward from b41371a
hipSPARSE 86.27% <ø> (ø) Carriedforward from b41371a
rocBLAS 47.95% <ø> (ø) Carriedforward from b41371a
rocFFT 47.61% <ø> (ø) Carriedforward from b41371a
rocRAND 57.01% <ø> (ø) Carriedforward from b41371a
rocSOLVER 76.92% <ø> (ø) Carriedforward from b41371a
rocSPARSE 72.59% <ø> (ø) Carriedforward from b41371a
rocThrust 91.34% <93.20%> (-0.26%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/rocthrust/test/test_address_stability.cpp 94.59% <100.00%> (ø)
projects/rocthrust/test/test_allocator.cpp 94.64% <100.00%> (ø)
...s/rocthrust/test/test_allocator_aware_policies.cpp 100.00% <100.00%> (ø)
projects/rocthrust/test/test_async_copy.cpp 100.00% <100.00%> (ø)
projects/rocthrust/test/test_async_for_each.cpp 100.00% <100.00%> (ø)
projects/rocthrust/test/test_async_sort.cpp 100.00% <100.00%> (ø)
projects/rocthrust/test/test_binary_search.cpp 99.41% <100.00%> (ø)
projects/rocthrust/test/test_complex.cpp 98.45% <100.00%> (ø)
projects/rocthrust/test/test_constant_iterator.cpp 100.00% <100.00%> (ø)
projects/rocthrust/test/test_copy.cpp 96.85% <ø> (ø)
... and 86 more

... and 251 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@umfranzw

Copy link
Copy Markdown
Contributor

Note: ROCm/TheRock#6890 has been created to remove PyTorch 2.10 from TheRock build matrices. Once merged, that should eliminate the need to revert the CCCL 3.0 changes.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Aug 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants