Repository navigation
[rocThrust] Fix benchmark build on Windows - #5953
Merged
stanleytsang-amd merged 3 commits intoApr 9, 2026
Merged
stanleytsang-amd merged 3 commits into
stanleytsang-amd merged 3 commits into
Conversation
stanleytsang-amd
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.72%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5953 +/- ##
===========================================
+ Coverage 67.47% 70.48% +3.02%
===========================================
Files 1873 2373 +500
Lines 290521 332555 +42034
Branches 40990 46309 +5319
===========================================
+ Hits 196001 234395 +38394
- Misses 77706 80982 +3276
- Partials 16814 17178 +364
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
stanleytsang-amd
enabled auto-merge (squash)
April 8, 2026 14:47
stanleytsang-amd
deleted the
users/stanleytsang-amd/fix_rocthrust_benchmark_windows
branch
April 9, 2026 13:33
yungshengtu
added a commit
that referenced
this pull request
Apr 15, 2026
yungshengtu
added a commit
that referenced
this pull request
Apr 30, 2026
yungshengtu
added a commit
that referenced
this pull request
May 15, 2026
yungshengtu
added a commit
that referenced
this pull request
May 20, 2026
yungshengtu
added a commit
that referenced
this pull request
May 22, 2026
yungshengtu
added a commit
that referenced
this pull request
May 22, 2026
yungshengtu
added a commit
that referenced
this pull request
May 30, 2026
COrruDXC
pushed a commit
to COrruDXC/rocm-libraries
that referenced
this pull request
Jun 4, 2026
## Motivation Currently the rocThrust benchmark fails to build on Windows because googlebench enables `-Werror` and also throws the following warning with clang on Windows: `In file included from build-wasm/_deps/benchmark-src/src/benchmark_register.cc:39: build-wasm/_deps/benchmark-src/include/benchmark/benchmark.h:1461:30: error: '__COUNTER__' is a C2y extension [-Werror,-Wc2y-extensions] 1461 | #if defined(__COUNTER__) && (__COUNTER__ + 1 == __COUNTER__ + 0)` The warning has been suppressed in [googlebench](google/benchmark#2057) and is available in v1.9.5. I have bumped to 1.9.5, however it seems to cause several more, different warnings as error problem. For the time being I will suppress those warnings on Windows only until they are addressed in googlebench in a future relase. ## Technical Details Update googlebench from 1.9.4 to 1.9.5, and suppress two warnings for googlebench. ## Test Plan Rebuilt benchmarks. ## Test Result Build passes. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
yungshengtu
added a commit
that referenced
this pull request
Jun 11, 2026
yungshengtu
added a commit
that referenced
this pull request
Jun 12, 2026
yungshengtu
added a commit
that referenced
this pull request
Jun 12, 2026
yungshengtu
added a commit
that referenced
this pull request
Jun 29, 2026
yungshengtu
added a commit
that referenced
this pull request
Jun 29, 2026
yungshengtu
added a commit
that referenced
this pull request
Jul 3, 2026
stanleytsang-amd
pushed a commit
that referenced
this pull request
Jul 16, 2026
yungshengtu
added a commit
that referenced
this pull request
Jul 17, 2026
yungshengtu
added a commit
that referenced
this pull request
Jul 24, 2026
stanleytsang-amd
added a commit
that referenced
this pull request
Sep 18, 2026
## Motivation Currently the rocThrust benchmark fails to build on Windows because googlebench enables `-Werror` and also throws the following warning with clang on Windows: `In file included from build-wasm/_deps/benchmark-src/src/benchmark_register.cc:39: build-wasm/_deps/benchmark-src/include/benchmark/benchmark.h:1461:30: error: '__COUNTER__' is a C2y extension [-Werror,-Wc2y-extensions] 1461 | #if defined(__COUNTER__) && (__COUNTER__ + 1 == __COUNTER__ + 0)` The warning has been suppressed in [googlebench](google/benchmark#2057) and is available in v1.9.5. I have bumped to 1.9.5, however it seems to cause several more, different warnings as error problem. For the time being I will suppress those warnings on Windows only until they are addressed in googlebench in a future relase. ## Technical Details Update googlebench from 1.9.4 to 1.9.5, and suppress two warnings for googlebench. ## Test Plan Rebuilt benchmarks. ## Test Result Build passes. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
illsilin
pushed a commit
to igorluppi/rocm-libraries
that referenced
this pull request
Oct 1, 2026
## Motivation Currently the rocThrust benchmark fails to build on Windows because googlebench enables `-Werror` and also throws the following warning with clang on Windows: `In file included from build-wasm/_deps/benchmark-src/src/benchmark_register.cc:39: build-wasm/_deps/benchmark-src/include/benchmark/benchmark.h:1461:30: error: '__COUNTER__' is a C2y extension [-Werror,-Wc2y-extensions] 1461 | #if defined(__COUNTER__) && (__COUNTER__ + 1 == __COUNTER__ + 0)` The warning has been suppressed in [googlebench](google/benchmark#2057) and is available in v1.9.5. I have bumped to 1.9.5, however it seems to cause several more, different warnings as error problem. For the time being I will suppress those warnings on Windows only until they are addressed in googlebench in a future relase. ## Technical Details Update googlebench from 1.9.4 to 1.9.5, and suppress two warnings for googlebench. ## Test Plan Rebuilt benchmarks. ## Test Result Build passes. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the rocThrust benchmark fails to build on Windows because googlebench enables
-Werrorand also throws the following warning with clang on Windows:In file included from build-wasm/_deps/benchmark-src/src/benchmark_register.cc:39: build-wasm/_deps/benchmark-src/include/benchmark/benchmark.h:1461:30: error: '__COUNTER__' is a C2y extension [-Werror,-Wc2y-extensions] 1461 | #if defined(__COUNTER__) && (__COUNTER__ + 1 == __COUNTER__ + 0)The warning has been suppressed in googlebench and is available in v1.9.5. I have bumped to 1.9.5, however it seems to cause several more, different warnings as error problem. For the time being I will suppress those warnings on Windows only until they are addressed in googlebench in a future relase.
Technical Details
Update googlebench from 1.9.4 to 1.9.5, and suppress two warnings for googlebench.
Test Plan
Rebuilt benchmarks.
Test Result
Build passes.
Submission Checklist