Revert "[origami] Major refactoring of codebase (#2718)"#3411
Closed
jayhawk-commits wants to merge 1 commit into
Closed
Revert "[origami] Major refactoring of codebase (#2718)"#3411jayhawk-commits wants to merge 1 commit into
jayhawk-commits wants to merge 1 commit into
Conversation
This reverts commit 283f438. Manually resolved merge conflict in `solution_selection.cpp`
marbre
reviewed
Dec 16, 2025
Member
marbre
left a comment
There was a problem hiding this comment.
The verification build (https://github.com/ROCm/TheRock/actions/runs/20260025013) fails building hipBLASLt:
[hipBLASLt] /therock/src/rocm-libraries/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/rocroller/solution_selection.cpp:202:20: error: no member named 'scaleABlockRowSize' in 'KernelType'
[hipBLASLt] 202 | kernelType.scaleABlockRowSize * kernelType.scaleABlockColSize, //Handle A vs B block size.
[hipBLASLt] | ~~~~~~~~~~ ^
[hipBLASLt] /therock/src/rocm-libraries/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/rocroller/solution_selection.cpp:202:52: error: no member named 'scaleABlockColSize' in 'KernelType'
[hipBLASLt] 202 | kernelType.scaleABlockRowSize * kernelType.scaleABlockColSize, //Handle A vs B block size.
[hipBLASLt] | ~~~~~~~~~~ ^
[hipBLASLt] /therock/src/rocm-libraries/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/rocroller/solution_selection.cpp:245:27: error: use of undeclared identifier 'analytical_hardware'; did you mean 'analaytical_hardware'?
[hipBLASLt] 245 | if(numTiles < analytical_hardware.N_CU && !isF6)
[hipBLASLt] | ^~~~~~~~~~~~~~~~~~~
[hipBLASLt] | analaytical_hardware
[hipBLASLt] /therock/src/rocm-libraries/projects/hipblaslt/library/src/amd_detail/rocblaslt/src/rocroller/solution_selection.cpp:185:31: note: 'analaytical_hardware' declared here
[hipBLASLt] 185 | const origami::hardware_t analaytical_hardware = origami::hardware_t::get_hardware_for_device(0);
[hipBLASLt] | ^
[hipBLASLt] 3 errors generated.
Collaborator
Author
Member
Revert all of them. See https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0002-MonoRepo-Gardener-Rotations.md#reverting-vs-fixing-forward
|
Collaborator
Author
|
Replaced by #3416 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was determined that this commit introduces memory corruption issues with TheRock python packaging build. See ROCm/TheRock#2522 and need this commit reverted to move the
rocm-librariessubmodule pointer in TheRock forward.Error
corrupted size vs. prev_size in fastbinsAffected Versions
rocm-librariessubmodule pointed to this commit or newerWays to Reproduce
rocm-sdk test.python ./external-builds/pytorch/run_pytorch_smoke_tests.py.Error happens during steps 2-4. I have not seen an instance of a workflow getting past step 4.
Investigation Test Results A
Investigation Test Results B
Test Results A show
corrupted size vs. prev_size in fastbinsthroughout the different python 3.11-3.13 runs.Test Results B do not show the issue.
Revert Sequence
rocm-libraries.git revert 283f438877a0982f170f76d5441dcca365741aa6projects/hipblaslt/library/src/amd_detail/rocblaslt/src/rocroller/solution_selection.cpp, referring to the diffs in PR [origami] Major refactoring of codebase #2718Verifying This Pull Request
TheRockthat points to this PR's branch as therocm-librariessubmodule. See https://github.com/ROCm/TheRock/tree/users/jayhawk-commits/revert-origami-refactor-testVerification Results