[origami] Major refactoring of codebase#2718
Conversation
perfci run on commit 5ac1a36 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
perfci run on commit ba05c37 |
perfci run on commit 2d68ed0 |
|
This patch needs to be reverted: ROCm/TheRock#2522 (comment) Crashes the entire product and was clearly not tested. It cost devops a full day and a half to bisect and stalled everyone in the project for a week. The level of detail around a commit of this magnitude is completely unacceptable and I will be calling a post mortem. |
|
It was determined that this commit introduces memory corruption issues with TheRock python packaging build. See ROCm/TheRock#2522 and need this commit reverted to move the Errorcorrupted size vs. prev_size in fastbins Affected Versions
Ways to Reproduce
Error happens during steps 2-4. I have not seen an instance of a workflow getting past step 4. Test Results A
Test Results B
Test Results A show corrupted size vs. prev_size in fastbins throughout the different python 3.11-3.13 runs. |
Technical Details
Rebase @neoblizz (Muhammad) changes (#1859) with latest develop
Refactor
types.hpp, consolidates various origami types.types.hpp; data types (seehardware.hppfor what needs to be moved)latencyout ofconfig_tPython APIs & Unit Tests
Testing Infrastructure
Questions
Motivation