[hipBLASLt] [rocRoller] Create a SolutionCache class to replace nested map data structure#2732
Merged
Merged
Conversation
…nemanich/rocroller_solution_cache
perfci run on commit a97af09 |
jaopaulolc
approved these changes
Dec 4, 2025
Contributor
jaopaulolc
left a comment
jaopaulolc
left a comment
There was a problem hiding this comment.
LGTM overal. More sanity checks around expected/valid values of blockRowSize and blockColSize would be nice.
davidd-amd
approved these changes
Dec 5, 2025
yenong-amd
reviewed
Dec 6, 2025
…nemanich/rocroller_solution_cache
perfci run on commit fa4a9ea |
…nemanich/rocroller_solution_cache
perfci run on commit 4d16a40 |
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
[ROCm/composable_kernel commit: 1d4a334]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR should not change behavior of selected kernel. It is cleaning up implementation by creating a SolutionCache. This way internal cache can change in the future without the rest of the code needing to be changed.
Technical Details
Cache is currently using nested maps. There are now methods for adding a solution to the cache and retrieving a solution.
Solution Cache is using unordered_maps. In order to use unordered_maps, it was necesary to add hash functions for the KernelType class. To make this easier, a ScaleType struct was added as well.
Test Plan
Run current tests, behavior should not change.
Submission Checklist