Handle explicit empty target selection#2678
Merged
Merged
Conversation
cgmillette
approved these changes
Nov 14, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Nov 17, 2025
[rocWMMA] Handle explicit empty target selection ## Motivation Long-term rocWMMA fix for ROCm/TheRock#2136 ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This was referenced Nov 17, 2025
bsyrowik
added a commit
to ROCm/TheRock
that referenced
this pull request
Nov 24, 2025
## Motivation Remove the workaround for when we try to build rocWMMA with an empty target. ## Technical Details As of 2025/11/19 rocWMMA will default to the first compatible target in the case where we explicitly specify an empty GPU_TARGET. See ROCm/rocm-libraries#2678 ## Test Plan Test against gfx103X: https://github.com/ROCm/TheRock/actions/runs/19517010601 <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
bsyrowik
added a commit
that referenced
this pull request
Nov 26, 2025
## Motivation Long-term rocWMMA fix for ROCm/TheRock#2136 ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
rponnuru5
pushed a commit
to ROCm/TheRock
that referenced
this pull request
Dec 9, 2025
## Motivation Remove the workaround for when we try to build rocWMMA with an empty target. ## Technical Details As of 2025/11/19 rocWMMA will default to the first compatible target in the case where we explicitly specify an empty GPU_TARGET. See ROCm/rocm-libraries#2678 ## Test Plan Test against gfx103X: https://github.com/ROCm/TheRock/actions/runs/19517010601 <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Rename vector to ThreadTile * more notes on tile encoding * remove number<> from tuple of make_tile_window * add script to stress test the copy example [ROCm/composable_kernel commit: 8a698c7]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Long-term rocWMMA fix for ROCm/TheRock#2136
Technical Details
Test Plan
Test Result
Submission Checklist