[hipblaslt, rocwmma] Make the empty target default project configurable.#2136
Merged
stellaraccident merged 1 commit intoNov 14, 2025
Merged
Conversation
Neither hipblaslt nor rocwmma can build with an explicitly empty target list (the former because Tensile has issues and the latter because hipcc will silently default to gfx906, which is not supported by rocwmma). There was an existing hack buried in the code to work around hipblaslt. Turns this into a real kwarg to the project declaration and defines it for both.
bsyrowik
approved these changes
Nov 13, 2025
Contributor
bsyrowik
left a comment
bsyrowik
left a comment
There was a problem hiding this comment.
Seems like a reasonable workaround for now. Thanks!
| BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/rocWMMA" | ||
| BACKGROUND_BUILD | ||
| DEFAULT_GPU_TARGETS | ||
| gfx1100 # TODO: Fix rocwmma to accept an empty target list. |
Contributor
There was a problem hiding this comment.
Long term it may make more sense to simply omit rocWMMA for a build where all targets have been filtered out. An empty target list will work now, but will build for 11 targets (possibly none of which were in the original list that was filtered), which will take a long time.
Collaborator
Author
There was a problem hiding this comment.
We can't really support per-architecture changes to the build graph. The correct thing to do (which other projects do) is differentiate between NOT DEFINED and empty when choosing a default target list. Projects should never override an explicitly given config value.
Collaborator
Author
|
Failures are spurious / related to: #2137 |
Collaborator
Author
|
Local build of gfx10 verified fixed with this patch. |
stellaraccident
deleted the
users/stellaraccident/generic_empty_targets
branch
This was referenced Nov 14, 2025
bsyrowik
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Nov 17, 2025
## Motivation Long-term rocWMMA fix for ROCm/TheRock#2136 ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Nov 17, 2025
[rocWMMA] Handle explicit empty target selection ## Motivation Long-term rocWMMA fix for ROCm/TheRock#2136 ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
bsyrowik
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Nov 26, 2025
## Motivation Long-term rocWMMA fix for ROCm/TheRock#2136 ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
rponnuru5
pushed a commit
that referenced
this pull request
Dec 9, 2025
…le. (#2136) Neither hipblaslt nor rocwmma can build with an explicitly empty target list (the former because Tensile has issues and the latter because hipcc will silently default to gfx906, which is not supported by rocwmma). There was an existing hack buried in the code to work around hipblaslt. Turns this into a real kwarg to the project declaration and defines it for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither hipblaslt nor rocwmma can build with an explicitly empty target list (the former because Tensile has issues and the latter because hipcc will silently default to gfx906, which is not supported by rocwmma).
There was an existing hack buried in the code to work around hipblaslt. Turns this into a real kwarg to the project declaration and defines it for both.