Remove rocWMMA empty target workaround#2212
Merged
Merged
Conversation
bsyrowik
force-pushed
the
users/bsyrowik/rocwmma_empty_target
branch
from
62239a5 to
5c15612
Compare
stellaraccident
approved these changes
Nov 21, 2025
rponnuru5
pushed a commit
that referenced
this pull request
Dec 9, 2025
## Motivation Remove the workaround for when we try to build rocWMMA with an empty target. ## Technical Details As of 2025/11/19 rocWMMA will default to the first compatible target in the case where we explicitly specify an empty GPU_TARGET. See ROCm/rocm-libraries#2678 ## Test Plan Test against gfx103X: https://github.com/ROCm/TheRock/actions/runs/19517010601 <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove the workaround for when we try to build rocWMMA with an empty target.
Technical Details
As of 2025/11/19 rocWMMA will default to the first compatible target in the case where we explicitly specify an empty GPU_TARGET. See ROCm/rocm-libraries#2678
Test Plan
Test against gfx103X:
https://github.com/ROCm/TheRock/actions/runs/19517010601
Test Result
Submission Checklist