Repository navigation
Conversation
Naraenda
requested review from
a team,
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
June 13, 2025 09:25
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
commented
Jun 13, 2025
|
/azp run rocRAND |
commented
Jun 13, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
commented
Jun 17, 2025
Contributor
|
This looks good, thanks! I've rerun the CI that was failing on almalinux8, since the error looked like it might be spurious. |
commented
Jun 17, 2025
commented
Jun 17, 2025
|
/azp run rocRAND |
commented
Jun 17, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
umfranzw
previously approved these changes
Jun 17, 2025
![dependabot[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
) Bumps [sphinxcontrib-bibtex](https://github.com/mcmtroffaes/sphinxcontrib-bibtex) from 2.6.3 to 2.6.4. - [Changelog](https://github.com/mcmtroffaes/sphinxcontrib-bibtex/blob/develop/CHANGELOG.rst) - [Commits](mcmtroffaes/sphinxcontrib-bibtex@2.6.3...2.6.4) --- updated-dependencies: - dependency-name: sphinxcontrib-bibtex dependency-version: 2.6.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/hipBLASLt commit: e4f3bf9]
### Includes the following PRs: - ROCm#126 Co-authored-by: Wayne Franz <wayfranz@amd.com>
* based on looking at the previous code, there was always a path to call ck_args.MakeArgPtr via an else statement. We took that away with a constexpr if statment check on just DataInvokeParams. * Similar issue to the first, calling ConvTensors was never guarded by a constexpr if. Remove the guard to return to previous behaviour for non fusions.
🔁 Imported from [ROCm/Tensile#2151](ROCm/Tensile#2151) 🧑💻 Originally authored by @bstefanuk --------- Co-authored-by: Braden Stefanuk <121893577+bstefanuk@users.noreply.github.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Naraenda
requested review from
a team,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
coderfeli,
geyyer,
poyenc,
qianfengz and
tenpercent
as code owners
June 30, 2025 08:03
Naraenda
marked this pull request as draft
June 30, 2025 08:04
commented
Jun 30, 2025
Member
Author
|
Github is being annoying with changing the base, so I'm just going to reopen the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original change by @NB4444, I'm porting this over from our internal repository. This changes the original fix by @umfranzw s.t. it uses
get_native_vector()instead of the neweroperator[]accessor.get_native_vector()would result in better generated code sinceoperator[]may spill to memory (see ROCm/clr#167).