[hipCUB] Fix oob_default bug for block_merge_sort.#124
Merged
Conversation
…elease-staging_rocm-rel-7.0/NguyenNhuDi_hipCUB/zenguyen_fix-block-merge-sort-function
assistant-librarian
Bot
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
stanleytsang-amd
approved these changes
May 30, 2025
stanleytsang-amd
merged commit b46b181
into
release-staging/rocm-rel-7.0
14 of 17 checks passed
stanleytsang-amd
deleted the
import/release-staging_rocm-rel-7.0/NguyenNhuDi_hipCUB/zenguyen_fix-block-merge-sort-function
branch
assistant-librarian Bot
pushed a commit
to ROCm/hipCUB
that referenced
this pull request
Jun 11, 2025
[hipCUB] Fix `oob_default` bug for `block_merge_sort`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR fixes an issue where if the `valid_items` and `oob_default` parameter was used, the invalid elements was not filled in with `oob_default`.
danielsu-amd
pushed a commit
that referenced
this pull request
Jun 17, 2025
This PR fixes an issue where if the `valid_items` and `oob_default` parameter was used, the invalid elements was not filled in with `oob_default`. --- 🔁 Imported from [ROCm/hipCUB#479](ROCm/hipCUB#479) 🧑💻 Originally authored by @NguyenNhuDi --------- Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
jayhawk-commits
added a commit
that referenced
this pull request
Jun 18, 2025
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Parameter case clang tidy, cover missed targets, fix all warnings * Remove line
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Parameter case clang tidy, cover missed targets, fix all warnings * Remove line [ROCm/hipDNN commit: b3f8983]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if the
valid_itemsandoob_defaultparameter was used, the invalid elements was not filled in withoob_default.🔁 Imported from ROCm/hipCUB#479
🧑💻 Originally authored by @NguyenNhuDi