Repository navigation
[rocRAND] Update HIP vector accesses in rocrand - #126
Merged
umfranzw merged 1 commit intoJun 2, 2025
Merged
Conversation
Prior to HIP 7.0, individual elements of HIP vectors (eg. int2) could be accessed through the vector's data member, eg: int2 vec; vec.data[0] = 1; Starting with HIP 7.0, the data member is hidden, so accesses can be performed directly, like this: int2 vec; vec[0] = 1; This change adds a macro that checks the HIP major version number and appends a ".data" if necessary. For example: ROCRAND_HIPVEC_ACCESS(vec)[0] = 1; In HIP < 7.0, this will generate: vec.data[0] = 1; In HIP >= 7.0, it will generate: vec[0] = 1;
umfranzw
requested review from
a team,
RobsonRLemos,
lawruble13 and
stanleytsang-amd
as code owners
May 30, 2025 00:29
stanleytsang-amd
approved these changes
Jun 2, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocRAND
that referenced
this pull request
Jun 10, 2025
[rocRAND] Update HIP vector accesses in rocrand Prior to HIP 7.0, individual elements of HIP vectors (eg. int2) could be accessed through the vector's data member, eg: `int2 vec; vec.data[0] = 1;` Starting with HIP 7.0, the data member is hidden, so accesses can be performed directly, like this: `int2 vec; vec[0] = 1;` This change adds a macro that checks the HIP major version number and appends a ".data" if necessary. For example: `ROCRAND_HIPVEC_ACCESS(vec)[0] = 1;` In HIP < 7.0, this will generate: `vec.data[0] = 1;` In HIP >= 7.0, it will generate: `vec[0] = 1;` Note that this change depends on https://github.com/AMD-ROCm-Internal/clr/pull/402
jayhawk-commits
pushed a commit
that referenced
this pull request
Jun 17, 2025
Prior to HIP 7.0, individual elements of HIP vectors (eg. int2) could be accessed through the vector's data member, eg: `int2 vec; vec.data[0] = 1;` Starting with HIP 7.0, the data member is hidden, so accesses can be performed directly, like this: `int2 vec; vec[0] = 1;` This change adds a macro that checks the HIP major version number and appends a ".data" if necessary. For example: `ROCRAND_HIPVEC_ACCESS(vec)[0] = 1;` In HIP < 7.0, this will generate: `vec.data[0] = 1;` In HIP >= 7.0, it will generate: `vec[0] = 1;` Note that this change depends on https://github.com/AMD-ROCm-Internal/clr/pull/402
jayhawk-commits
added a commit
that referenced
this pull request
Jun 18, 2025
### Includes the following PRs: - #126 Co-authored-by: Wayne Franz <wayfranz@amd.com>
eidenyoshida
pushed a commit
that referenced
this pull request
Jul 25, 2025
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* CPU ref for samples & templated epsilon * Manual sanity check for bn infer cpu * Rename * BN training sample ref stub * Change epsilon
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* CPU ref for samples & templated epsilon * Manual sanity check for bn infer cpu * Rename * BN training sample ref stub * Change epsilon [ROCm/hipDNN commit: 4d2f979]
evetsso
pushed a commit
to evetsso/rocm-libraries
that referenced
this pull request
Dec 31, 2025
[rocRoller] QA for WMMA hazards
stanleytsang-amd
pushed a commit
that referenced
this pull request
Sep 18, 2026
… have no device implementation
stanleytsang-amd
pushed a commit
that referenced
this pull request
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to HIP 7.0, individual elements of HIP vectors (eg. int2) could be accessed through the vector's data member, eg:
int2 vec; vec.data[0] = 1;Starting with HIP 7.0, the data member is hidden, so accesses can be performed directly, like this:
int2 vec; vec[0] = 1;This change adds a macro that checks the HIP major version number and appends a ".data" if necessary.
For example:
ROCRAND_HIPVEC_ACCESS(vec)[0] = 1;In HIP < 7.0, this will generate:
vec.data[0] = 1;In HIP >= 7.0, it will generate:
vec[0] = 1;Note that this change depends on https://github.com/AMD-ROCm-Internal/clr/pull/402