Skip to content

[hipCUB][CCCL 2.8 Parity] Hipcub general change to CCCL 2.8 - #1232

Closed
cenxuantian wants to merge 13 commits into
ROCm:developfrom
StreamHPC:users/cenxuantian/hipcub-cccl-2-8-x
Closed

[hipCUB][CCCL 2.8 Parity] Hipcub general change to CCCL 2.8#1232
cenxuantian wants to merge 13 commits into
ROCm:developfrom
StreamHPC:users/cenxuantian/hipcub-cccl-2-8-x

Conversation

@cenxuantian

@cenxuantian cenxuantian commented Aug 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

hipCUB-4.1.0 for ROCm 7.1 General changes

Added

  • Add support for large num_items DeviceScan, DevicePartition and Reduce::{ArgMin, ArgMax}.
  • Added tests for large num_items.

Changed

  • Changed include headers to avoid relative includes that have slipped in.

rocPRIM-4.1.0 for ROCm 7.1 General changes

Added

  • Added rocprim::transform_output_iterator and rocprim::make_transform_output_iterator.
  • Changed tests to support ptr-to-const output in /test/rocprim/test_device_batch_memcpy.cpp.

Submission Checklist

Naraenda and others added 13 commits August 12, 2025 14:00
@Naraenda
test(hipcub): fix warnings in tests
796883e
@cenxuantian
add ptr-to-const test for batch memcpy in rocprim
6c46a0f
@cenxuantian
Avoid relative includesthat have slipped in
02459c3
@cenxuantian
Add tests for large num_items for hipcub::Reduce:{ArgMin, ArgMax}
b120204
@cenxuantian
Add support for large num_items in DevicePartition
56113b6
@cenxuantian
Adds support for large number of items to DeviceScan::-*ByKey family …
833b701 
…of algorithms
@cenxuantian
Add support for large num_items in nvcc backend for device_scan and d…
01faf11 
…evice_partition
@Naraenda
feat(rocprim): added 'transform_output_iterator'
491ff49
@Naraenda
feat(hipcub): added new api for 'hipcub::Arg{Min,Max}' that takes in …
cf2cd52 
…two output iterators: one index and one value
@Naraenda
style(rocprim): update style
b641f02
@Naraenda
refactor(hipcub): mark old 'hipcub::Arg{Min,Max}' api as deprecated
baff2bf
@Naraenda
fix(hipcub): ignore deprecated argmin call in benchmark
6943aeb
@cenxuantian
Merge branch 'users/naraenda/hipcub-arg-min-max' into 'users/cenxuant…
a9acf5c 
…ian/hipcub-cccl-2-8-x'

feat(hipcub): implement hipcub::Arg{Min,Max}

See merge request amd/libraries/rocm-libraries!65
@cenxuantian
cenxuantian requested review from a team as code owners August 15, 2025 19:50
@assistant-librarian assistant-librarian Bot added the external contribution Code contribution from users community.. label Aug 15, 2025
@Naraenda Naraenda mentioned this pull request Aug 18, 2025
Merged
stanleytsang-amd pushed a commit that referenced this pull request Aug 27, 2025
@Naraenda @cenxuantian
Trigger complete CI for: #1232 Hipcub general change to CCCL 2.8 (#1246)
2725eb0 
Complete CI trigger requires PR to be made from same remote.

For PR details see: #1232

---------

Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com>
assistant-librarian Bot pushed a commit to ROCm/hipCUB that referenced this pull request Aug 27, 2025
@Naraenda @assistant-librarian
[rocm-libraries] ROCm/rocm-libraries#1246 (commit 2725eb0)
63f1e40 
Trigger complete CI for: #1232 Hipcub general change to CCCL
 2.8 (#1246)

Complete CI trigger requires PR to be made from same remote.

For PR details see: ROCm/rocm-libraries#1232
assistant-librarian Bot pushed a commit to ROCm/rocPRIM that referenced this pull request Aug 27, 2025
@Naraenda @assistant-librarian
[rocm-libraries] ROCm/rocm-libraries#1246 (commit 2725eb0)
124e684 
Trigger complete CI for: #1232 Hipcub general change to CCCL
 2.8 (#1246)

Complete CI trigger requires PR to be made from same remote.

For PR details see: ROCm/rocm-libraries#1232
@cenxuantian

cenxuantian commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

@Naraenda made a PR for this #1246, which is merged, so this can be closed

ammallya pushed a commit to ROCm/hipCUB that referenced this pull request Oct 28, 2025
@Naraenda @cenxuantian
Trigger complete CI for: #1232 Hipcub general change to CCCL 2.8 (#1246)
a037697 
Complete CI trigger requires PR to be made from same remote.

For PR details see: ROCm/rocm-libraries#1232

---------

Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com>
ammallya pushed a commit to ROCm/rocPRIM that referenced this pull request Oct 28, 2025
@Naraenda @cenxuantian
Trigger complete CI for: #1232 Hipcub general change to CCCL 2.8 (#1246)
7fa0fe0 
Complete CI trigger requires PR to be made from same remote.

For PR details see: ROCm/rocm-libraries#1232

---------

Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com>
stanleytsang-amd pushed a commit that referenced this pull request Sep 18, 2026
@Naraenda @cenxuantian
Trigger complete CI for: #1232 Hipcub general change to CCCL 2.8 (#1246)
bc46cd4 
Complete CI trigger requires PR to be made from same remote.

For PR details see: #1232

---------

Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com>
mpanoop pushed a commit to mpanoop/rocm-libraries that referenced this pull request Oct 5, 2026
@Naraenda @cenxuantian
Trigger complete CI for: ROCm#1232 Hipcub general change to CCCL 2.8 (R…
94dcbb4 
…OCm#1246)

Complete CI trigger requires PR to be made from same remote.

For PR details see: ROCm#1232

---------

Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com>
@AviralGoelAMD AviralGoelAMD mentioned this pull request Oct 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

external contribution Code contribution from users community.. project: hipcub project: rocprim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cenxuantian @Naraenda