Update TheRock reference to (2a55cec) by assistant-librarian[bot] · Pull Request #13623 · ROCm/rocm-libraries

assistant-librarian · 2026-10-14T11:18:09Z

Updated all pinned TheRock workflow and source refs to 2a55cec due to submodule bump

therock-pr-bot · 2026-10-14T11:21:45Z

🤖 Bump PR detected (author @assistant-librarian[bot]). All policy checks are auto-approved for automated dependency bumps.

tony-davis · 2026-10-14T18:20:16Z

CI review: tracked breakdown

Verdict: safe to merge. This bump does not add CI red beyond what is already tracked or newly filed. Both failures are Windows gfx110X quick-tier timeouts that also fail on develop with the old pin, so they are not caused by the bump. As usual Multi-Arch CI Summary is red because of them, so merging needs the override, plus code-owner approval (REVIEW_REQUIRED).

Per-failure disposition (rocm-libraries scope only)

Job	Target / Arch	Signature	Disposition	Ticket
Test rocfft (shard 1/1)	rocfft (gfx110X-all, Windows)	test-timeout: `rocfft-test_quick_suite` (600 s)	tracked	#13414
Test rocsparse (shard 1/1)	rocsparse (gfx110X-all, Windows)	test-timeout: `rocsparse-test_quick_suite` (300 s)	new, not bump-caused	filed: #13649

The two Multi-Arch CI Summary failures (one per run attempt) are the aggregate rollup, not separate problems. The 15 cancelled jobs belong to attempt 1 of the Multi-Arch run, which was cancelled when attempt 2 started; attempt 2 ran the gfx950 tests normally. No rocm-systems or TheRock-owned reds.

What this bump actually brings in

TheRock c01e3a3 -> 2a55cec (18 commits). Submodules that moved:

Submodule	Repo	Commits	Notable changes
`compiler/amd-llvm`	ROCm/llvm-project	2	a gfx950 `v_pk_{add,mul,fma}_f32` invalid-op_sel test, and Comgr static-LLVM linkage isolation (#2389)
`rocm-libraries`	ROCm/rocm-libraries	65	rocSPARSE AISPARSE grid-clamp fixes, MIOpen gfx942 small-batch 1x1 conv GEMM gate, rocFFT partial-pass c2r lengths, hipBLASLt CPU-reference fixes, rocKE prefetch and TDM work, MIOpen hipDNN wrapper entry points
`rocm-systems`	ROCm/rocm-systems	93	rocjitsu DBI updates, rocprofiler-sdk and amdsmi fixes (amdsmi 27.2.0), clr and hip-tests cache-sync skip, gfx117x media-libs targets, kpack allocation bounds

Writes made in this review

Filed: [develop] rocSPARSE quick-tier smoketest times out (300 s) on Windows gfx110X #13649
Updated (evidence): none this round ([develop] rocFFT quick-tier smoketest times out (600 s) on Windows gfx110X #13414 already carries the rocFFT evidence)

Caveat: the nightly baseline could not be computed this round (the jobs API returned 502 for the 10-13 nightly), but Windows gfx110X has not been in the nightly matrix on earlier reviews, so it would likely not have added information.

tony-davis

Approving after CI review.

The bot cleared baseline-run-id in #13623 alongside the TheRock ref bump to 2a55cec, and this branch inherited the empty value when develop was merged. An empty baseline makes therock-multi-arch-ci.yml pass prebuilt_stages="" and stage_reuse_mode=off, so every stage rebuilds and the run looks like changed_projects failed to narrow anything. It did not: setup resolved all 34 rocm-libraries projects and put rccl/rocshmem/core-hiptests in reusable_artifacts, exactly as #8514 expects. Restore 38220501023, the baseline develop carried before the bump and the one the stacked rocPRIM PR still uses, so the two test PRs differ only in their diffs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ScottTodd · 2026-10-15T00:13:16Z

  baseline-run-id:
    description: "TheRock workflow run ID for prebuilt stage artifacts"
-    value: "38220501023" # Updated by assistant-librarian[bot] on submodule bumps
+    value: "" # Updated by assistant-librarian[bot] on submodule bumps


Dropping the baseline-run-id here is causing lots of workflow runs to rebuild all stages, including the WSL ROCDXG stage that uses very limited WSL runners. This is contributing to job queue times across repositories.

For example: https://github.com/ROCm/rocm-libraries/actions/runs/38633953407?pr=13671 built the "emulation", "storage libs", "debug tools", "runtime tests", "comm libs", "WSL ROCXG", and other stages that are independent of rocm-libraries.

Reverts #13623

…ernal-ci-file-goodbye Both conflicts trace to #13698, which reverted the TheRock ref bump #13623. .github/workflows/therock-multi-arch-ci.yml: kept this branch's version. Every develop hunk re-pins an @<ref> from 2a55cec to c01e3a3, and this branch deliberately points those at the users/geomin12/external-ci-file-goodbye branch instead. The remaining hunk restores the `configure` job and its configure_external_repo_ci.py call, which is exactly what this PR deletes. .github/actions/ci-env/action.yml: took develop's version. The revert restored baseline-run-id 38220501023, the same value 67a16e4 pinned by hand, so the stage reuse this branch needs survives while the now-stale DO-NOT-MERGE rationale goes away: develop owns that value again. therock-ref follows develop back to c01e3a3; its only consumer here is the rocjitsu race check job. Side effect: ci-env now matches develop exactly, so it drops out of the PR diff and the run narrows on the workflow path alone.

assistant-librarian · 2026-10-16T13:06:10Z

TheRock Submodule Bump Activity

Newest first

2026-10-16 — Included in TheRock via ROCm/TheRock#9032.

…d scripts (#13729) Resolves #13727 ## Summary Adds a `github-ci-pr-quality` overlay on the `rocm-pr-quality` base skill for changes under `.github/`. It tells authors and reviewers where CI tests belong (extend an existing lane, not a new workflow per test), how to size runners and checkout, how to treat shared state in `ci-env`, and to read each affected project's TESTING.md before changing a lane or gate. It also covers what a CI job checks out (the PR merge ref, `refs/pull/<N>/merge`, so every lane tests the same tree) and requires CI references to be updated when files move or are deleted. A matching Copilot review instructions file loads it for `.github/**`. This is the second of two PRs; it is stacked on the root AGENTS.md PR (#13728), so its base is that branch until #13728 merges. ## Risk Assessment 1/5. Guidance for reviewers and AI assistants only. No workflow, script, or build changes, and the guidance is advisory. One behavior change: Copilot code review will start applying this guidance to PRs that touch `.github/**`. ## Related - Work tracking: #13727 - Depends on: #13728 (the root AGENTS.md PR, tracked in #13726) - Cases it is designed to catch: #12185, #13623 (reverted in #13698), and the stale paths left by #12150 (fixed in #13399) - Review input: a skill-forge review of the PR-quality skills (findings R2, R3, R4, R8, M4/R7 applied here; the helper findings M1, M2, M3, and R5 are fixed in ROCm/TheRock#6653; the rest of the base-skill findings are still open) - Base skill: `skills/rocm-pr-quality/` in ROCm/TheRock ## Testing Summary - `pre-commit` on the changed files passed. Every workflow, script, action value, and path the skill cites was checked against `origin/develop`. ## Testing Checklist - [x] pre-commit on the changed files - Status: Passed - [x] Cited paths and facts checked against `develop` - Status: Passed - [ ] PR CI - GitHub PR checks - Status: Pending ## Flags / Guardrails None. The guidance is advisory. ## Adjacent Tests Considered None apply; no code changes. ## Technical Changes - New `skills/github-ci-pr-quality/SKILL.md` with the TESTING.md cross-read, five CI change classes, and test-placement, runner-sizing, trigger-scope, tested-tree, and shared-state rules. Trigger scope includes checks that path filters match real files and that moves and deletes update CI in the same PR. It tightens stale-base and approvals, adds a review checklist, three worked examples, and a completed retrospective review of #12185 as a model of the required output. - Review contract: the overlay keeps review read-only (pre-commit runs in a throwaway checkout), and requires caller edits only for breaking workflow interface changes. - New `.github/instructions/github-ci-pr-quality.instructions.md` (`applyTo: ".github/**"`). - `AGENTS.md`: the planned catalog row now links to the skill, and the new instructions file is listed. ## Risk Acceptance / Waivers `W-DOC`: guidance only; no product or CI behavior changes. --------- Co-authored-by: Cursor <cursoragent@cursor.com>

## Motivation The current develop branch uses TheRock commit 4743438 with baseline run 38722718475. This pull request moves the pin from the previous pair, d28f23b / 39269411010, to the current rocm-libraries bump and its matching baseline. ## Technical Details - Updates the pinned TheRock commit: From: 47434387de730d51788b705e5600602dd6064997 To: b0958085a97cb03a2c38931b8e2ec86ac78d1563 - Updates baseline-run-id: From: 38722718475 To: 39513854305 - The baseline was produced from the same b0958085 TheRock commit, TheRock #9359: https://github.com/ROCm/TheRock/actions/runs/39513854305 REF: #13623, #13698 ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. --------- Co-authored-by: Cursor <cursoragent@cursor.com>

Update TheRock ref to 2a55cec

0479be5

assistant-librarian Bot requested a review from a team as a code owner October 14, 2026 11:18

github-actions Bot added github actions project: none Does not target any component labels Oct 14, 2026

assistant-librarian Bot added the external contribution Code contribution from users community.. label Oct 14, 2026

tony-davis mentioned this pull request Oct 14, 2026

[develop] rocSPARSE quick-tier smoketest times out (300 s) on Windows gfx110X #13649

Closed

tony-davis approved these changes Oct 14, 2026

View reviewed changes

tony-davis merged commit 86af0be into develop Oct 14, 2026
363 of 385 checks passed

tony-davis deleted the update-therock-rocm-libraries-2a55cec branch October 14, 2026 18:21

ScottTodd reviewed Oct 15, 2026

View reviewed changes

arvindcheru mentioned this pull request Oct 15, 2026

Revert "Update TheRock reference to (2a55cec)" #13698

Merged

tony-davis pushed a commit that referenced this pull request Oct 15, 2026

Revert "Update TheRock reference to (2a55cec)" (#13698)

9e1ad21

Reverts #13623

arvindcheru mentioned this pull request Oct 15, 2026

ci: update TheRock pin and preserve baseline stage reuse #13703

Merged

1 task

This was referenced Oct 15, 2026

Add a github-ci-pr-quality overlay for .github workflows, actions, and scripts #13727

Open

docs(ci): add github-ci-pr-quality overlay for workflows, actions, and scripts #13729

Merged

tony-davis mentioned this pull request Oct 22, 2026

Update TheRock reference to (e1402db) #14217

Closed

Navigation Menu

Repository navigation

Update TheRock reference to (2a55cec) - #13623

Update TheRock reference to (2a55cec)#13623
tony-davis merged 1 commit into
developfrom
update-therock-rocm-libraries-2a55cec

assistant-librarian Bot commented Oct 14, 2026

Uh oh!

therock-pr-bot Bot commented Oct 14, 2026

Uh oh!

tony-davis commented Oct 14, 2026

Uh oh!

tony-davis left a comment

Uh oh!

Uh oh!

ScottTodd Oct 15, 2026

Uh oh!

ScottTodd Oct 15, 2026

Uh oh!

assistant-librarian Bot commented Oct 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

assistant-librarian Bot commented Oct 14, 2026

Uh oh!

therock-pr-bot Bot commented Oct 14, 2026

Uh oh!

tony-davis commented Oct 14, 2026

CI review: tracked breakdown

Per-failure disposition (rocm-libraries scope only)

What this bump actually brings in

Writes made in this review

Uh oh!

tony-davis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ScottTodd Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

ScottTodd Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

assistant-librarian Bot commented Oct 16, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants