Skip to content

Update TheRock reference to (2a55cec) #13623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tony-davis merged 1 commit into from
Oct 14, 2026
Merged

Update TheRock reference to (2a55cec) #13623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/ci-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: "Single source of truth for shared CI constants (TheRock ref, Docke
outputs:
therock-ref:
description: "TheRock commit hash to use"
value: "c01e3a3f3f67966dd35612cf363b49964f33cd47" # 2026-10-12
value: "2a55cecaa190559a46c74d60e7fae25b6ffdc797" # 2026-10-14
kpack-ref:
description: "rocm-systems commit whose shared/kpack provides the rocm_kpack packing tooling"
# Copied into dnn-providers/hip-kernel-provider/cmake/KpackPython.cmake and
Expand All @@ -13,7 +13,7 @@ outputs:
value: "a022846cf553c2b135410a5168f97705f1b9c6ac" # 2026-08-22
baseline-run-id:
description: "TheRock workflow run ID for prebuilt stage artifacts"
value: "38220501023" # Updated by assistant-librarian[bot] on submodule bumps
value: "" # Updated by assistant-librarian[bot] on submodule bumps
Comment on lines 14 to +16

@ScottTodd ScottTodd Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the baseline-run-id here is causing lots of workflow runs to rebuild all stages, including the WSL ROCDXG stage that uses very limited WSL runners. This is contributing to job queue times across repositories.

@ScottTodd ScottTodd Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: https://github.com/ROCm/rocm-libraries/actions/runs/38633953407?pr=13671 built the "emulation", "storage libs", "debug tools", "runtime tests", "comm libs", "WSL ROCXG", and other stages that are independent of rocm-libraries.

docker-image:
description: "Docker container image for Linux builds"
value: "ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:cf4f6d9909056906e4a1c0bc4c245658a0af4c6a6174082a86adfa2d518b7aeb"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
path: TheRock

- name: Install base dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/therock-ci-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
with:
repository: "ROCm/TheRock"
path: TheRock
ref: ${{ inputs.therock_ref_override || 'c01e3a3f3f67966dd35612cf363b49964f33cd47' }}
ref: ${{ inputs.therock_ref_override || '2a55cecaa190559a46c74d60e7fae25b6ffdc797' }}

- name: Log locked TheRock ref
run: |
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/therock-multi-arch-ci-asan-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency:

jobs:
setup:
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
with:
build_variant: "asan"
linux_amdgpu_families: "gfx94X,gfx950,gfx125X"
Expand All @@ -37,7 +37,7 @@ jobs:
build_pytorch: false
build_jax: false
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
# event_name tells TheRock this is a schedule/workflow_dispatch run with no
# meaningful diff, so it always runs CI. Without it, TheRock falls back to
# `git diff HEAD^` against a depth-1 checkout, which fails.
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
needs.setup.outputs.linux_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.linux_build_config }}
Expand All @@ -83,7 +83,7 @@ jobs:
test_type: ${{ needs.setup.outputs.test_type }}
external_repo_config: ${{ needs.setup.outputs.external_repo_config }}
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand All @@ -100,7 +100,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: "ROCm/TheRock"
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
sparse-checkout: build_tools/github_actions
sparse-checkout-cone-mode: true

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/therock-multi-arch-ci-asan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ concurrency:

jobs:
setup:
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
with:
build_variant: "asan"
linux_amdgpu_families: ${{ inputs.linux_amdgpu_families || 'gfx94X,gfx950,gfx125X' }}
Expand All @@ -70,7 +70,7 @@ jobs:
build_pytorch: false
build_jax: false
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
# The SHAs, event name, and skip-CI config path let TheRock compute the
# changed-file set and skip CI for docs-only changes. Without them it
# falls back to `git diff HEAD^` against a depth-1 checkout, which fails.
Expand All @@ -93,7 +93,7 @@ jobs:
needs.setup.outputs.linux_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.linux_build_config }}
Expand All @@ -104,7 +104,7 @@ jobs:
test_type: ${{ needs.setup.outputs.test_type }}
external_repo_config: ${{ needs.setup.outputs.external_repo_config }}
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand All @@ -121,7 +121,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: "ROCm/TheRock"
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
sparse-checkout: build_tools/github_actions
sparse-checkout-cone-mode: true

Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/therock-multi-arch-ci-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

name: TheRock Multi-Arch Nightly CI

# TheRock ref: pinned to ROCm/TheRock commit c01e3a3f3f67966dd35612cf363b49964f33cd47.
# TheRock ref: pinned to ROCm/TheRock commit 2a55cecaa190559a46c74d60e7fae25b6ffdc797.

on:
schedule:
Expand All @@ -34,7 +34,7 @@ concurrency:

jobs:
setup:
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
with:
build_variant: "release"
# Limit GPU families for nightly CI: gfx94X, gfx950 (Linux) and gfx1151 (Windows).
Expand All @@ -48,7 +48,7 @@ jobs:
prebuilt_stages: ''
baseline_run_id: ''
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
# event_name tells TheRock this is a schedule/workflow_dispatch run with no
# meaningful diff, so it always runs CI. Without it, TheRock falls back to
# `git diff HEAD^` against a depth-1 checkout, which fails.
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
needs.setup.outputs.linux_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.linux_build_config }}
Expand All @@ -96,7 +96,7 @@ jobs:
# Empty string triggers full test run in downstream workflow
changed_projects: ''
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand All @@ -109,7 +109,7 @@ jobs:
needs.setup.outputs.windows_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_windows.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_windows.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.windows_build_config }}
Expand All @@ -120,7 +120,7 @@ jobs:
# Empty string triggers full test run in downstream workflow
changed_projects: ''
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand All @@ -138,7 +138,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: "ROCm/TheRock"
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
sparse-checkout: build_tools/github_actions
sparse-checkout-cone-mode: true

Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/therock-multi-arch-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

name: TheRock Multi-Arch CI

# TheRock ref: pinned to ROCm/TheRock commit c01e3a3f3f67966dd35612cf363b49964f33cd47.
# TheRock ref: pinned to ROCm/TheRock commit 2a55cecaa190559a46c74d60e7fae25b6ffdc797.
# NOTE: update all `@<ref>` refs and `ref:` inputs together when switching.

on:
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797
path: _therock
sparse-checkout: build_tools/github_actions
sparse-checkout-cone-mode: true
Expand All @@ -153,7 +153,7 @@ jobs:

setup:
needs: [ci-env, configure]
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/setup_multi_arch.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
with:
build_variant: "release"
# Limit GPU families for rocm-libraries CI.
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
'off'
}}
repository: ROCm/TheRock
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
# Pass external repo info for stage-impact analysis.
# extra_cmake_options is appended to the cmake configure line of every
# build stage, scoped to this repository's CI runs. TheRock keeps
Expand Down Expand Up @@ -222,7 +222,7 @@ jobs:
needs.setup.outputs.linux_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_linux.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.linux_build_config }}
Expand All @@ -236,7 +236,7 @@ jobs:
changed_projects: ${{ needs.configure.outputs.run_all_tests == 'true' && '' || needs.configure.outputs.test_projects }}
repository: ROCm/TheRock
# Concrete SHA resolved once by setup; do not re-resolve main here.
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand All @@ -249,7 +249,7 @@ jobs:
needs.setup.outputs.windows_build_config != '' &&
needs.setup.outputs.enable_build_jobs == 'true'
}}
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_windows.yml@c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
uses: ROCm/TheRock/.github/workflows/multi_arch_ci_windows.yml@2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
secrets: inherit
with:
build_config: ${{ needs.setup.outputs.windows_build_config }}
Expand All @@ -261,7 +261,7 @@ jobs:
changed_projects: ${{ needs.configure.outputs.run_all_tests == 'true' && '' || needs.configure.outputs.test_projects }}
repository: ROCm/TheRock
# Concrete SHA resolved once by setup; do not re-resolve main here.
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
permissions:
contents: read
id-token: write
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
with:
repository: "ROCm/TheRock"
# Concrete SHA resolved once by setup; do not re-resolve main here.
ref: c01e3a3f3f67966dd35612cf363b49964f33cd47 # 2026-10-12
ref: 2a55cecaa190559a46c74d60e7fae25b6ffdc797 # 2026-10-14
sparse-checkout: build_tools/github_actions
sparse-checkout-cone-mode: true

Expand Down
Loading