ci(tensilelite): prevent new legacy Tensile imports (AIHPBLAS-3989) by Alex-Vasile · Pull Request #13278 · ROCm/rocm-libraries

Alex-Vasile · 2026-10-07T20:01:28Z

JIRA ID : AIHPBLAS-3989

Motivation

#12150 moves the Python implementation from Tensile to tensilelite while keeping Tensile importable through a temporary compatibility package. New imports using the old name would add references that must be removed before that package can go away.

Technical Details

Add a root pre-commit hook that checks newly added or modified import statements in Python files under both package roots. It rejects absolute imports beginning with Tensile or tensilelite, so internal modules use package-relative imports.
Check changed lines only, allowing existing imports to remain during the migration. The checker ignores strings, comments, and files under Tests/.
Allow the one absolute import needed by Tensile/__init__.py to install the compatibility alias. This exception will be removed in #12162 when that PR removes the bridge.

This PR depends on #12150.

Test Plan

Run the checker's Python unit tests, which exercise staged and PR-range changes, both package roots, the bridge exception, and existing imports. Run the repository's pre-commit checks in PR CI. GPU testing is unnecessary because this change only examines Python source.

Test Result

Checker unit tests: 34 passed.
git diff --check: passed.
PR CI: pending.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.

Risk level

Medium (3/5): the new check can reject TensileLite Python changes in pre-commit CI. It does not change packaged code or GPU behavior.

therock-pr-bot · 2026-10-07T20:06:03Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-10-07T20:06:06Z

🎉 All checks passed! This PR is ready for review.

codecov · 2026-10-07T22:57:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #13278      +/-   ##
===========================================
- Coverage    74.64%   74.63%   -0.01%     
===========================================
  Files         2881     2881              
  Lines       480340   480423      +83     
  Branches     71286    71290       +4     
===========================================
+ Hits        358536   358562      +26     
- Misses       97494    97550      +56     
- Partials     24310    24311       +1

Flag	Coverage Δ		*Carryforward flag
TensileLite-CPP	`49.70% <ø> (ø)`
TensileLite-Unit	`83.57% <ø> (ø)`
hipBLAS	`90.62% <ø> (ø)`		Carriedforward from 8db16c8
hipBLASLt	`43.29% <ø> (-0.04%)`	⬇️
hipCUB	`82.68% <ø> (ø)`		Carriedforward from 8db16c8
hipDNN	`86.80% <ø> (ø)`		Carriedforward from 8db16c8
hipFFT	`42.00% <ø> (ø)`		Carriedforward from 8db16c8
hipRAND	`76.12% <ø> (ø)`		Carriedforward from 8db16c8
hipSOLVER	`69.45% <ø> (ø)`		Carriedforward from 8db16c8
hipSPARSE	`86.99% <ø> (ø)`		Carriedforward from 8db16c8
rocBLAS	`68.73% <ø> (ø)`		Carriedforward from 8db16c8
rocFFT	`45.70% <ø> (ø)`		Carriedforward from 8db16c8
rocRAND	`57.29% <ø> (ø)`		Carriedforward from 8db16c8
rocSOLVER	`76.83% <ø> (ø)`		Carriedforward from 8db16c8
rocSPARSE	`77.05% <ø> (ø)`		Carriedforward from 8db16c8
rocThrust	`93.15% <ø> (ø)`		Carriedforward from 8db16c8

*This pull request uses carry forward flags. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

newling

Just to understand, what's the alternative here, that we don't add these tests and then at some point in the future we just make import Tensile stop working and patch any remaining Tensile->tensilelite fixes that are needed, in a single PR, i.e. make Tensile illegal and fix remaining cases in 1 PR. What is the problem with that, is it just that we can 2 PRs that pass CI that are mutually imcompatible?

Alex-Vasile · 2026-10-13T12:43:46Z

Just to understand, what's the alternative here, that we don't add these tests and then at some point in the future we just make import Tensile stop working and patch any remaining Tensile->tensilelite fixes that are needed, in a single PR, i.e. make Tensile illegal and fix remaining cases in 1 PR. What is the problem with that, is it just that we can 2 PRs that pass CI that are mutually imcompatible?

The problem with that approach is practicality. There are still a lot of imports that need to be changed and getting all of those through CI will take time, during which new (Tensile-style) imports will be added, which either require a new PRs to clean up, or continuously patching and rebasing the final PR that removes that support for import Tensile. In addition to rebasing to fix merge conflicts. We had to do this for #12150, and it cost a lot of developer and CI time and made it difficult to land.

newling

LGTM, argument for adding these (temporarily) makes sense to me

…t artifacts

jaopaulolc

LGTM.

talumbau · 2026-10-14T19:58:31Z

miopen failures on Windows gfx110x-all is a timeout
rocfft failure on Windows gfx110x-all is a time out.
rocprofiler-sdk failure is not related to this change.

assistant-librarian · 2026-10-16T13:05:07Z

TheRock Submodule Bump Activity

Newest first

2026-10-16 — Included in TheRock via ROCm/TheRock#9032.

…3989) (#13932) JIRA ID : AIHPBLAS-3989 ## Motivation #12162 removes the `Tensile` compatibility package, so a new import of the old name now fails at import time. The absolute-import pre-commit hook added in #13278 still carries the `Tensile` package root, a bridge exemption for `Tensile/__init__.py`, and `Tensile` as a banned name. All of that is dead after #12162. The rule that remains useful is that `tensilelite` modules use package-relative imports. ## Technical Details - `check_no_absolute_imports.py` now checks only `projects/hipblaslt/tensilelite/tensilelite`. The `Tensile` package root, the `TEMPORARY_EXEMPTIONS` bridge exception and the `Tensile` banned name are removed, and the docstring and failure message are updated. - The `tensilelite-no-absolute-imports` pre-commit entry matches only the `tensilelite` package and its `Tests/` exclusion, and its stale "move in flight" comment is removed. - The checker's unit tests use `tensilelite` as the banned example. The bridge-exemption and missing-package-root tests are removed. An added test records that `Tensile` imports are no longer reported by this hook. - Behavior is unchanged for `tensilelite`: only lines added by a change are checked, and `Tests/` is excluded. ## Test Plan Run the checker's unit tests, which exercise staged and PR-range changes, the package root, test-directory exclusion, existing imports and unparseable files. Run the repository's pre-commit checks in PR CI. GPU testing is unnecessary because this change only examines Python source. ## Test Result - Checker unit tests: 29 passed (run with `--noconftest`; at this point in the stack the package conftest still fails on stale `Tensile` imports inherited from `develop`). - Pre-commit hook run against the full tree and PR CI: not run locally. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level Low (1/5): only the pre-commit hook and its tests change. It does not change packaged code or GPU behavior.

github-actions Bot added project: hipblaslt project: hipsparselt ci:hipsparselt-fast labels Oct 7, 2026

assistant-librarian Bot added the organization: ROCm label Oct 7, 2026

Alex-Vasile requested a review from talumbau October 7, 2026 20:52

Alex-Vasile force-pushed the users/alvasile/no-absolute-imports branch from 5a6efa4 to c5c5738 Compare October 9, 2026 15:56

Alex-Vasile marked this pull request as ready for review October 9, 2026 15:56

Alex-Vasile requested a review from a team as a code owner October 9, 2026 15:56

Alex-Vasile requested a review from newling October 9, 2026 17:00

newling requested changes Oct 12, 2026

View reviewed changes

newling approved these changes Oct 13, 2026

View reviewed changes

Alex-Vasile force-pushed the users/alvasile/no-absolute-imports branch from c5c5738 to 8b3e04e Compare October 13, 2026 18:27

Alex-Vasile enabled auto-merge (squash) October 13, 2026 18:27

talumbau approved these changes Oct 14, 2026

View reviewed changes

Alex-Vasile added 2 commits October 14, 2026 17:16

ci(tensilelite): prevent new legacy Tensile imports (AIHPBLAS-3989)

38a5f2e

[hipblaslt] Install check_no_absolute_imports.py with TensileLite tes…

9123cd7

…t artifacts

Alex-Vasile force-pushed the users/alvasile/no-absolute-imports branch from 8b3e04e to 9123cd7 Compare October 14, 2026 17:18

Alex-Vasile requested a review from a team as a code owner October 14, 2026 17:18

jaopaulolc approved these changes Oct 14, 2026

View reviewed changes

talumbau disabled auto-merge October 14, 2026 19:58

talumbau merged commit e160811 into develop Oct 14, 2026
177 of 186 checks passed

talumbau deleted the users/alvasile/no-absolute-imports branch October 14, 2026 19:58

Alex-Vasile mentioned this pull request Oct 19, 2026

ci(tensilelite): enforce only relative tensilelite imports (AIHPBLAS-3989) #13932

Merged

1 task done

Navigation Menu

Repository navigation

ci(tensilelite): prevent new legacy Tensile imports (AIHPBLAS-3989) - #13278

ci(tensilelite): prevent new legacy Tensile imports (AIHPBLAS-3989)#13278
talumbau merged 2 commits into
developfrom
users/alvasile/no-absolute-imports

Alex-Vasile commented Oct 7, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Oct 7, 2026

Uh oh!

codecov Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

newling left a comment

Uh oh!

Alex-Vasile commented Oct 13, 2026

Uh oh!

newling left a comment

Uh oh!

jaopaulolc left a comment

Uh oh!

talumbau commented Oct 14, 2026

Uh oh!

Uh oh!

assistant-librarian Bot commented Oct 16, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Alex-Vasile commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Risk level

Uh oh!

therock-pr-bot Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Oct 7, 2026

Uh oh!

codecov Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

newling left a comment

Choose a reason for hiding this comment

Uh oh!

Alex-Vasile commented Oct 13, 2026

Uh oh!

newling left a comment

Choose a reason for hiding this comment

Uh oh!

jaopaulolc left a comment

Choose a reason for hiding this comment

Uh oh!

talumbau commented Oct 14, 2026

Uh oh!

Uh oh!

assistant-librarian Bot commented Oct 16, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alex-Vasile commented Oct 7, 2026 •

edited

Loading

therock-pr-bot Bot commented Oct 7, 2026 •

edited

Loading

codecov Bot commented Oct 7, 2026 •

edited

Loading