[Alex-Vasile]

JIRA ID : AIHPBLAS-3989

Motivation

#12162 removes the Tensile compatibility package, so a new import of the old name now fails at import time. The absolute-import pre-commit hook added in #13278 still carries the Tensile package root, a bridge exemption for Tensile/__init__.py, and Tensile as a banned name. All of that is dead after #12162. The rule that remains useful is that tensilelite modules use package-relative imports.

Technical Details

• check_no_absolute_imports.py now checks only projects/hipblaslt/tensilelite/tensilelite. The Tensile package root, the TEMPORARY_EXEMPTIONS bridge exception and the Tensile banned name are removed, and the docstring and failure message are updated.
• The tensilelite-no-absolute-imports pre-commit entry matches only the tensilelite package and its Tests/ exclusion, and its stale "move in flight" comment is removed.
• The checker's unit tests use tensilelite as the banned example. The bridge-exemption and missing-package-root tests are removed. An added test records that Tensile imports are no longer reported by this hook.
• Behavior is unchanged for tensilelite: only lines added by a change are checked, and Tests/ is excluded.

Test Plan

Run the checker's unit tests, which exercise staged and PR-range changes, the package root, test-directory exclusion, existing imports and unparseable files. Run the repository's pre-commit checks in PR CI. GPU testing is unnecessary because this change only examines Python source.

Test Result

• Checker unit tests: 29 passed (run with --noconftest; at this point in the stack the package conftest still fails on stale Tensile imports inherited from develop).
• Pre-commit hook run against the full tree and PR CI: not run locally.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.

Risk level

Low (1/5): only the pre-commit hook and its tests change. It does not change packaged code or GPU behavior.

[therock-pr-bot]

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #13932      +/-   ##
===========================================
- Coverage    77.72%   77.71%   -0.01%     
===========================================
  Files         2963     2904      -59     
  Lines       513494   491013   -22481     
  Branches     79567    74424    -5143     
===========================================
- Hits        399071   381547   -17524     
+ Misses       86278    84470    -1808     
+ Partials     28145    24996    -3149     

Flag	Coverage Δ		*Carryforward flag
TensileLite-CPP	53.94% <ø> (ø)
TensileLite-Unit	84.76% <ø> (+<0.01%)	⬆️
hipBLAS	90.62% <ø> (ø)		Carriedforward from 736a02f
hipBLASLt	70.05% <ø> (ø)
hipCUB	82.68% <ø> (+3.51%)	⬆️	Carriedforward from 736a02f
hipDNN	87.25% <ø> (ø)		Carriedforward from 736a02f
hipFFT	42.57% <ø> (ø)		Carriedforward from 736a02f
hipRAND	76.12% <ø> (ø)		Carriedforward from 736a02f
hipSOLVER	69.67% <ø> (ø)		Carriedforward from 736a02f
hipSPARSE	87.03% <ø> (ø)		Carriedforward from 736a02f
rocBLAS	69.20% <ø> (ø)		Carriedforward from 736a02f
rocFFT	46.49% <ø> (ø)		Carriedforward from 736a02f
rocRAND	57.32% <ø> (ø)		Carriedforward from 736a02f
rocSOLVER	76.65% <ø> (ø)		Carriedforward from 736a02f
rocSPARSE	83.54% <ø> (ø)		Carriedforward from 736a02f
rocSPARSE-integration	?
rocSPARSE-unit	?
rocThrust	93.15% <ø> (ø)		Carriedforward from 736a02f

*This pull request uses carry forward flags. Click here to find out more.
see 146 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[peymanr]

PR Pundit review

(Testing PR Pundit Code Review agent. Not all comments may be relevant. This is a one-time automated pass: please address what is useful, no need to request a re-review. Please reply to each point, whether it applies or not: we harvest these replies, and both kinds are enormously helpful for tuning the agent. Reach out to @peymanr for suggestions.)

#		Finding	Where
1	🟠	Pre-commit hook silently passes legacy Tensile absolute imports: this PR unbanned Tensile	projects/hipblaslt/tensilelite/scripts/check_no_absolute_imports.py:42

1. 🟠 Should fix: Pre-commit hook silently passes legacy Tensile absolute imports: this PR unbanned Tensile

projects/hipblaslt/tensilelite/scripts/check_no_absolute_imports.py:42

This PR narrowed BANNED_TOP_LEVEL_NAMES to {"tensilelite"}, so a newly added import Tensile or from Tensile.Common import x no longer fails the pre-commit hook; it is only caught later by test_production_modules_do_not_import_the_legacy_tensile_package in unit CI. The in-tree Tensile package was already removed (#12162), and Tests/unit/source_only/test_canonical_imports.py still rejects absolute Tensile imports, so the narrower scope is deliberate but loses early pre-commit feedback. The test's test_allowed_forms_are_ignored now lists these legacy statements without any comment, so a reader may misread them as permitted. Restore Tensile to the hook or add a comment noting enforcement moved to test_canonical_imports.py.

Who is affected: Developers who add a stale Tensile import locally; they learn of it from the pytest/CI run instead of from pre-commit.

Checked against the code by an independent pass.

Related past reviews: #6946 on projects/hipblaslt/tensilelite/Tensile/Tests/unit/test_PlaceholderMergeRegression.py, #12161 on projects/hipblaslt/utilities/geko/tests/config_generator/test_cluster_and_postproc_unit.py

_{Shared from a pilot of PR Pundit, an agentic code reviewer that builds and tests the change and reads the project's past reviews. Reviewed at ec65098c; findings checked and posted by @peymanr; points already raised on this PR are left out.}

[Alex-Vasile]

PR Pundit review

(Testing PR Pundit Code Review agent. Not all comments may be relevant. This is a one-time automated pass: please address what is useful, no need to request a re-review. Please reply to each point, whether it applies or not: we harvest these replies, and both kinds are enormously helpful for tuning the agent. Reach out to @peymanr for suggestions.)

Finding Where

1 🟠 Pre-commit hook silently passes legacy Tensile absolute imports: this PR unbanned Tensile projects/hipblaslt/tensilelite/scripts/check_no_absolute_imports.py:42

1. 🟠 Should fix: Pre-commit hook silently passes legacy Tensile absolute imports: this PR unbanned Tensile

projects/hipblaslt/tensilelite/scripts/check_no_absolute_imports.py:42

This PR narrowed BANNED_TOP_LEVEL_NAMES to {"tensilelite"}, so a newly added import Tensile or from Tensile.Common import x no longer fails the pre-commit hook; it is only caught later by test_production_modules_do_not_import_the_legacy_tensile_package in unit CI. The in-tree Tensile package was already removed (#12162), and Tests/unit/source_only/test_canonical_imports.py still rejects absolute Tensile imports, so the narrower scope is deliberate but loses early pre-commit feedback. The test's test_allowed_forms_are_ignored now lists these legacy statements without any comment, so a reader may misread them as permitted. Restore Tensile to the hook or add a comment noting enforcement moved to test_canonical_imports.py.

Who is affected: Developers who add a stale Tensile import locally; they learn of it from the pytest/CI run instead of from pre-commit.

Checked against the code by an independent pass.

Related past reviews: #6946 on projects/hipblaslt/tensilelite/Tensile/Tests/unit/test_PlaceholderMergeRegression.py, #12161 on projects/hipblaslt/utilities/geko/tests/config_generator/test_cluster_and_postproc_unit.py

Shared from a pilot of PR Pundit, an agentic code reviewer that builds and tests the change and reads the project's past reviews. Reviewed at ec65098c; findings checked and posted by @peymanr; points already raised on this PR are left out.

The legacy Tensile imports will fail on their own now that #12162 has merged (this PR was stacked ontop of it).