Repository navigation
ci: use --gpu-corefile-tests flag for rocgdb-corefile tests - #8563
Merged
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
lumachad
self-requested a review
September 28, 2026 10:49
Contributor
|
Unit tests are failing. |
Update rocgdb-corefile test configuration to use the new --gpu-corefile-tests flag instead of manually specifying test files. The --gpu-corefile-tests flag automatically selects all tests matching gdb.rocm/runtime-core*.exp, which includes both runtime-core.exp and runtime-core-attached.exp tests. This change enables both core file tests to run consistently in CI.
lumachad
force-pushed
the
users/bfilipov/rocgdb-corefile-gpu-flag
branch
from
September 28, 2026 16:23
27332ab to
5ea0307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rocgdb-corefile test configuration to use the new --gpu-corefile-tests flag instead of manually specifying test files.
The --gpu-corefile-tests flag automatically selects all tests matching gdb.rocm/runtime-core*.exp, which includes both runtime-core.exp and runtime-core-attached.exp tests.
This change enables both core file tests (existing
runtime-core.expandruntime-core-attached.expwhich will soon be merged) to run consistently in CI.