Skip to content

ci: use --gpu-corefile-tests flag for rocgdb-corefile tests - #8563

Merged
lumachad merged 1 commit into
mainfrom
users/bfilipov/rocgdb-corefile-gpu-flag
Sep 29, 2026
Merged

lumachad merged 1 commit into
mainfrom
users/bfilipov/rocgdb-corefile-gpu-flag

Conversation

@amd-bfilipov

Copy link
Copy Markdown
Contributor

Update rocgdb-corefile test configuration to use the new --gpu-corefile-tests flag instead of manually specifying test files.

The --gpu-corefile-tests flag automatically selects all tests matching gdb.rocm/runtime-core*.exp, which includes both runtime-core.exp and runtime-core-attached.exp tests.

This change enables both core file tests (existing runtime-core.exp and runtime-core-attached.exp which will soon be merged) to run consistently in CI.

@therock-pr-bot

therock-pr-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/github_actions/fetch_test_configurations.py; no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Sep 28, 2026
@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@lumachad lumachad added ci:skip Skip all CI builds/tests for this PR and removed ci:skip Skip all CI builds/tests for this PR labels Sep 28, 2026
@lumachad
lumachad self-requested a review September 28, 2026 10:49
@lumachad

Copy link
Copy Markdown
Contributor

Unit tests are failing.

@lumachad lumachad changed the title ci: use --gpu-corefile-tests flag for rocgdb-corefile project ci: use --gpu-corefile-tests flag for rocgdb-corefile tests Sep 28, 2026
Update rocgdb-corefile test configuration to use the new
--gpu-corefile-tests flag instead of manually specifying test files.

The --gpu-corefile-tests flag automatically selects all tests matching
gdb.rocm/runtime-core*.exp, which includes both runtime-core.exp and
runtime-core-attached.exp tests.

This change enables both core file tests to run consistently in CI.
@lumachad
lumachad force-pushed the users/bfilipov/rocgdb-corefile-gpu-flag branch from 27332ab to 5ea0307 Compare September 28, 2026 16:23

@lumachad lumachad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK.

@lumachad
lumachad merged commit 645cb5f into main Sep 29, 2026
180 of 191 checks passed
@lumachad
lumachad deleted the users/bfilipov/rocgdb-corefile-gpu-flag branch September 29, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review PR has unresolved policy failures — reviews blocked

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants