Repository navigation
feat(hipblaslt): Add gfx1250 Origami libraries for NN and NT layouts - #12271
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12271 +/- ##
========================================
Coverage 70.27% 70.27%
========================================
Files 2812 2812
Lines 462318 462318
Branches 68085 68085
========================================
Hits 324891 324891
Misses 113896 113896
Partials 23531 23531
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
left a comment
talumbau
left a comment
There was a problem hiding this comment.
Please hold off merging this PR until we can understand more about this test failures
There are 2 failures from each Math CI precheckin and TheRock CI tests. Math CI failure test is regarding gfx950 HHS_TN which is unrelated to this. |
Thanks for rebasing. For the 18 failing tests on math-ci for gfx950, do you know the mechanism for why they are failing right now? It sounds incredible, but I discovered last year that YAML files for Arch A actually impact the execution path when running on Arch B in hipBLASLt. Therefore, unless you have another contemporary PR showing the exact same failure mode, it's difficult to rule out any given PR. Secondly, if the answer is "this stuff was already failing", the only actual path forward is to stop and figure out why that was failing. Until we know that, it's actually not safe to land further code. |
|
@talumbau I think your comment is based on the previous run, before updating the branch. |
talumbau
left a comment
talumbau
left a comment
There was a problem hiding this comment.
LGTM - thanks for re-running!
feat(hipblaslt): Add gfx1250 Origami libraries for NN and NT layouts (#12271) JIRA ID : AIHPBLAS-4782 ## Motivation Enrich gfx1250 OOB libraries for NN and NT layouts ## Technical Details Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files. ## Test Plan Run `hipblaslt-test` for all cases ## Test Result Passed `hipblaslt-test` for all cases ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. Co-authored-by: Babak Poursartip <babak.poursartip@amd.com>
TheRock Submodule Bump ActivityNewest first
|
…12271) JIRA ID : AIHPBLAS-4782 ## Motivation Enrich gfx1250 OOB libraries for NN and NT layouts ## Technical Details Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files. ## Test Plan Run `hipblaslt-test` for all cases ## Test Result Passed `hipblaslt-test` for all cases ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. Co-authored-by: Babak Poursartip <babak.poursartip@amd.com>
Brings the branch up to date with develop and ports what landed there under the gfx1250v0 name onto gfx1250-strict. Tuning logic. ROCm#12336 and ROCm#12271 replaced 4 gfx1250v0 logic files and added 7 (including a new Origami pair). The 4 are dropped here too. The 7 move to gfx1250-strict/, with ScheduleName and ArchitectureName rewritten the same way d05bf20 did for the rest. Every file in the tree now matches its develop counterpart apart from those two names. Test marks. ROCm#12282 skipped three streamk configs on gfx1250v0, and it and ROCm#12355 dropped xfail-gfx1250 from those and spmm_gate now that they pass. They keep skip-gfx1250-strict and lose the xfail. fused_a2a gained skip-gfx1250 on develop, so it also gets skip-gfx1250-strict, per this branch's convention. findAvailableArchs keeps this branch's version. The develop version made gfx1250v0 inherit base gfx1250 marks. That is the opposite of the mirrored marks here, where a strict config says skip-gfx1250. The four gfx1250v0 tests in test_config_helpers.py are ported to pin the strict behaviour instead, including that a base skip-gfx1250 does not fire on a strict target. ClientWriter. ROCm#12569 added clientLibraryFiles (msgpack master lookup) and routed a stepping through computeOutputArchNames, which this branch removes. It auto-merged into TensileCreateLibrary/__init__.py as an import of a function that no longer exists, so Tensile failed to import. The export is dropped. clientLibraryFiles keeps the msgpack fix but loses the remap, since a stepping is now its own subdir and master suffix. Its stepping test now checks that gfx1250-strict is found by name and that the gfx1250 files next to it are not picked up. Not changed: .github/workflows/gfx1250_hipblaslt_tensilelite_test.yml (ROCm#12164, manual dispatch) still passes --gpu-targets gfx1250v0 and selects with -m "gfx1250 and not skip-gfx1250". It needs porting to gfx1250-strict as a follow-up. Co-authored-by: Cursor <cursoragent@cursor.com>
…12677) Original PR: #12271 Original merge SHA: `1589be74d15a0d886118d0afca4624e8f295473c` JIRA ID : AIHPBLAS-4782 ## Motivation Enrich gfx1250 OOB libraries for NN and NT layouts ## Technical Details Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files. ## Test Plan Run `hipblaslt-test` for all cases ## Test Result Passed `hipblaslt-test` for all cases ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. Co-authored-by: Minsu Kim <minsu.kim@amd.com> Co-authored-by: Babak Poursartip <babak.poursartip@amd.com>
JIRA ID : AIHPBLAS-4782
Motivation
Enrich gfx1250 OOB libraries for NN and NT layouts
Technical Details
Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files.
Test Plan
Run
hipblaslt-testfor all casesTest Result
Passed
hipblaslt-testfor all casesSubmission Checklist