Repository navigation
feat(hipblaslt): Add gfx1250 Origami libraries for NN and NT layouts - #12677
Merged
ScottTodd merged 1 commit intoSep 29, 2026
Conversation
…12271) JIRA ID : AIHPBLAS-4782 ## Motivation Enrich gfx1250 OOB libraries for NN and NT layouts ## Technical Details Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files. ## Test Plan Run `hipblaslt-test` for all cases ## Test Result Passed `hipblaslt-test` for all cases ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. Co-authored-by: Babak Poursartip <babak.poursartip@amd.com> (cherry picked from commit 1589be7)
astyrrian1
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/bkc/therock-10.2-20260922 #12677 +/- ##
====================================================================
Coverage ? 70.75%
====================================================================
Files ? 2849
Lines ? 468199
Branches ? 69164
====================================================================
Hits ? 331243
Misses ? 112960
Partials ? 23996
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
ScottTodd
approved these changes
Sep 29, 2026
Member
There was a problem hiding this comment.
These large binary files should still be moved to DVC or some other storage separate from git (I'm going to keep making the same comment on every hipblaslt/origami PR I review until fixed, large files like this are a continuous cost to all developers and CI)
ScottTodd
marked this pull request as ready for review
September 29, 2026 16:02
ScottTodd
merged commit Sep 29, 2026
201f54b
into
release/bkc/therock-10.2-20260922
263 of 290 checks passed
ScottTodd
deleted the
users/astyrrian1/AIHPBLAS-4782-cherry-pick-12271-bkc-20260922
branch
September 29, 2026 16:03
ScottTodd
added a commit
to ROCm/TheRock
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #12271
Original merge SHA:
1589be74d15a0d886118d0afca4624e8f295473cJIRA ID : AIHPBLAS-4782
Motivation
Enrich gfx1250 OOB libraries for NN and NT layouts
Technical Details
Added ~500 kernels per datatype/layout into gfx1250 liblogic yaml files.
Test Plan
Run
hipblaslt-testfor all casesTest Result
Passed
hipblaslt-testfor all casesSubmission Checklist