Repository navigation
test(tensilelite): Enable gfx1250v0 target marks & cleanup non-gfx1250 tests - #12282
Merged
archana-ramalingam merged 2 commits intoSep 21, 2026
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
archana-ramalingam
requested review from
ThanHenderson,
jaopaulolc and
pdhirajkumarprasad
September 18, 2026 00:04
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12282 +/- ##
===========================================
- Coverage 70.80% 70.80% -0.00%
===========================================
Files 2845 2845
Lines 465630 465630
Branches 68575 68575
===========================================
- Hits 329660 329656 -4
- Misses 112251 112254 +3
- Partials 23719 23720 +1
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
jaopaulolc
approved these changes
Sep 18, 2026
archana-ramalingam
deleted the
users/aramalin/gfx1250-revision-marks
branch
September 21, 2026 21:18
archana-ramalingam
added a commit
that referenced
this pull request
Sep 21, 2026
1 task done
tony-davis
pushed a commit
that referenced
this pull request
Sep 22, 2026
…250 markers to excluded test (#12355) JIRA ID : AIHPBLAS-4510 ## Motivation - On gfx1250 hardware, spmm_gate now passes, so its xfail-gfx1250 marker is stale (XPASS-strict fails). Remove it. - sgemm_streamk_asm.yaml (multi-arch gfx11/gfx12) isn't tagged gfx1250, so the `-m gfx1250` CI suite never collects it — add the marker. - test_config_helpers.py: tag its framework tests into the gfx1250 suite. - Once spmm_gate is un-xfailed, the xfail-fixture tests #12282 pointed at it no longer hold — remove them. ## Technical Details - Remove the xfail-gfx1250 mark from: - Tensile/Tests/common/sparse/gfx1250/spmm_gate.yaml - Add gfx1250 marker to: - sgemm_streamk_asm.yaml - test_config_helpers.py - Drop the 2 tests tied to spmm_gate xfail fixture ## Test Plan - gfx1250 TensileLite common run — the test should pass, not XPASS. ## Test Result - Will be tested via #12164 only after merge. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level Low — test-only: removes a stale xfail marker + fragile fixture-coupled tests, adds collection markers. No runtime/library code touched.
Contributor
TheRock Submodule Bump ActivityNewest first
|
evedovelli
pushed a commit
that referenced
this pull request
Sep 23, 2026
…0 tests (#12282) JIRA ID : AIHPBLAS-4510 ## Motivation - 3 StreamK gfx1250 configs must be skipped only on `gfx1250v0` - Fix #12178's `findAvailableArchs` - strips a version suffix (`gfx1250v0` -> `gfx1250`), so target-specific marks like `skip-gfx1250v0` could never fire. - Skip a gfx950 test. - Add `test_config_helpers.py` tests ## Technical Details - Add `gfx1250v0`, `skip-gfx1250v0` and `xfail-gfx1250v0` markers - Fix `findAvailableArchs` to handle both - `gfx1250v0` & `gfx1250` - Add `skip-gfx1250` to the gfx950 test `fused_a2a` ## Test Plan - 3 new tests in `pytest Tensile/Tests/common/test_config_helpers.py`. ## Test Result - [x] `pytest Tensile/Tests/common/test_config_helpers.py` -> 10 passed (7 existing + 3 new). - [x] FFM tensilelite tests pass ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level - Low - test-selection plumbing + mark changes only; Nightly and FFM paths unaffected.
tony-davis
added a commit
to geotseng-amd/rocm-libraries
that referenced
this pull request
Sep 25, 2026
Brings the branch up to date with develop and ports what landed there under the gfx1250v0 name onto gfx1250-strict. Tuning logic. ROCm#12336 and ROCm#12271 replaced 4 gfx1250v0 logic files and added 7 (including a new Origami pair). The 4 are dropped here too. The 7 move to gfx1250-strict/, with ScheduleName and ArchitectureName rewritten the same way d05bf20 did for the rest. Every file in the tree now matches its develop counterpart apart from those two names. Test marks. ROCm#12282 skipped three streamk configs on gfx1250v0, and it and ROCm#12355 dropped xfail-gfx1250 from those and spmm_gate now that they pass. They keep skip-gfx1250-strict and lose the xfail. fused_a2a gained skip-gfx1250 on develop, so it also gets skip-gfx1250-strict, per this branch's convention. findAvailableArchs keeps this branch's version. The develop version made gfx1250v0 inherit base gfx1250 marks. That is the opposite of the mirrored marks here, where a strict config says skip-gfx1250. The four gfx1250v0 tests in test_config_helpers.py are ported to pin the strict behaviour instead, including that a base skip-gfx1250 does not fire on a strict target. ClientWriter. ROCm#12569 added clientLibraryFiles (msgpack master lookup) and routed a stepping through computeOutputArchNames, which this branch removes. It auto-merged into TensileCreateLibrary/__init__.py as an import of a function that no longer exists, so Tensile failed to import. The export is dropped. clientLibraryFiles keeps the msgpack fix but loses the remap, since a stepping is now its own subdir and master suffix. Its stepping test now checks that gfx1250-strict is found by name and that the gfx1250 files next to it are not picked up. Not changed: .github/workflows/gfx1250_hipblaslt_tensilelite_test.yml (ROCm#12164, manual dispatch) still passes --gpu-targets gfx1250v0 and selects with -m "gfx1250 and not skip-gfx1250". It needs porting to gfx1250-strict as a follow-up. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-4510
Motivation
gfx1250v0findAvailableArchs- strips a version suffix (gfx1250v0->gfx1250), so target-specific marks likeskip-gfx1250v0could never fire.test_config_helpers.pytestsTechnical Details
gfx1250v0,skip-gfx1250v0andxfail-gfx1250v0markersfindAvailableArchsto handle both -gfx1250v0&gfx1250skip-gfx1250to the gfx950 testfused_a2aTest Plan
pytest Tensile/Tests/common/test_config_helpers.py.Test Result
pytest Tensile/Tests/common/test_config_helpers.py-> 10 passed (7 existing + 3 new).Submission Checklist
Risk level