feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes by stanleytsang-amd · Pull Request #10464 · ROCm/rocm-libraries

stanleytsang-amd · 2026-08-06T00:57:03Z

Motivation

It has been decided from management to postpone the inclusion of CCCL 3.0 support.

Technical Details

This PR reverts all commits related to CCCL 3.0. See the list of PRs in the commit list.

Test Plan

Built benchmarks and tests locally to verify nothing was broken. Running CI to get the bigger picture.

Test Result

JIRA ID : ROCM-29174 EXSWSTRHPC-300

… in changelog (#10024)" This reverts commit 4aa01c8.

This reverts commit 1eb022d.

This reverts commit 72b6de5.

This reverts commit 36278dc.

…)" This reverts commit b91a3e7.

therock-pr-bot · 2026-08-06T01:01:40Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-08-06T01:01:41Z

🎉 All checks passed! This PR is ready for review.

codecov · 2026-08-06T02:13:36Z

Codecov Report

❌ Patch coverage is 67.97753% with 57 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ipcub/include/hipcub/backend/rocprim/util_type.hpp	0.00%	28 Missing ⚠️
...clude/hipcub/backend/rocprim/grid/grid_barrier.hpp	71.88%	3 Missing and 6 partials ⚠️
...ckend/rocprim/iterator/discard_output_iterator.hpp	18.18%	9 Missing ⚠️
...hipcub/backend/rocprim/thread/thread_operators.hpp	27.27%	8 Missing ⚠️
...backend/rocprim/device/device_segmented_reduce.hpp	95.00%	1 Missing ⚠️
...lude/hipcub/backend/rocprim/device/device_spmv.hpp	96.67%	0 Missing and 1 partial ⚠️
...pcub/include/hipcub/backend/rocprim/util_macro.hpp	66.67%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #10464      +/-   ##
===========================================
+ Coverage    68.92%   69.00%   +0.07%     
===========================================
  Files         2762     2794      +32     
  Lines       454750   456842    +2092     
  Branches     67080    67401     +321     
===========================================
+ Hits        313420   315202    +1782     
- Misses      118424   118697     +273     
- Partials     22906    22943      +37

Flag	Coverage Δ		*Carryforward flag
TensileLite-CPP	`38.12% <ø> (ø)`		Carriedforward from 9f1dfa2
TensileLite-Unit	`75.90% <ø> (ø)`		Carriedforward from 9f1dfa2
hipBLAS	`90.62% <ø> (ø)`		Carriedforward from 9f1dfa2
hipBLASLt	`34.89% <ø> (ø)`		Carriedforward from 9f1dfa2
hipCUB	`82.68% <67.98%> (-0.79%)`	⬇️
hipDNN	`86.52% <ø> (ø)`		Carriedforward from 9f1dfa2
hipFFT	`49.22% <ø> (ø)`		Carriedforward from 9f1dfa2
hipRAND	`76.12% <ø> (ø)`		Carriedforward from 9f1dfa2
hipSOLVER	`69.03% <ø> (ø)`		Carriedforward from 9f1dfa2
hipSPARSE	`86.27% <ø> (ø)`		Carriedforward from 9f1dfa2
rocBLAS	`48.23% <ø> (ø)`		Carriedforward from 9f1dfa2
rocFFT	`48.26% <ø> (ø)`		Carriedforward from 9f1dfa2
rocRAND	`57.02% <ø> (ø)`		Carriedforward from 9f1dfa2
rocSOLVER	`76.92% <ø> (ø)`		Carriedforward from 9f1dfa2
rocSPARSE	`72.57% <ø> (ø)`		Carriedforward from 9f1dfa2
rocThrust	`91.35% <ø> (-0.25%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...ckend/rocprim/agent/single_pass_scan_operators.hpp	`45.45% <ø> (ø)`
.../hipcub/backend/rocprim/block/block_radix_sort.hpp	`0.00% <ø> (ø)`
...nclude/hipcub/backend/rocprim/block/block_scan.hpp	`0.00% <ø> (ø)`
...kend/rocprim/device/device_adjacent_difference.hpp	`100.00% <ø> (ø)`
...lude/hipcub/backend/rocprim/device/device_copy.hpp	`100.00% <ø> (ø)`
...clude/hipcub/backend/rocprim/device/device_for.hpp	`82.68% <100.00%> (+1.32%)`	⬆️
...hipcub/backend/rocprim/device/device_histogram.hpp	`97.53% <100.00%> (+0.03%)`	⬆️
...de/hipcub/backend/rocprim/device/device_memcpy.hpp	`100.00% <ø> (ø)`
...ude/hipcub/backend/rocprim/device/device_merge.hpp	`100.00% <ø> (ø)`
...ipcub/backend/rocprim/device/device_merge_sort.hpp	`100.00% <ø> (ø)`
... and 62 more

... and 291 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

spolifroni-amd · 2026-08-06T14:20:46Z

PR #10443 updates the rocthrust and hipcub changelogs. Maybe those changes should be brought in here and then we can close that PR?

stanleytsang-amd · 2026-08-06T17:57:15Z

PR #10443 updates the rocthrust and hipcub changelogs. Maybe those changes should be brought in here and then we can close that PR?

Done. I also forgot to add back the previous deprecation notice related to CCCL 3.0 located in Upcoming Changes for the changelog so I put back them in.

stanleytsang-amd · 2026-08-07T15:14:58Z

https://github.com/ROCm/TheRock/actions/runs/31126360736 passed.

amd-jmahovsky

LGTM

feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes (#10464) ## Motivation It has been decided from management to postpone the inclusion of CCCL 3.0 support. ## Technical Details This PR reverts all commits related to CCCL 3.0. See the list of PRs in the commit list. ## Test Plan Built benchmarks and tests locally to verify nothing was broken. Running CI to get the bigger picture. ## Test Result JIRA ID : ROCM-29174 EXSWSTRHPC-300

…into ROCm 10.0 (#10637) ## Motivation Management has decided to revert the CCCL 3.0 changes for ROCm 10.0. This PR does that. ## Technical Details Revert all PRs related to or otherwise depending on the CCCL 3.0 changes by cherry-picking the commit that did so: #10464 ## Test Plan Ran builds and CI checks in original revert PR. ## Test Result Passed ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID: AIRDEL-36

## Motivation Recreated #8534. But rebased due to #10464. See original PR (#8534) for details. JIRA ID : ROCM-27706 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>

feat(hipcub): use primbench ## Motivation Recreated ROCm/rocm-libraries#8534. But rebased due to ROCm/rocm-libraries#10464. See original PR (ROCm/rocm-libraries#8534) for details. JIRA ID : ROCM-27706 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

## Motivation Recreated #8534. But rebased due to #10464. See original PR (#8534) for details. JIRA ID : ROCM-27706 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>

)" This reverts commit cf18605.

## Motivation It has been decided from management to postpone the inclusion of CCCL 3.0 support. ## Technical Details This PR reverts all commits related to CCCL 3.0. See the list of PRs in the commit list. ## Test Plan Built benchmarks and tests locally to verify nothing was broken. Running CI to get the bigger picture. ## Test Result JIRA ID : ROCM-29174 EXSWSTRHPC-300 --------- Co-authored-by: spolifroni-amd <sandra.polifroni@amd.com>

## Motivation Recreated #8534. But rebased due to #10464. See original PR (#8534) for details. JIRA ID : ROCM-27706 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>

)" This reverts commit cf18605.

## Motivation It has been decided from management to postpone the inclusion of CCCL 3.0 support. ## Technical Details This PR reverts all commits related to CCCL 3.0. See the list of PRs in the commit list. ## Test Plan Built benchmarks and tests locally to verify nothing was broken. Running CI to get the bigger picture. ## Test Result JIRA ID : ROCM-29174 EXSWSTRHPC-300 --------- Co-authored-by: spolifroni-amd <sandra.polifroni@amd.com>

## Motivation Recreated ROCm#8534. But rebased due to ROCm#10464. See original PR (ROCm#8534) for details. JIRA ID : ROCM-27706 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Sander Bos <sander@streamhpc.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>

)" This reverts commit cf18605.

stanleytsang-amd and others added 8 commits August 5, 2026 13:07

Revert "doc(rocThrust, hipCUB): Add more notes about CCCL 3.0 support…

72afa64

… in changelog (#10024)" This reverts commit 4aa01c8.

Revert "feat(rocthrust): CCCL 3.0.x changes (#3773)"

7c29435

This reverts commit 1eb022d.

rolling back the changelog entries for cccl 3

c3ac3ce

Revert "feat(hipcub): Add CCCL 3.0.x support (copy) (#9931)"

618b5a4

This reverts commit 72b6de5.

adding updates from the hipcub & rocthrust teams

9a8b18d

Revert "refactor(rocprim): removal of deprecated functions (#3620)"

c0df52c

This reverts commit 36278dc.

Revert "fix(hipcub): drop removed headers from hipCUB and tests (#10120…

15aeb16

…)" This reverts commit b91a3e7.

Fix hipCUB changelog

9f1dfa2

stanleytsang-amd requested review from a team as code owners August 6, 2026 00:57

github-actions Bot added documentation project: hipcub project: rocprim project: rocthrust labels Aug 6, 2026

assistant-librarian Bot added the organization: ROCm label Aug 6, 2026

stanleytsang-amd requested a review from Naraenda August 6, 2026 04:04

Naraenda mentioned this pull request Aug 6, 2026

feat(hipcub): use primbench #8534

Closed

1 task done

Naraenda approved these changes Aug 6, 2026

View reviewed changes

spolifroni-amd approved these changes Aug 6, 2026

View reviewed changes

Merge in changelog changes from #10443

de320a0

spolifroni-amd approved these changes Aug 7, 2026

View reviewed changes

spolifroni-amd mentioned this pull request Aug 7, 2026

docs(rocthrust, hipcub) rollback pytorch info in changelogs #10443

Closed

amd-jmahovsky approved these changes Aug 7, 2026

View reviewed changes

NguyenNhuDi approved these changes Aug 7, 2026

View reviewed changes

stanleytsang-amd merged commit cf18605 into develop Aug 7, 2026
169 of 176 checks passed

stanleytsang-amd deleted the users/stanleytsang-amd/revert-cccl-3.0-changes branch August 7, 2026 19:21

Naraenda mentioned this pull request Aug 10, 2026

DO NOT MERGE: feat(hipcub, rocprim, rocthrust): cccl 3.x parity #10568

Closed

1 task done

stanleytsang-amd mentioned this pull request Aug 11, 2026

feat(hipcub, rocprim, rocthrust) Cherry-pick revert CCCL 3.0 changes into ROCm 10.0 #10637

Merged

1 task

Naraenda mentioned this pull request Aug 13, 2026

feat(hipcub): use primbench #10735

Merged

1 task done

Naraenda added a commit that referenced this pull request Sep 14, 2026

Revert "feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes (#10464

6ce7d51

)" This reverts commit cf18605.

Naraenda added a commit that referenced this pull request Sep 29, 2026

Revert "feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes (#10464

97874e1

)" This reverts commit cf18605.

Naraenda mentioned this pull request Oct 2, 2026

feat(hipccl): cccl 3.x parity #12952

Merged

1 task done

Naraenda added a commit that referenced this pull request Oct 5, 2026

Revert "feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes (#10464

910487e

)" This reverts commit cf18605.

stanleytsang-amd pushed a commit that referenced this pull request Oct 9, 2026

Revert "feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes (#10464

d9b746c

)" This reverts commit cf18605.

Navigation Menu

Repository navigation

feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes - #10464

feat(hipcub, rocprim, rocthrust) Revert CCCL 3.0 changes#10464
stanleytsang-amd merged 9 commits into
developfrom
users/stanleytsang-amd/revert-cccl-3.0-changes

stanleytsang-amd commented Aug 6, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Aug 6, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

spolifroni-amd commented Aug 6, 2026

Uh oh!

stanleytsang-amd commented Aug 6, 2026

Uh oh!

stanleytsang-amd commented Aug 7, 2026

Uh oh!

amd-jmahovsky left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

stanleytsang-amd commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Uh oh!

therock-pr-bot Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Aug 6, 2026

Uh oh!

codecov Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

spolifroni-amd commented Aug 6, 2026

Uh oh!

stanleytsang-amd commented Aug 6, 2026

Uh oh!

stanleytsang-amd commented Aug 7, 2026

Uh oh!

amd-jmahovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stanleytsang-amd commented Aug 6, 2026 •

edited

Loading

therock-pr-bot Bot commented Aug 6, 2026 •

edited

Loading

codecov Bot commented Aug 6, 2026 •

edited

Loading