refactor(rocprim): removal of deprecated functions by Saiyang-Zhang · Pull Request #3620 · ROCm/rocm-libraries

Saiyang-Zhang · 2026-01-05T14:23:04Z

JIRA-ID : EXSWSTRHPC-300

Technical Details

In rocPRIM, the deprecated structures are removed.

In hipCUB, some of the deprecated structures are removed, but for SIMD method structs we need to wait for libhipcxx to provide the substitute.

In rocThrust, the deprecated variable is removed.

In rocRAND, the "deprecated" variables are put in rocrand_device::detail namespace to avoid being exposed public. The namespace is chosen for other files under /rocm-libraries/projects/rocrand/library/include/rocrandlibrary/include/rocrand did the same.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

amd-hsong

Looks good to me - thanks!

umfranzw

This looks good to me, pending the remaining CI checks.

Saiyang-Zhang · 2026-01-08T07:21:46Z

Corrceted formatting according to CI failures.

* GEMM Blockscale ABQuant Optimization * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix precommit error * clean * Fix --------- Co-authored-by: Thomas Ning <Thomas.Ning@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ding, Yi <yi.ding@amd.com>

* GEMM Blockscale ABQuant Optimization * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix precommit error * clean * Fix --------- Co-authored-by: Thomas Ning <Thomas.Ning@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ding, Yi <yi.ding@amd.com> [ROCm/composable_kernel commit: 31a35ec]

This reverts commit 31a35ec.

…duce

Naraenda · 2026-06-29T06:59:42Z

Rebased

therock-pr-bot · 2026-06-29T07:02:49Z

❌ PR Check — Action Required

Check	Status	Details
🌿 Branch Name	✅ Pass	—
📝 PR Title/Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a `JIRA ID` / `ISSUE ID` line (separator `:` or `-`, or omitted; value may be a JIRA key, a number with/without `#`, or a link), OR a closing keyword + issue reference. Accepted examples: • `JIRA ID : TESTAUTO-6039` • `JIRA ID - #330` • `JIRA ID #330` • `JIRA ID` (on separate line) `ROCM-25757` • `ISSUE ID : TESTUTO-3334` • `ISSUE ID #3334` • `ISSUE ID - TESTAUTO-3433` • `ISSUE ID` (on separate line) `AIRUNTIME-2352` • `ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234` • `Closes #10` • `Fixes octo-org/octo-repo#100` • `Resolves: #123` • `#123` • `https://github.com/<org_name>/<repo_name>/issues/123` Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	❌ Fail	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like `test_<name>.py` / `test_<name>.cpp` (or `<name>_test.`). Current:* code file(s) changed: `projects/hipcub/hipcub/include/hipcub/backend/rocprim/iterator/iterator_wrapper.hpp`, `projects/hipcub/hipcub/include/hipcub/backend/rocprim/util_type.hpp`, `projects/rocprim/rocprim/include/rocprim/iterator/zip_iterator.hpp`, `projects/rocprim/rocprim/include/rocprim/type_traits_functions.hpp`, `projects/rocrand/library/include/rocrand/rocrand_scrambled_sobol32_constants.h` (+11 more); no test file found
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 2 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

❌ PR Title/Description

❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

therock-pr-bot · 2026-06-29T07:02:51Z

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

❌ PR Title/Description
❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

…-functions-8-0

Naraenda · 2026-07-20T15:51:45Z

Resolved merge conflict.

umfranzw · 2026-07-21T01:30:40Z

Manually re-triggered CI - will try to get this merged asap.

umfranzw · 2026-07-23T16:50:58Z

Looks like we have a legitimate failure on gfx950:

[ RUN      ] RocprimDeviceSortTests/18.SortKeyValue
/var/jenkins_home/workspace/ibraries_codecov_rocprim_PR-3620/alfNCl6E7/rocprim/projects/rocprim/test/rocprim/test_utils_assertions.hpp:86: Failure
Expected equality of these values:
  val
    Which is: [616; 616; 616; 616]
  expected
    Which is: [617; 617; 617; 617]
where index = 113
Google Test trace:
/var/jenkins_home/workspace/ibraries_codecov_rocprim_PR-3620/alfNCl6E7/rocprim/projects/rocprim/test/rocprim/test_device_merge_sort.cpp:352: with size = 1024
/var/jenkins_home/workspace/ibraries_codecov_rocprim_PR-3620/alfNCl6E7/rocprim/projects/rocprim/test/rocprim/test_device_merge_sort.cpp:348: with seed = 1369133069
/var/jenkins_home/workspace/ibraries_codecov_rocprim_PR-3620/alfNCl6E7/rocprim/projects/rocprim/test/rocprim/test_device_merge_sort.cpp:313: with device_id = 0

umfranzw · 2026-07-23T19:35:24Z

I'm unable to repro the failure, both with and without this PR.

umfranzw · 2026-07-27T20:30:41Z

This appears to be related to the -DBUILD_CODE_COVERAGE=ON option. Working to narrow it down - in the meantime, hopefully we can work around the problem to merge this change.

refactor(rocprim): removal of deprecated functions JIRA-ID : EXSWSTRHPC-300 ## Technical Details In rocPRIM, the deprecated structures are removed. In hipCUB, some of the deprecated structures are removed, but for `SIMD` method structs we need to wait for `libhipcxx` to provide the substitute. In rocThrust, the deprecated variable is removed. In rocRAND, the "deprecated" variables are put in `rocrand_device::detail` namespace to avoid being exposed public. The namespace is chosen for other files under `/rocm-libraries/projects/rocrand/library/include/rocrandlibrary/include/rocrand` did the same. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

(cherry picked from commit c3085498c602286ce1c69affdc55eb2f1287380b)

JIRA-ID : EXSWSTRHPC-300 ## Technical Details In rocPRIM, the deprecated structures are removed. In hipCUB, some of the deprecated structures are removed, but for `SIMD` method structs we need to wait for `libhipcxx` to provide the substitute. In rocThrust, the deprecated variable is removed. In rocRAND, the "deprecated" variables are put in `rocrand_device::detail` namespace to avoid being exposed public. The namespace is chosen for other files under `/rocm-libraries/projects/rocrand/library/include/rocrandlibrary/include/rocrand` did the same. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Nara <nara@streamhpc.com>

Saiyang-Zhang requested review from a team as code owners January 5, 2026 14:23

github-actions Bot added documentation project: hipcub project: rocprim project: rocrand labels Jan 5, 2026

NB4444 added the organization: streamhpc contributors from streamhpc label Jan 5, 2026

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch 2 times, most recently from 0354ed1 to a8a8454 Compare January 6, 2026 07:36

amd-hsong approved these changes Jan 7, 2026

View reviewed changes

umfranzw approved these changes Jan 8, 2026

View reviewed changes

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch from a8a8454 to b785a91 Compare January 8, 2026 07:20

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch from b785a91 to b270466 Compare January 9, 2026 10:01

github-actions Bot added the project: rocthrust label Jan 9, 2026

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch 3 times, most recently from 88da3f7 to f5e384e Compare January 12, 2026 09:44

ErwinTerpstra added a commit that referenced this pull request Feb 9, 2026

Revert "GEMM Blockscale ABQuant Optimization (#3620)"

8f7d6c6

This reverts commit 31a35ec.

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch 4 times, most recently from 62671e1 to 02cf88d Compare February 19, 2026 08:19

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch 3 times, most recently from 3fe68e5 to 8529324 Compare March 2, 2026 09:56

Saiyang-Zhang force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch from 8529324 to 09e0634 Compare March 19, 2026 08:48

Saiyang-Zhang added 9 commits June 29, 2026 08:58

hipCUB safely removed deprecated functions iterator_wrapper thread_re…

9f68883

…duce

rocThrust safely removed deprecated variable

f640c63

rocRAND put 'deprecated' variables in detail namespace

7426d2c

Formatting

3b79c8c

Changelog

16a48a2

Restore things that should be there

17ce152

Formatting

81f2652

Formatting

0ea86b0

copyright-date

dda42fb

Naraenda force-pushed the users/Saiyang-Zhang/removal-of-deprecated-functions-8-0 branch from e152c55 to dda42fb Compare June 29, 2026 06:58

therock-pr-bot Bot added the Not ready to Review label Jun 29, 2026

Naraenda changed the title ~~Removal of deprecated functions 8 0~~ refactor(rocprim): removal of deprecated functions Jun 29, 2026

Merge branch 'develop' into users/Saiyang-Zhang/removal-of-deprecated…

52ae377

…-functions-8-0

umfranzw merged commit 36278dc into ROCm:develop Jul 27, 2026
58 of 71 checks passed

Naraenda mentioned this pull request Sep 14, 2026

DO NOT MERGE: feat(hipcub, rocprim, rocthrust): cccl 3.x parity #10568

Closed

1 task done

stanleytsang-amd pushed a commit that referenced this pull request Sep 18, 2026

Fix typo in index.rst (#3620)

e0df54a

(cherry picked from commit c3085498c602286ce1c69affdc55eb2f1287380b)

Naraenda mentioned this pull request Oct 2, 2026

feat(hipccl): cccl 3.x parity #12952

Merged

1 task done

Navigation Menu

Repository navigation

refactor(rocprim): removal of deprecated functions - #3620

refactor(rocprim): removal of deprecated functions#3620
umfranzw merged 12 commits into
ROCm:developfrom
StreamHPC:users/Saiyang-Zhang/removal-of-deprecated-functions-8-0

Saiyang-Zhang commented Jan 5, 2026 •

edited by Naraenda

Loading

Uh oh!

amd-hsong left a comment

Uh oh!

umfranzw left a comment

Uh oh!

Saiyang-Zhang commented Jan 8, 2026 •

edited

Loading

Uh oh!

Naraenda commented Jun 29, 2026

Uh oh!

therock-pr-bot Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jun 29, 2026

Uh oh!

Naraenda commented Jul 20, 2026

Uh oh!

umfranzw commented Jul 21, 2026

Uh oh!

umfranzw commented Jul 23, 2026

Uh oh!

umfranzw commented Jul 23, 2026

Uh oh!

umfranzw commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Saiyang-Zhang commented Jan 5, 2026 • edited by Naraenda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Technical Details

Submission Checklist

Uh oh!

amd-hsong left a comment

Choose a reason for hiding this comment

Uh oh!

umfranzw left a comment

Choose a reason for hiding this comment

Uh oh!

Saiyang-Zhang commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Naraenda commented Jun 29, 2026

Uh oh!

therock-pr-bot Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ PR Check — Action Required

Uh oh!

therock-pr-bot Bot commented Jun 29, 2026

Uh oh!

Naraenda commented Jul 20, 2026

Uh oh!

umfranzw commented Jul 21, 2026

Uh oh!

umfranzw commented Jul 23, 2026

Uh oh!

umfranzw commented Jul 23, 2026

Uh oh!

umfranzw commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Saiyang-Zhang commented Jan 5, 2026 •

edited by Naraenda

Loading

Saiyang-Zhang commented Jan 8, 2026 •

edited

Loading

therock-pr-bot Bot commented Jun 29, 2026 •

edited

Loading