Repository navigation
build(pytorch): remove release/2.10 from build matrices - #6890
Merged
Merged
Conversation
Drop release/2.10 from CI/release PyTorch ref lists, source manifest defaults, and unsupported-family filters. Mark 2.10 as previously built in docs, remove the 2.10-specific skip-tests file, and bump dev CI workflow defaults to 2.11. Mirrors HereThereBeDragons #6577 (release/2.9 removal).
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This was referenced Jul 27, 2026
ethanwee1
marked this pull request as ready for review
July 27, 2026 18:23
ScottTodd
approved these changes
Jul 27, 2026
ScottTodd
left a comment
ScottTodd
left a comment
Member
There was a problem hiding this comment.
Generally LGTM. A few specific points where I think we shouldn't need to edit so many comments and tests as part of these updates.
Comment on lines
+83
to
+93
| related_commits = "\n".join( | ||
| [ | ||
| "ubuntu|pytorch|torchaudio|release/2.10|" | ||
| "ubuntu|pytorch|torchaudio|release/2.11|" |
Member
There was a problem hiding this comment.
I don't think these unit test changes are needed? We can keep referencing old branches in tests.
Comment on lines
122
to
125
| ("ROCm/pytorch", "version.txt", shas["pytorch"]): "2.10.0\n", | ||
| ("pytorch/audio", "version.txt", shas["audio"]): "2.10.0\n", | ||
| ("pytorch/vision", "version.txt", shas["vision"]): "0.25.0\n", | ||
| ("ROCm/apex", "version.txt", shas["apex"]): "1.10.0\n", |
Member
There was a problem hiding this comment.
If updating the tests, also edit these 2.10.0 values too
Comment on lines
+164
to
+163
| # ubuntu|pytorch|torchaudio|release/2.10|<commit>|https://github.com/pytorch/audio | ||
| # ubuntu|pytorch|torchaudio|release/2.11|<commit>|https://github.com/pytorch/audio |
Member
There was a problem hiding this comment.
This comment also doesn't need to be updated, can keep referring to older branches
Comment on lines
-224
to
226
| # This is/was also failing on gfx942 linux, see the 2.10 skip test file. | ||
| # This is/was also failing on gfx942 linux, see the 2.11 skip test file. | ||
| # AssertionError: "Simulate error" does not match "grad can be implicitly created only for scalar outputs" | ||
| "test_reentrant_parent_error_on_cpu_cuda", |
Member
There was a problem hiding this comment.
Stale comment, reword it? We shouldn't need to keep updating this comment whenever we change which versions we build.
marbre
approved these changes
Jul 27, 2026
Per ScottTodd's review: revert the source-manifest unit test changes and the related_commits example comment (tests/comments can keep referencing older branches), and reword the stale gfx942 skip-test comment so it is not tied to a specific release.
Resolve conflict in configure_pytorch_release_matrix.py by dropping the release/2.10 entry from UNSUPPORTED_AMDGPU_FAMILIES (this PR removes 2.10).
1 task done
ScottTodd
added a commit
that referenced
this pull request
Aug 5, 2026
…#7131) ## Motivation * This compliments / supersedes #7027 * Fixes #6965 This fixes `import torch` errors which started after switching to the new torch scikit_build_core build system: ``` OSError: [WinError 126] The specified module could not be found. Error loading ".../torch/lib/torch_hip.dll" or one of its dependencies. ``` ## Technical Details We traced this to Windows builds missing `aotriton_v2.dll` and `liblzma.dll` but this was missed in local testing since flash attention was still disabled by default on Windows (yet enabled on our CI). Some related refactors/cleanups are included here: * Centralize flag validation and directory existence checks for all project build options (previously they would assert late) * Merge `--enable-pytorch-flash-attention-windows` and `--enable-pytorch-flash-attention-linux` flags and handling * Drop support for torch <=2.10 following #6890 ## Test Plan * Local Windows build with `python build_prod_wheels.py build --pytorch-dir D:/b/pytorch --pytorch-rocm-arch=gfx1100` (aotriton _enabled_) * Local Windows build with `python build_prod_wheels.py build --pytorch-dir D:/b/pytorch --pytorch-rocm-arch=gfx906` (aotriton _disabled_) * CI will test that PyTorch release branches (e.g. `release/2.12`) still build * Manually triggered Linux/Windows builds of PyTorch `release/2.12` (old build system) and `nightly` (new build system) * Linux gfx942, `release/2.12`: https://github.com/ROCm/TheRock/actions/runs/31036158083 * Linux gfx942, `nightly`: https://github.com/ROCm/TheRock/actions/runs/31036391496 * Windows gfx110X, `release/2.12`: https://github.com/ROCm/TheRock/actions/runs/31036487964 * Windows gfx110X, `nightly`: https://github.com/ROCm/TheRock/actions/runs/31036530875 * Windows gfx906, `nightly`: https://github.com/ROCm/TheRock/actions/runs/31037859358 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIPYTORCH-901
Removes PyTorch
release/2.10from the build matrices now that it is no longerpart of the 7.14 release lineup, aligning TheRock with the current supported set
(
release/2.11,2.12,2.13).Changes:
release/2.10fromconfigure_pytorch_release_matrix.pyand the Linux/Windowsmulti-arch PyTorch wheel workflows.
skip_tests/pytorch_2.10.pyskip list and its references.RELEASES.md,external-builds/pytorch/README.md, the source manifest,the workflow summarizer, and the affected unit tests accordingly.