Update comment regarding barrier gfx908 hack #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
force-pushed
the
1606-upstream-addition-of-barrier-guard-when-scheduling
branch
from
3e78424 to
49421ea
Compare
manupak
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
===========================================
- Coverage 83.69% 77.94% -5.76%
===========================================
Files 97 97
Lines 26445 26445
Branches 3796 3796
===========================================
- Hits 22134 20613 -1521
- Misses 4276 4312 +36
- Partials 35 1520 +1485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhernandez0
deleted the
1606-upstream-addition-of-barrier-guard-when-scheduling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In llvm/llvm-project#109678 we learned this is caused by a backend bug: llvm/llvm-project#109294
Therefore, we can remove the scheduling barrier when that bug is fixed. Here I'm updating the comment with a TODO.