Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment regarding barrier gfx908 hack #1661

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update comment regarding barrier gfx908 hack #1661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions external/llvm-project/mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,8 @@ struct LDSBarrierOpLowering : public ConvertOpToLLVMPattern<LDSBarrierOp> {
auto asmDialectAttr = LLVM::AsmDialectAttr::get(rewriter.getContext(),
LLVM::AsmDialect::AD_ATT);
Location loc = op->getLoc();
// Ensure the inlineAsm is guarded with a scheduling region
// So it will not interfere with backend compilation more than
// it needs.
// TODO: Revert scheduling region when
// https://github.com/llvm/llvm-project/issues/109294 is fixed
rewriter.create<amdgpu::SchedBarrierOp>(
loc, amdgpu::sched_barrier_opt_enum::none);
const char *asmStr =
Expand Down
Loading