Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes support for FP8 data types on MI35x hardware by adding the torch.float8_e4m3fn data type mapping to the paged attention ROCm implementation.
- Adds support for
torch.float8_e4m3fndata type in the type mapping dictionary
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
csrc/cpp_itfs/pa/pa.py
Outdated
| torch.bfloat16: "__hip_bfloat16", | ||
| torch.float16: "_Float16", | ||
| torch.float8_e4m3fnuz: "uint8_t", | ||
| torch.float8_e4m3fn: "uint8_t" |
There was a problem hiding this comment.
Missing comma after the dictionary entry. This could cause syntax errors or unexpected behavior when additional entries are added later.
Suggested change
| torch.float8_e4m3fn: "uint8_t" | |
| torch.float8_e4m3fn: "uint8_t", |
Collaborator
|
fixed in #1159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist