Skip to content

fix pa fp8 on mi35x #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsx950223 wants to merge 3 commits into from
Closed

fix pa fp8 on mi35x #1173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c25fb
fix pa fp8 on mi35x
Oct 13, 2025
b8501f5
format
Oct 13, 2025
553c985
Merge branch 'main' into pa_mi35x
fsx950223 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csrc/cpp_itfs/pa/pa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def paged_attention_rocm(
torch.bfloat16: "__hip_bfloat16",
torch.float16: "_Float16",
torch.float8_e4m3fnuz: "uint8_t",
torch.float8_e4m3fn: "uint8_t"

Copilot AI Oct 13, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma after the dictionary entry. This could cause syntax errors or unexpected behavior when additional entries are added later.

Suggested change
torch.float8_e4m3fn: "uint8_t"
torch.float8_e4m3fn: "uint8_t",

Copilot uses AI. Check for mistakes.
}

warpSize = torch.cuda.get_device_properties(out.device).warp_size
Expand Down
Loading