Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to eliminate automatic hipification of CUDA code by setting the default hipify parameter to False. The changes primarily involve replacing CUDA-specific headers and API calls with their HIP equivalents throughout the codebase, ensuring native HIP compatibility without relying on runtime code translation.
Key changes:
- Changed default hipify behavior from
TruetoFalsein JIT compilation - Replaced CUDA headers (
ATen/cuda/*,c10/cuda/*) with HIP equivalents (ATen/hip/*) - Updated CUDA stream and device guard APIs to use HIP-native implementations
- Replaced
cudaStream_tandcudaEvent_ttypes withhipStream_tandhipEvent_t
Reviewed Changes
Copilot reviewed 67 out of 67 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| aiter/jit/core.py | Changed default hipify parameter from True to False |
| gradlib/include/*.cuh | Replaced CUDA headers with HIP headers, updated copyright years |
| gradlib/csrc/*.cu | Updated stream/event types from cuda to hip, replaced headers |
| csrc/py_itfs_cu/*.cu | Replaced CUDA context/guard with HIP equivalents, updated stream getters |
| csrc/py_itfs_ck/*.cu | Replaced CUDA headers with HIP headers, updated stream API calls |
| csrc/kernels/*.cu | Updated include guards, stream types, and API calls to HIP |
| csrc/include/.h/.cuh | Replaced CUDA headers with HIP equivalents in header files |
| csrc/ck_gemm_/.cuh | Updated CK GEMM implementations to use HIP stream APIs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 72 out of 72 changed files in this pull request and generated 8 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* not do hipify by default * more * fix more * fix * update * update * update * fix more * fix --------- Co-authored-by: Xin Huang <Xin.Huang@amd.com>
* not do hipify by default * more * fix more * fix * update * update * update * fix more * fix --------- Co-authored-by: Xin Huang <Xin.Huang@amd.com>
* not do hipify by default * more * fix more * fix * update * update * update * fix more * fix --------- Co-authored-by: Xin Huang <Xin.Huang@amd.com>
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist