Skip to content

not do hipify by default#1159

Merged
valarLip merged 12 commits intomainfrom
remove_hipify
Oct 13, 2025
Merged

not do hipify by default#1159
valarLip merged 12 commits intomainfrom
remove_hipify

Conversation

@valarLip
Copy link
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings October 10, 2025 16:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to eliminate automatic hipification of CUDA code by setting the default hipify parameter to False. The changes primarily involve replacing CUDA-specific headers and API calls with their HIP equivalents throughout the codebase, ensuring native HIP compatibility without relying on runtime code translation.

Key changes:

  • Changed default hipify behavior from True to False in JIT compilation
  • Replaced CUDA headers (ATen/cuda/*, c10/cuda/*) with HIP equivalents (ATen/hip/*)
  • Updated CUDA stream and device guard APIs to use HIP-native implementations
  • Replaced cudaStream_t and cudaEvent_t types with hipStream_t and hipEvent_t

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
aiter/jit/core.py Changed default hipify parameter from True to False
gradlib/include/*.cuh Replaced CUDA headers with HIP headers, updated copyright years
gradlib/csrc/*.cu Updated stream/event types from cuda to hip, replaced headers
csrc/py_itfs_cu/*.cu Replaced CUDA context/guard with HIP equivalents, updated stream getters
csrc/py_itfs_ck/*.cu Replaced CUDA headers with HIP headers, updated stream API calls
csrc/kernels/*.cu Updated include guards, stream types, and API calls to HIP
csrc/include/.h/.cuh Replaced CUDA headers with HIP equivalents in header files
csrc/ck_gemm_/.cuh Updated CK GEMM implementations to use HIP stream APIs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@valarLip valarLip requested a review from Copilot October 11, 2025 05:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 72 out of 72 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@valarLip valarLip self-assigned this Oct 11, 2025
@valarLip valarLip merged commit f794ae4 into main Oct 13, 2025
10 of 16 checks passed
@valarLip valarLip deleted the remove_hipify branch October 13, 2025 13:19
@valarLip valarLip mentioned this pull request Oct 13, 2025
1 task
eliotwang pushed a commit to eliotwang/aiter that referenced this pull request Oct 21, 2025
* not do hipify by default

* more

* fix more

* fix

* update

* update

* update

* fix more

* fix

---------

Co-authored-by: Xin Huang <Xin.Huang@amd.com>
valarLip added a commit that referenced this pull request Mar 18, 2026
* not do hipify by default

* more

* fix more

* fix

* update

* update

* update

* fix more

* fix

---------

Co-authored-by: Xin Huang <Xin.Huang@amd.com>
valarLip added a commit that referenced this pull request Mar 18, 2026
* not do hipify by default

* more

* fix more

* fix

* update

* update

* update

* fix more

* fix

---------

Co-authored-by: Xin Huang <Xin.Huang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants