drop redundant includes for ck_gemm folders in setup.py#1435
Closed
drop redundant includes for ck_gemm folders in setup.py#1435
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/ROCm/aiter/pull/830/files/b79c6d3eeaf4588ad495a5c48b0d35ef9ec3ed58 explicitly copies the headers from the ck gemm include folders e.g.
aiter/csrc/ck_batched_gemm_a8w8/includeinto{prebuild_dir}/include.However, #1159 added the corresponding include directories for each module into the
extra_includefield in optCompilerConfig.json, so we don't actually need the redundant copy; the folders are already included in the final build as part ofprebuild_link_param["extras_include"]here.Mildly relevant copilot comment: #1423 (comment)
Technical Details
Test Plan
Test Result
Submission Checklist