Repository navigation
ci(miopen-dbsync): make gfx950 blocking - #9768
Conversation
Drop the gfx950 expect_failure exemption on miopen-dbsync (ALMIOPEN-2674); gfx950 now blocks like gfx942.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
ScottTodd
left a comment
There was a problem hiding this comment.
Can you link to a few workflow runs where the job is successful? The PR description is pretty long but I don't see that detail in there.
|
@ScottTodd Sure. Here are a few gfx950 PRs touching
Scheduled nightlies (comprehensive tier):
For the full picture: from 2026-11-03 18:58 UTC to 2026-11-05 15:33 UTC there were 85 completed gfx950 |
JIRA ID: ALMIOPEN-2674
Motivation
miopen-dbsyncongfx950-dcgpuwas re-added as advisory (#8813,expect_failure) so a regression during re-qualification would not block unrelated PRs. ALMIOPEN-2674 asks to drop that exemption once the job has proven reliable. It has: no gfx950 failures in any run since it began running on PRs and nightlies.Technical Details
expect_failure: {"linux": ["gfx950"]}declaration (and itsTODO(ALMIOPEN-2674)) from themiopen-dbsyncentry infetch_test_configurations.py, and the comment that referred to it.expect_failureplumbing and its other users (WSL entries) are unchanged.expect_failuredeclared; the scheduled job is not xfail).test_miopen_dbsync_gfx942_stays_blockingreads the flag with.get, since no job in this entry declares it any more.Because the key is no longer emitted,
test_component.ymlseesexpect_failureas absent, which evaluates as not-xfail, and the job name loses its(xfail)suffix.Test Plan
python -m unittest tests.fetch_test_configurations_test.fetch_test_configurations.pyforgfx94X-dcgpuandgfx950-dcgpuatstandardand confirmmiopen-dbsyncis requested on the CPU runner with noexpect_failure.Test Result
TEST_TYPE=standard:miopen-dbsyncis requested for bothgfx94X-dcgpuandgfx950-dcgpuon the CPU runner (aws-linux-scale-rocm-prod).Evidence that gfx950 is reliable
Scan of rocm-libraries Multi-Arch CI runs created 2026-11-03 18:58 UTC to 2026-11-05 15:33 UTC (since the pin picked up the
miopen->miopen-dbsyncselection), plus the Multi-Arch Nightly runs:miopen-dbsyncjobsprojects/miopen(15 PRs)developpushescontinue-on-error. I checked all 85 completed gfx950 jobs: each log hasStaticFDBSync gfx950 @ 256 CUand[ PASSED ] 1 test, no[ FAILED ]line and no failed step.comprehensive) with a gfx950 dbsync job: 10-24 through 11-05, all green. gfx950 also passed in a 10-22 dispatch. The 10-23 nightly was cancelled before tests.Risk Assessment
Risk Level: Low-Medium. CI selection only, but it makes a previously advisory job blocking. After this lands and rocm-libraries bumps its pin, a gfx950 dbsync failure turns the Multi-Arch CI Summary red on MIOpen PRs (and on PRs of projects that select
miopen). The job runs on the CPU runner pool under a pinned rocjitsu, so a rocjitsu or runner-image regression would now block merges. PR-side history is about two days; the nightly series is about two weeks.