Skip to content

ci(miopen-dbsync): make gfx950 blocking #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanLichtnerAMD merged 1 commit into from
Nov 6, 2026
Merged

ci(miopen-dbsync): make gfx950 blocking #9768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions build_tools/github_actions/fetch_test_configurations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,7 @@ def _family_matches(
# list from AMDGPU_FAMILIES, sparse-builds the pinned rocjitsu KMD, and runs StaticFDBSync once
# per CU with a CU-corrected config. include_family restricts it to the arches rocjitsu has a
# KMD config for: gfx942, whose FAMILY_MAP entry covers both CU variants -- MI300X (304 CU) and
# MI300A (228 CU) -- in a single job, and gfx950 (MI355X, 256 CU; advisory, see
# expect_failure below).
# MI300A (228 CU) -- in a single job, and gfx950 (MI355X, 256 CU).
# linux_cpu_runner: no scarce GPU test runner needed; uses the default no_rocm Ubuntu container
# (the runner sudo-apt-installs cmake/build-essential/libdrm-dev to build rocjitsu).
"miopen-dbsync": {
Expand All @@ -829,11 +828,6 @@ def _family_matches(
"include_family": {
"linux": ["gfx942", "gfx950"],
},
# TODO(ALMIOPEN-2674): drop this once gfx950 dbsync has been green for a
# few consecutive standard/comprehensive/full runs.
"expect_failure": {
"linux": ["gfx950"],
},
"total_shards_dict": {
"linux": 1,
},
Expand Down
12 changes: 6 additions & 6 deletions build_tools/github_actions/tests/fetch_test_configurations_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,25 +489,25 @@ def test_miopen_dbsync_include_family_covers_gfx942_and_gfx950(self):
config = fetch_test_configurations.test_matrix["miopen-dbsync"]
self.assertEqual(config["include_family"]["linux"], ["gfx942", "gfx950"])

def test_miopen_dbsync_declares_gfx950_advisory(self):
# The matrix entry itself says gfx950 is advisory -- no conditional elsewhere.
def test_miopen_dbsync_declares_no_advisory_families(self):
config = fetch_test_configurations.test_matrix["miopen-dbsync"]
self.assertEqual(config["expect_failure"]["linux"], ["gfx950"])
self.assertNotIn("expect_failure", config)

def test_miopen_dbsync_gfx950_scheduled_on_cpu_runner_when_gpu_gated(self):
job = self._dbsync_job("gfx950-dcgpu", True, "gfx950")
self.assertIsNotNone(job)
self.assertTrue(job["linux_cpu_runner"])
self.assertTrue(job["test_runner"])

def test_miopen_dbsync_gfx950_is_advisory(self):
def test_miopen_dbsync_gfx950_is_blocking(self):
job = self._dbsync_job("gfx950-dcgpu", True, "gfx950")
self.assertTrue(job["expect_failure"])
self.assertIsNotNone(job)
self.assertFalse(job.get("expect_failure"))

def test_miopen_dbsync_gfx942_stays_blocking(self):
job = self._dbsync_job("gfx94X-dcgpu", False, "gfx942")
self.assertIsNotNone(job)
self.assertFalse(job["expect_failure"])
self.assertFalse(job.get("expect_failure"))

def test_miopen_dbsync_excluded_on_other_families(self):
self.assertIsNone(self._dbsync_job("gfx120X-all", False, "gfx1200"))
Expand Down
Loading