Repository navigation
fix(ci): select miopen-dbsync when miopen is selected - #9451
Merged
JonathanLichtnerAMD merged 2 commits intoOct 27, 2026
Merged
Conversation
Add a miopen -> [miopen, miopen-dbsync] entry to _CI_TEST_SELECTOR_ALIASES.
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
JonathanLichtnerAMD
marked this pull request as draft
October 23, 2026 01:49
This was referenced Oct 23, 2026
JonathanLichtnerAMD
marked this pull request as ready for review
October 23, 2026 20:03
geomin12
approved these changes
Oct 26, 2026
geomin12
left a comment
Contributor
There was a problem hiding this comment.
lgtm but a review from @endurthiabhilash will be great too
JonathanLichtnerAMD
deleted the
users/jlichtne/miopen-dbsync-selector-alias
branch
October 27, 2026 14:19
This was referenced Oct 30, 2026
ci: bump TheRock pin to 920d638f and baseline run 41099356536 (2026-10-30)
ROCm/rocm-libraries#14767
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: ALMIOPEN-3021
Motivation
miopen-dbsync(GPU-free rocjitsu StaticFDBSync, #8813 added gfx950 as advisory) is never scheduled for PR-style runs. A rocm-libraries PR touchingprojects/miopenselectsprojects_to_test=hipdnn-integration-tests,hipdnn-samples,miopen,miopenproviderattest_type=standard;fetch_test_configurations.pyonly schedules a job whose key is in that list (or*), somiopen-dbsynconly runs in nightlies (*) or manual dispatch.Verified on a throwaway rocm-libraries PR against TheRock
b0958085: the gfx94X "Configure test matrix" log requested sanity, miopen, hipdnn-integration-tests, hipdnn-samples, miopenprovider and nomiopen-dbsync.Technical Details
Add
"miopen": ["miopen", "miopen-dbsync"]to_CI_TEST_SELECTOR_ALIASESintest_tools/determine_rocm_test_dependencies.py(same pattern astensilelite->tensilelite-common).miopenstays selected;miopen-dbsyncis added whenevermiopenis in the result. The job still self-limits to standard/comprehensive/full tiers, gfx942 (blocking) and gfx950 (xfail) on the CPU runner, so quick-tier and other families are unchanged.This is the same alias #8990 adds, but #8990 merged into the stacked branch of #8757 and so is not on
main; this PR does not depend on #8757. If #8757 lands later it should carry the same alias (its reachability guard already requires it).Test Plan
test_cli_selects_miopen_dbsync_with_miopen:--changed-projects miopenoutputs exactly{miopen, miopen-dbsync}.Test Result
cd test_tools && python3 -m unittest tests.determine_rocm_test_dependencies_test: 75 tests OK (74 before).build_tools/github_actions/tests/fetch_test_configurations_test.py: passes unchanged.determine_rocm_test_dependencies.py --changed-projects projects/miopen --gha-outputnow emitshipdnn-integration-tests,hipdnn-samples,miopen,miopen-dbsync,miopenprovider.fetch_test_configurations.py --platform=linuxatTEST_TYPE=standardrequestsmiopen-dbsyncon the CPU runner for both gfx94X-dcgpu and gfx950-dcgpu; atquickit logsExcluding job miopen-dbsyncfor both.2104ff3cand touched aprojects/miopensource file.2104ff3cwas this change plus a prototype that treats.github/actions/ci-env/*as a workflow change inconfigure_external_repo_ci.py. That prototype is NOT part of this PR. It was needed only because a pin bump editsci-env/action.yml, which otherwise forces run-all at quick tier, wheremiopen-dbsyncis skipped by design. Run: https://github.com/ROCm/rocm-libraries/actions/runs/39985392063Test miopen-dbsync (gfx94X-dcgpu): passed. StaticFDBSync gfx942 @ 304 CU and @ 228 CU, each[ PASSED ] 1 test.Test miopen-dbsync (gfx950-dcgpu) (xfail): passed. StaticFDBSync gfx950 @ 256 CU,[ PASSED ] 1 test.aws-linux-scale-rocm-prod; the gfx94X "Configure test matrix" log showedTEST_TYPE: standardandRequesting job miopen-dbsync.label_consistency_test(module did not import in my environment, before or after this change), pre-commit.Risk Assessment
Risk Level: Low. CI selection only; adds one job to MIOpen-touching PR runs, CPU runner, gfx950 non-blocking.