Skip to content

fix(ci): select miopen-dbsync when miopen is selected - #9451

Merged
JonathanLichtnerAMD merged 2 commits into
mainfrom
users/jlichtne/miopen-dbsync-selector-alias
Oct 27, 2026
Merged

JonathanLichtnerAMD merged 2 commits into
mainfrom
users/jlichtne/miopen-dbsync-selector-alias

Conversation

@JonathanLichtnerAMD

@JonathanLichtnerAMD JonathanLichtnerAMD commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID: ALMIOPEN-3021

Motivation

miopen-dbsync (GPU-free rocjitsu StaticFDBSync, #8813 added gfx950 as advisory) is never scheduled for PR-style runs. A rocm-libraries PR touching projects/miopen selects projects_to_test=hipdnn-integration-tests,hipdnn-samples,miopen,miopenprovider at test_type=standard; fetch_test_configurations.py only schedules a job whose key is in that list (or *), so miopen-dbsync only runs in nightlies (*) or manual dispatch.

Verified on a throwaway rocm-libraries PR against TheRock b0958085: the gfx94X "Configure test matrix" log requested sanity, miopen, hipdnn-integration-tests, hipdnn-samples, miopenprovider and no miopen-dbsync.

Technical Details

Add "miopen": ["miopen", "miopen-dbsync"] to _CI_TEST_SELECTOR_ALIASES in test_tools/determine_rocm_test_dependencies.py (same pattern as tensilelite -> tensilelite-common). miopen stays selected; miopen-dbsync is added whenever miopen is in the result. The job still self-limits to standard/comprehensive/full tiers, gfx942 (blocking) and gfx950 (xfail) on the CPU runner, so quick-tier and other families are unchanged.

This is the same alias #8990 adds, but #8990 merged into the stacked branch of #8757 and so is not on main; this PR does not depend on #8757. If #8757 lands later it should carry the same alias (its reachability guard already requires it).

Test Plan

  • Unit test test_cli_selects_miopen_dbsync_with_miopen: --changed-projects miopen outputs exactly {miopen, miopen-dbsync}.
  • Run the real selection scripts locally for gfx94X-dcgpu and gfx950-dcgpu at standard and quick tiers.
  • End to end in rocm-libraries CI: a PR pinned to a TheRock commit containing this change, with a MIOpen source change.

Test Result

  • cd test_tools && python3 -m unittest tests.determine_rocm_test_dependencies_test: 75 tests OK (74 before).
  • build_tools/github_actions/tests/fetch_test_configurations_test.py: passes unchanged.
  • Local scripts: determine_rocm_test_dependencies.py --changed-projects projects/miopen --gha-output now emits hipdnn-integration-tests,hipdnn-samples,miopen,miopen-dbsync,miopenprovider. fetch_test_configurations.py --platform=linux at TEST_TYPE=standard requests miopen-dbsync on the CPU runner for both gfx94X-dcgpu and gfx950-dcgpu; at quick it logs Excluding job miopen-dbsync for both.
  • End to end: throwaway rocm-libraries PR #14288 (closed) pinned TheRock to 2104ff3c and touched a projects/miopen source file. 2104ff3c was this change plus a prototype that treats .github/actions/ci-env/* as a workflow change in configure_external_repo_ci.py. That prototype is NOT part of this PR. It was needed only because a pin bump edits ci-env/action.yml, which otherwise forces run-all at quick tier, where miopen-dbsync is skipped by design. Run: https://github.com/ROCm/rocm-libraries/actions/runs/39985392063
    • Test miopen-dbsync (gfx94X-dcgpu): passed. StaticFDBSync gfx942 @ 304 CU and @ 228 CU, each [ PASSED ] 1 test.
    • Test miopen-dbsync (gfx950-dcgpu) (xfail): passed. StaticFDBSync gfx950 @ 256 CU, [ PASSED ] 1 test.
    • Both ran on the CPU runner aws-linux-scale-rocm-prod; the gfx94X "Configure test matrix" log showed TEST_TYPE: standard and Requesting job miopen-dbsync.
    • Other jobs in that run were not waited on; the run was cancelled after the dbsync jobs finished.
  • Not run: label_consistency_test (module did not import in my environment, before or after this change), pre-commit.

Risk Assessment

Risk Level: Low. CI selection only; adds one job to MIOpen-touching PR runs, CPU runner, gfx950 non-blocking.

Add a miopen -> [miopen, miopen-dbsync] entry to _CI_TEST_SELECTOR_ALIASES.
@therock-pr-bot

therock-pr-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@JonathanLichtnerAMD
JonathanLichtnerAMD marked this pull request as draft October 23, 2026 01:49

@geomin12 geomin12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but a review from @endurthiabhilash will be great too

@endurthiabhilash endurthiabhilash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanLichtnerAMD
JonathanLichtnerAMD merged commit f43f523 into main Oct 27, 2026
108 of 114 checks passed
@JonathanLichtnerAMD
JonathanLichtnerAMD deleted the users/jlichtne/miopen-dbsync-selector-alias branch October 27, 2026 14:19
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants