Skip to content

build(pytorch): remove release/2.10 from build matrices #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanwee1 merged 3 commits into from
Jul 28, 2026
+20 −171
Merged

build(pytorch): remove release/2.10 from build matrices #6890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dbc806
build(pytorch): remove release/2.10 from build matrices
ethanwee1 Jul 27, 2026
09f2e8f
build(pytorch): address review comments
ethanwee1 Jul 28, 2026
181b7e6
Merge branch 'main' into users/ethanwee/remove-pytorch-2.10
ethanwee1 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/multi_arch_build_portable_linux_pytorch_wheels_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ on:
pytorch_git_ref:
description: PyTorch ref to checkout (typically "release/X.Y")
type: string
default: "release/2.10"
default: "release/2.11"
rocm_package_find_links_url:
description: URL for pip --find-links to install ROCm packages (flat page; use this OR rocm_package_index_url)
type: string
Expand Down Expand Up @@ -81,7 +81,7 @@ on:
pytorch_git_ref:
description: PyTorch ref to checkout (typically "release/X.Y")
type: string
default: "release/2.10"
default: "release/2.11"
rocm_package_find_links_url:
description: URL for pip --find-links to install ROCm packages (flat page; use this OR rocm_package_index_url)
type: string
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/multi_arch_build_windows_pytorch_wheels_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
pytorch_git_ref:
description: PyTorch ref to checkout (typically "release/X.Y")
type: string
default: "release/2.10"
default: "release/2.11"
rocm_package_find_links_url:
description: URL for pip --find-links to install ROCm packages (flat page; use this OR rocm_package_index_url)
type: string
Expand Down Expand Up @@ -80,7 +80,7 @@ on:
pytorch_git_ref:
description: PyTorch ref to checkout (typically "release/X.Y")
type: string
default: "release/2.10"
default: "release/2.11"
rocm_package_find_links_url:
description: URL for pip --find-links to install ROCm packages (flat page; use this OR rocm_package_index_url)
type: string
Expand Down
1 change: 0 additions & 1 deletion RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ Select your GPU target using the `[device-*]` extras from the
> | 2.13 | 2.11 | 0.28 | 1.13 |
> | 2.12 | 2.11 | 0.27 | 1.12 |
> | 2.11 | 2.11 | 0.26 | 1.11 |
> | 2.10 | 2.10 | 0.25 | 1.10 |
>
> For example, `torch` 2.11 and compatible wheels can be installed by specifying
>
Expand Down
10 changes: 2 additions & 8 deletions build_tools/github_actions/configure_pytorch_release_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,11 @@
# this set with additional refs (see RELEASE_PYTORCH_REFS).
RELEASE_STABLE_PYTORCH_REFS = {
"linux": [
"release/2.10",
"release/2.11",
"release/2.12",
"release/2.13",
],
"windows": [
"release/2.10",
"release/2.11",
"release/2.12",
"release/2.13",
Expand All @@ -50,17 +48,14 @@
}

CI_PYTORCH_REFS = {
"linux": ["release/2.10", "release/2.11", "release/2.12", "release/2.13"],
"windows": ["release/2.10"],
"linux": ["release/2.11", "release/2.12", "release/2.13"],
"windows": ["release/2.11"],
}

# Unknown explicit refs are left unfiltered so bring-up branches can opt into
# new GPU families before the default PyTorch refs support them.
UNSUPPORTED_AMDGPU_FAMILIES = {
"linux": {
# gfx125x not supported for PyTorch 2.10.
# gfx90c only supported in PyTorch 2.12+.
"release/2.10": {"gfx125X-dcgpu", "gfx90c"},
# gfx125x supported for PyTorch 2.11 via https://github.com/ROCm/pytorch/pull/3346.
# gfx90c only supported in PyTorch 2.12+.
"release/2.11": {"gfx90c"},
Expand All @@ -74,7 +69,6 @@
"nightly": {"gfx90c"},
},
"windows": {
"release/2.10": {"gfx90c"},
"release/2.11": {"gfx90c"},
"release/2.12": {"gfx90c"},
"release/2.13": {"gfx90c"},
Expand Down
1 change: 0 additions & 1 deletion build_tools/github_actions/generate_pytorch_source_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
)

DEFAULT_PYTORCH_GIT_REFS = [
"release/2.10",
"release/2.11",
"release/2.12",
"release/2.13",
Expand Down
2 changes: 1 addition & 1 deletion build_tools/github_actions/summarize_test_pytorch_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
The script can be tested locally with inputs like this:

python ./build_tools/github_actions/summarize_test_pytorch_workflow.py \
--pytorch-git-ref=release/2.10 \
--pytorch-git-ref=release/2.11 \
--index-url=https://rocm.nightlies.amd.com/whl-multi-arch/ \
--device-extras=device-gfx942 \
--torch-version=2.10.0+rocm7.12.0a20260501
Expand Down
7 changes: 1 addition & 6 deletions build_tools/github_actions/tests/configure_multi_arch_ci_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,11 +1120,6 @@ def test_build_config_includes_pytorch_build_matrix(self):
self.assertEqual(
result.linux.pytorch_build_matrix,
[
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.10",
"amdgpu_families": "gfx94X-dcgpu",
},
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.11",
Expand All @@ -1147,7 +1142,7 @@ def test_build_config_includes_pytorch_build_matrix(self):
[
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.10",
"pytorch_git_ref": "release/2.11",
"amdgpu_families": "gfx110X-all",
}
],
Expand Down
11 changes: 3 additions & 8 deletions build_tools/github_actions/tests/configure_pytorch_release_matrix_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ def test_ci_linux_uses_reduced_matrix(self):
self.assertEqual(
matrix,
[
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.10",
"amdgpu_families": "gfx94X-dcgpu",
},
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.11",
Expand Down Expand Up @@ -70,7 +65,7 @@ def test_ci_windows_uses_reduced_matrix(self):
[
{
"python_version": "3.12",
"pytorch_git_ref": "release/2.10",
"pytorch_git_ref": "release/2.11",
"amdgpu_families": "gfx110X-all",
},
],
Expand Down Expand Up @@ -98,7 +93,7 @@ def test_explicit_versions_and_refs_narrow_matrix(self):

def test_filters_exact_unsupported_family(self):
# Unsupported families are filtered while supported ones are kept.
for pytorch_git_ref in ("release/2.10", "release/2.13"):
for pytorch_git_ref in ("release/2.13",):
with self.subTest(pytorch_git_ref=pytorch_git_ref):
matrix = m.generate_pytorch_matrix_for_release_type(
release_type="dev",
Expand Down Expand Up @@ -182,7 +177,7 @@ def test_generated_rows_cover_workflow_matrix_inputs(self):
matrix = m.generate_pytorch_matrix_for_release_type(
release_type=release_type,
python_versions=["3.12"],
pytorch_git_refs=["release/2.10"],
pytorch_git_refs=["release/2.11"],
amdgpu_families="gfx94X-dcgpu",
platform=platform,
)
Expand Down
4 changes: 2 additions & 2 deletions build_tools/github_actions/tests/summarize_test_pytorch_workflow_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
def _make_args(
index_url,
device_extras="",
torch_version="2.10.0+rocm7.12.0a20260501",
pytorch_git_ref="release/2.10",
torch_version="2.11.0+rocm7.12.0a20260501",
pytorch_git_ref="release/2.11",
python_version="3.12",
):
return argparse.Namespace(
Expand Down
10 changes: 5 additions & 5 deletions external-builds/pytorch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ See the following table for how each version is supported:
| 2.12 alpha | Previously built | Previously built |
| 2.11 | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.11` branch](https://github.com/ROCm/pytorch/tree/release/2.11)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/ROCm/pytorch/blob/release/2.11/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio](https://github.com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.11/related_commits)</li><li>[pytorch/vision](https://github.com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.11/related_commits)</li><li>[ROCm/apex `release/1.11.0` branch](https://github.com/ROCm/apex/tree/release/1.11.0) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.11/related_commits)</li></ul> | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.11` branch](https://github.com/ROCm/pytorch/tree/release/2.11)</li><li>[pytorch/audio](https://github.com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.11/related_commits)</li><li>[pytorch/vision](https://github.com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.11/related_commits)</li></ul> |
| 2.11 alpha | Previously built | Previously built |
| 2.10 | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.10` branch](https://github.com/ROCm/pytorch/tree/release/2.10)<ul><li>[ROCm/triton](https://github.com/ROCm/triton) - [`ci_commit_pins/triton.txt`](https://github.com/ROCm/pytorch/blob/release/2.10/.ci/docker/ci_commit_pins/triton.txt)</li></ul></li><li>[pytorch/audio](https://github.com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.10/related_commits)</li><li>[pytorch/vision](https://github.com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.10/related_commits)</li><li>[ROCm/apex `release/1.10.0` branch](https://github.com/ROCm/apex/tree/release/1.10.0) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.10/related_commits)</li></ul> | ✅ Using downstream ROCm/pytorch fork<br><ul><li>[ROCm/pytorch `release/2.10` branch](https://github.com/ROCm/pytorch/tree/release/2.10)</li><li>[pytorch/audio](https://github.com/pytorch/audio) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.10/related_commits)</li><li>[pytorch/vision](https://github.com/pytorch/vision) - ["rocm related commit"](https://github.com/ROCm/pytorch/blob/release/2.10/related_commits)</li></ul> |
| 2.10 | Previously built | Previously built |
| 2.10 alpha | Previously built | Previously built |
| 2.9 | Previously built | Previously built |
| 2.9 alpha | Previously built | Previously built |
Expand Down Expand Up @@ -530,27 +530,27 @@ which can then be read by the checkout script.
python build_tools/github_actions/generate_pytorch_source_manifest.py \
--rocm-version 7.13.0a20260501 \
--output external-builds/pytorch/pytorch_manifest.json \
--pytorch-git-refs "release/2.10"
--pytorch-git-refs "release/2.11"

# Multiple versions (computed filenames in a directory):
python build_tools/github_actions/generate_pytorch_source_manifest.py \
--rocm-version 7.13.0a20260501 \
--manifest-dir external-builds/pytorch/manifests/ \
--pytorch-git-refs "release/2.10 release/2.11 nightly"
--pytorch-git-refs "release/2.11 release/2.12 nightly"

# The target platform defaults to the current host. Pass it explicitly when
# generating a manifest for another platform:
python build_tools/github_actions/generate_pytorch_source_manifest.py \
--rocm-version 7.13.0a20260501 \
--platform windows \
--output manifest.json \
--pytorch-git-refs "release/2.10"
--pytorch-git-refs "release/2.11"

# Only pytorch (skip audio/vision/triton/apex):
python build_tools/github_actions/generate_pytorch_source_manifest.py \
--rocm-version 7.13.0a20260501 \
--output external-builds/pytorch/manifest.json \
--pytorch-git-refs "release/2.10" \
--pytorch-git-refs "release/2.11" \
--projects pytorch
```

Expand Down
2 changes: 1 addition & 1 deletion external-builds/pytorch/skip_tests/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@
# We should fix the test to fail/skip more gracefully.
# subprocess.CalledProcessError: Command '['where', 'cl']' returned non-zero exit status 1.
"test_multi_grad_all_hooks",
# This is/was also failing on gfx942 linux, see the 2.10 skip test file.
# This is/was also failing on gfx942 linux, see the per-release skip test files.
# AssertionError: "Simulate error" does not match "grad can be implicitly created only for scalar outputs"
"test_reentrant_parent_error_on_cpu_cuda",
],
Expand Down
Loading
Loading