build: disable rocm-smi-lib build (deprecated) by marifamd · Pull Request #6852 · ROCm/TheRock

marifamd · 2026-07-24T18:35:27Z

Motivation

ROCm SMI is deprecated in favor of AMD SMI. Stop building it as part of the ROCm stack.

Technical Details

Subproject build (base/CMakeLists.txt):

Pass -DROCM_SMI_DISABLE=True to the rocm_smi_lib subproject so it configures to a no-op and installs nothing

Issue Tracking

JIRA ID: ROCM-966

Dependency

Requires the consumer-side gate in rocm-systems: ROCm/rocm-systems#9227. Merge that first, otherwise the flag is ignored.

therock-pr-bot · 2026-07-24T18:36:31Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-07-24T18:36:33Z

🎉 All checks passed! This PR is ready for review.

nunnikri · 2026-07-26T06:14:11Z

Might have to merge ROCm/rocm-systems#9227 first. The current ci is still generating rocm-smi

 dpkg -c amdrocm-base7.15_7.15.0~dev20260724-30117594320_amd64.deb | grep smi
drwxr-xr-x root/root         0 2026-07-24 13:43 ./opt/rocm/core-7.15/include/rocm_smi/
-rw-r--r-- root/root     62596 2026-07-24 13:42 ./opt/rocm/core-7.15/include/rocm_smi/kfd_ioctl.h
-rw-r--r-- root/root    191523 2026-07-24 13:42 ./opt/rocm/core-7.15/include/rocm_smi/rocm_smi.h
-rw-r--r-- root/root      2440 2026-07-24 13:42 ./opt/rocm/core-7.15/include/rocm_smi/rocm_smi64Config.h
drwxr-xr-x root/root         0 2026-07-24 13:43 ./opt/rocm/core-7.15/lib/cmake/rocm_smi/
-rw-r--r-- root/root      2837 2026-07-24 13:42 ./opt/rocm/core-7.15/lib/cmake/rocm_smi/rocm_smi-config-version.cmake
-rw-r--r-- root/root      2579 2026-07-24 13:42 ./opt/rocm/core-7.15/lib/cmake/rocm_smi/rocm_smi-config.cmake
-rw-r--r-- root/root      1242 2026-07-24 13:42 ./opt/rocm/core-7.15/lib/cmake/rocm_smi/rocm_smiTargets-release.cmake
-rw-r--r-- root/root      4141 2026-07-24 13:42 ./opt/rocm/core-7.15/lib/cmake/rocm_smi/rocm_smiTargets.cmake
-rw-r--r-- root/root   1630632 2026-07-24 13:43 ./opt/rocm/core-7.15/lib/librocm_smi64.so.1.0
drwxr-xr-x root/root         0 2026-07-24 13:43 ./opt/rocm/core-7.15/libexec/rocm_smi/
-rwxr-xr-x root/root    220756 2026-07-24 13:42 ./opt/rocm/core-7.15/libexec/rocm_smi/rocm_smi.py
-rwxr-xr-x root/root     24269 2026-07-24 13:42 ./opt/rocm/core-7.15/libexec/rocm_smi/rsmiBindings.py
-rwxr-xr-x root/root      2117 2026-07-24 13:42 ./opt/rocm/core-7.15/libexec/rocm_smi/rsmiBindingsInit.py
drwxr-xr-x root/root         0 2026-07-24 13:43 ./opt/rocm/core-7.15/share/doc/rocm-smi-lib/
-rw-r--r-- root/root      1080 2026-07-24 13:42 ./opt/rocm/core-7.15/share/doc/rocm-smi-lib/LICENSE.md
lrwxrwxrwx root/root         0 2026-07-24 15:03 ./opt/rocm/core-7.15/bin/rocm-smi -> ../libexec/rocm_smi/rocm_smi.py
lrwxrwxrwx root/root         0 2026-07-24 15:03 ./opt/rocm/core-7.15/lib/librocm_smi64.so -> librocm_smi64.so.1
lrwxrwxrwx root/root         0 2026-07-24 15:03 ./opt/rocm/core-7.15/lib/librocm_smi64.so.1 -> librocm_smi64.so.1.0

nunnikri

Changes looks fine. But would like to wait for rocm-systems bump and then ci completion to confirm the change is indeed helping

Use amd-smi list in the hermetic docker workflow and drop the deprecated rocm-smi-lib-dbgsym package (ROCm/TheRock#6852).

Cherry-pick of #1113 (02298de) with SMI-only Bazel changes on this release branch. Unblocks JAX wheel builds when librocm_smi64 is absent from the ROCm SDK (ROCm/TheRock#6852).

gulsumgudukbay · 2026-08-27T18:59:25Z

https://github.com/ROCm/TheRock/actions/runs/33101375634 started this job for testing unblocking PRs for JAX/XLA in order to fix the JAX build on this PR.

Use amd-smi list in the hermetic docker workflow and drop the deprecated rocm-smi-lib-dbgsym package (ROCm/TheRock#6852).

Pass -DROCM_SMI_DISABLE=True to the rocm_smi_lib subproject so it configures to a no-op. rocm-smi-lib is deprecated in favor of AMD SMI. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>

ROCM_SMI_DISABLE gate caused rocm_smi64 and oam to not be defined which in turn caused post_hook_rocm_smi_lib.cmake to return error. This prevented base from building which cascades down into rocprofiler_sdk failing and finally causing the compiler-runtime stage to fail. Added TARGET guards in post_hook_rocm_smi_lib.cmake to skip including those targets and unblock everything downstream.

…h and rocm sdk core

Cherry-pick of #1113 (02298de) with SMI-only Bazel changes on this release branch. Unblocks JAX wheel builds when librocm_smi64 is absent from the ROCm SDK (ROCm/TheRock#6852). (cherry picked from commit 45f7885)

marifamd · 2026-08-29T14:25:10Z

@ScottTodd Doesn't look like the CI failures are related to the PR, can you please take a look?

ScottTodd

Yes CI signal on this looks successful enough.

) Cherry-pick of ROCm#1113 (02298de) with SMI-only Bazel changes on this release branch. Unblocks JAX wheel builds when librocm_smi64 is absent from the ROCm SDK (ROCm/TheRock#6852). (cherry picked from commit 45f7885)

## Motivation remove code that is dependent on rocm-smi due to rocm-smi is not available in artifactory. ## Technical Details rocm-smi is not built out by TheRock [#6852](ROCm/TheRock#6852) ## Issue Tracking JIRA ID: ROCM-30480 ## Test Plan Unit_hipP2pLinkTypeAndHopFunc ## Test Result PASSED ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

(#11093) ## Motivation remove code that is dependent on rocm-smi due to rocm-smi is not available in artifactory. ## Technical Details rocm-smi is not built out by TheRock [#6852](ROCm/TheRock#6852) ## Issue Tracking JIRA ID: ROCM-30480 ## Test Plan Unit_hipP2pLinkTypeAndHopFunc ## Test Result PASSED ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#11093 (commit 8a341d0)

) Cherry-pick of ROCm#1113 (02298de) with SMI-only Bazel changes on this release branch. Unblocks JAX wheel builds when librocm_smi64 is absent from the ROCm SDK (ROCm/TheRock#6852). (cherry picked from commit 45f7885)

## Motivation ROCm SMI now ships with deprecation notices (ROCm/rocm-systems#13131), so build it again instead of skipping it. Partially reverts #6852. This is intended to add rocm-smi back in for 10.2, but only for external users who didn't get the deprecation notice. This is meant to be a final build with a warning in the output for users to move over to amd-smi. ## Technical Details | File | Change | |------|--------| | `base/CMakeLists.txt` | Drop `-DROCM_SMI_DISABLE=True` | | `base/post_hook_rocm_smi_lib.cmake` | Restore libdrm install-interface include dirs for `rocm_smi64` / `oam` | | `rocm-sdk-core` `setup.py`, `_cli.py` | Restore the `rocm-smi` console script | | `rocm_sdk/_dist_info.py` | Restore the `rocm_smi64` core library entry | | `rocm_sdk/tests/core_test.py` | Restore the `rocm-smi` console-script test | | `amdrocm-core` / `amdrocm-developer-tools` postinst + prerm | Add `rocm-smi` next to `amd-smi` in the update-alternatives lists (dropped by #7672 while rocm-smi-lib was disabled) | Not restored: `rocm_smi64` in the PyTorch wheel preload list (`external-builds/pytorch/build_prod_wheels.py`). ## Test Plan - CI build + `rocm-sdk` core tests - `python3 -m pytest build_tools/tests/sdk_targets_test.py` - Render the 4 postinst/prerm templates (deb), `bash -n`, run against a fake prefix with a stub `update-alternatives` ## Test Result - `sdk_targets_test.py`: 5 passed - `_dist_info` registers `rocm_smi64` in `core` - All 4 scripts pass `bash -n`; postinst installs and prerm removes `/usr/bin/rocm-smi` alongside `amd-smi` ## Issue Tracking JIRA ID: ROCM-21935 --------- Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> Co-authored-by: gabrpham <Gabriel.Pham@amd.com>

github-project-automation Bot added this to TheRock Triage Jul 24, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Jul 24, 2026

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 24, 2026

marifamd force-pushed the users/marifamd/rocm-smi-disable branch from c21723e to 086ab80 Compare July 30, 2026 02:54

therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jul 30, 2026

nunnikri approved these changes Jul 30, 2026

View reviewed changes

marifamd force-pushed the users/marifamd/rocm-smi-disable branch from 4b033b1 to 0bec2b8 Compare August 3, 2026 00:28

gabrpham requested a review from a team as a code owner August 11, 2026 20:56

ScottTodd reviewed Aug 11, 2026

View reviewed changes

Comment thread rocm-libraries Resolved

yalmusaf force-pushed the users/marifamd/rocm-smi-disable branch from fcc621b to 671fdbd Compare August 11, 2026 21:12

marifamd force-pushed the users/marifamd/rocm-smi-disable branch from 671fdbd to 6290605 Compare August 17, 2026 18:11

gabrpham requested a review from marbre as a code owner August 19, 2026 21:13

gulsumgudukbay added a commit to ROCm/rocm-jax that referenced this pull request Aug 25, 2026

Replace rocm-smi with amd-smi in CI and Docker build

5e58620

Use amd-smi list in the hermetic docker workflow and drop the deprecated rocm-smi-lib-dbgsym package (ROCm/TheRock#6852).

mminutoli pushed a commit to ROCm/rocm-jax that referenced this pull request Aug 27, 2026

Replace rocm-smi with amd-smi in CI and Docker build (#511)

9022502

Use amd-smi list in the hermetic docker workflow and drop the deprecated rocm-smi-lib-dbgsym package (ROCm/TheRock#6852).

marifamd and others added 3 commits August 27, 2026 17:26

build: disable rocm-smi-lib build (deprecated)

2c03b53

Pass -DROCM_SMI_DISABLE=True to the rocm_smi_lib subproject so it configures to a no-op. rocm-smi-lib is deprecated in favor of AMD SMI. Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>

remove additional rocm_smi references from build procedures in pytorc…

dabcf04

…h and rocm sdk core

gabrpham force-pushed the users/marifamd/rocm-smi-disable branch from 9ac13cb to dabcf04 Compare August 27, 2026 22:26

gulsumgudukbay mentioned this pull request Aug 28, 2026

[ROCm] Migrate SMI device queries from rocm_smi to amd_smi ROCm/xla#1144

Merged

gulsumgudukbay mentioned this pull request Aug 28, 2026

[ROCm] Bump XLA module pin to pick up the amd_smi migration ROCm/jax#872

Merged

removed post_hook_rocm_smi_lib.cmake

677f652

ScottTodd self-requested a review August 28, 2026 21:37

ScottTodd approved these changes Aug 31, 2026

View reviewed changes

Comment thread base/CMakeLists.txt Resolved

gabrpham merged commit 50dc726 into main Aug 31, 2026
176 of 180 checks passed

gabrpham deleted the users/marifamd/rocm-smi-disable branch August 31, 2026 22:59

github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 31, 2026

LeoZhao-BJ mentioned this pull request Sep 2, 2026

fix(hip-tests): remove code that is dependent on rocm-smi ROCm/rocm-systems#11093

Merged

1 task done

This was referenced Sep 10, 2026

[Issue]: Build fails on ROCm 10.x — rocm_smi/rocm_smi.h not found (replaced by amd_smi) ROCm/mori#638

Closed

fix: migrate GPU topology from rocm_smi to amd_smi (ROCm 10.1+) ROCm/mori#663

Merged

marifamd mentioned this pull request Oct 9, 2026

build: re-enable rocm-smi-lib build #8907

Merged

1 task done

HereThereBeDragons mentioned this pull request Oct 28, 2026

build: re-enable rocm-smi-lib build (#8907) #9574

Merged

Navigation Menu

Repository navigation

build: disable rocm-smi-lib build (deprecated) - #6852

build: disable rocm-smi-lib build (deprecated)#6852
gabrpham merged 4 commits into
mainfrom
users/marifamd/rocm-smi-disable

marifamd commented Jul 24, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jul 24, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Jul 24, 2026 •

edited

Loading

Uh oh!

nunnikri commented Jul 26, 2026

Uh oh!

nunnikri left a comment

Uh oh!

Uh oh!

gulsumgudukbay commented Aug 27, 2026

Uh oh!

marifamd commented Aug 29, 2026

Uh oh!

ScottTodd left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

marifamd commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Issue Tracking

Dependency

Uh oh!

therock-pr-bot Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nunnikri commented Jul 26, 2026

Uh oh!

nunnikri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gulsumgudukbay commented Aug 27, 2026

Uh oh!

marifamd commented Aug 29, 2026

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marifamd commented Jul 24, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 24, 2026 •

edited

Loading

therock-pr-bot Bot commented Jul 24, 2026 •

edited

Loading